From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2085.outbound.protection.outlook.com [40.107.212.85]) by sourceware.org (Postfix) with ESMTPS id 96EC23858405 for ; Wed, 23 Mar 2022 15:13:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96EC23858405 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q0qcXF2LErENoezP5dmACrwmRsSscEENEPsmJ0HbcN8lmNV9B9UbFOlJOtscXQZtqFC9dZ0NWQvwP2JKmpEtFdFZfiQHjnLTXYIO1GT9fBsTAu/eFWkIEjnqGlYr1xUDWjZszpZ6Iy2CAGK9qgSKI/B0G0PhTAnwhs7sHqA6bxfZ6WOtEdXMQl1tpLOaHdULn+/l3zF4kvQ3rT/AJ1kr5mo9kwUoIjGbJygcsrDYHtPiEFIRFSxU8agvhDQR6/ruJ0WF3dPjD/4Gu60cK8ts1FYiFncOnTTmH9fDucoYj0vdbR4ojgBgbXs//aY2Kj7ztc0PSntSGCHBX6X+qFmimg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFGEimRqEvXPPD3Lp0va8kUNeBPS0kJ7rwUaGpEfOF8=; b=RmuyFIOt1UqKCAgqv7IV7du+cGF0Y3fl3+A62WlBjON+b8wQ/aWqRCDyHautbjpkp63qBj4gfx+psNXE8RP4zkpt1uNpupiOyPkrFLLiQJ0mm2I2orSk+7BxIEaeeCdKBH7x88miZ9mu276YN87DWl6JMR0T3yfcaLJdB8DxSg3YblSJSuyWOR6SG8Gc44lyV81skktWfB6LFOOFqdy4KV1YpUDrMTfWfEyb3ZxP69+93DnQr9Bl9ZGs/fmKkNo15Uh2vMdcDSzCWLY7KqvS8gwh1ucgxDHea+0N/7nc0Up3B4gmCjszIYQXpI2jRS4j7oSaVX63AdimurBlp4UzJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labware.com; dmarc=pass action=none header.from=labware.com; dkim=pass header.d=labware.com; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by BYAPR17MB2583.namprd17.prod.outlook.com (2603:10b6:a03:81::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.23; Wed, 23 Mar 2022 15:13:12 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::b4e5:7f52:3fb8:ef7b]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::b4e5:7f52:3fb8:ef7b%7]) with mapi id 15.20.5102.016; Wed, 23 Mar 2022 15:13:12 +0000 Message-ID: <14d27757ce39bcc7a19f74508e689acfa7fa33c2.camel@labware.com> Subject: Re: [pushed] gdb/mi: consistently notify user when GDB/MI client uses -thread-select From: Jan Vrany To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org Cc: Andrew Burgess Date: Wed, 23 Mar 2022 15:13:06 +0000 In-Reply-To: References: <20220316150914.1254897-1-jan.vrany@labware.com> <78570a7f-f6c0-5e1b-4178-c9ce401feab7@simark.ca> <897bd508133687e4d30994deecdd87786d71334d.camel@labware.com> <0bcb4286c01054c30c3539c76bd6426ff3b333eb.camel@labware.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.43.3-1+b1 X-ClientProxiedBy: LO2P265CA0499.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::6) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f278304d-6648-4053-4940-08da0cdfa568 X-MS-TrafficTypeDiagnostic: BYAPR17MB2583:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OOGA1hmJmkMe0GG38H8Jt5aEK2S/mrDbasYwyZhwvLbQ4JTHl3rWNDW4nnRxtPogH+BYjUGmJt75aZaFVI0GSlcQunnGW8uFk90Vfr34H//h/wUHtHRsd87HoLIE20rT8BJpJzreLjcLtCnhMLhhlh1JjzHfDfL/gES4CRm9qUOp5eO8XyVu++XoD7xCJPIHIeGDHF/7gwoLSfO5cEQ2zI1UFDdHbb87drpPq7iboXQa1DJxvqyO+frd9rfZv7gQH8UW5a1UvYg02qtVhAPQQeCMq8lggj/dA8vBLk/QVI2vTjMEWf+MDRTr2EZGtcAk0jn9biUyB/vjbG02jSvp/3pZJ5MErfOyoMXmDjoTUZyeBiipxr3fY+Uo4IJttEfL862Ty254evTsfuIK3Amsf9yygxzEbBOIjFbhGA12Um1Ua23I2H+Wwl0SioQ7PxrjWmNUs6q3jNPdIaMlF0mjRXiICnBF2j3qIraGgj5XeFRqn3i3wK/FSHP50AAppkUgZm+3EzI7+zcO3hoXdmbwO4iAfK0H5f/dENlihtYUkevOxUvRmSLABLlvsXjadbr69vEE2Lnt+fqX6Fdnkw+IAeA/7IMNlFiVx844GV5om5AN8fNq2xbADoCEEtcxRHst0Lcsc7TirH7AVeVvBv8RIn1wllj4pYdnxCouzMjs7P8EgoO2DKufUU075BMUiQ0HZJsUopYmoBiWu6/ZVFuxY5Ng3IGgdep75mXzRSnZhjVf04p6xQbsCeXiRebrszMqx1Y6j5Kz+Tu/ewwT9IFMAu9s2Wj4Sp3G+o0RdnCrgEPQUxXc/w+J7jCT43KxaZ5Q X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(66946007)(44832011)(86362001)(316002)(6486002)(36756003)(83380400001)(8676002)(66476007)(186003)(110136005)(38350700002)(38100700002)(66556008)(26005)(2616005)(8936002)(4326008)(6506007)(52116002)(508600001)(6666004)(84970400001)(5660300002)(6512007)(403724002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emJTYVlOVlFZYXVkNnFhZFU4VjVJNmtuRmtLTWlSR3UwNDlHTnE3bG5HdVFM?= =?utf-8?B?dlBXZXFqVkNlV3VZVEtsOFZrK3AzYlpVNlBnOHQ3a3hHRGZRcWNIRmRxWVFr?= =?utf-8?B?Nm9CRDZqb3BWMUwrR3ZEbEJrSldaQVFha2l3dUh3aWxMYWFXWEUzMGlPZ291?= =?utf-8?B?UnFpblV1UnowQUMrNVhPaW5LYno4YTVHbmE3Ykx1V1RkbGRUVXVSeEEvVWRu?= =?utf-8?B?QnRpRm40MVdEam5POWh5Q0xqMmdOQ3FRSkQ1UnlBRDBEUWowaFlIbXFYbkRF?= =?utf-8?B?akpmZ2JReklpOUtSWWdFMFo0VUhhRUkraUNyMUZsbGwreWtKNXQvcm43NGQ3?= =?utf-8?B?MWYvQ0xKWEQ5Vk14MWhsTWlydTBqUmFpbEdoRlAvbmhnNFN6bXhNYjJIR0Ew?= =?utf-8?B?Y3V0UzN3dDBBSklTZjhIVWpFQWN1Um5UMnM0Mlc1SlJZNllkZGwrSEt1ejJK?= =?utf-8?B?LzJjSjFUMlpiWGRIeHFBdndva0kvb2twWkRSZ3RUUXZpdVNMODFHUnlHSmRH?= =?utf-8?B?NkUvcmhSUmNmVitNZzEwejJEN0ZheitNMGpwanpxcUVsSTdSb2dXMzVHN2NZ?= =?utf-8?B?VmtLUmZGUUNsVEgxdEhOUUNESmRpYVRSbjVXTnliQlppZ1laazNSNjZONUtY?= =?utf-8?B?TzQzYW9HWWJkSkEzSjR3WG5WK3I2WGlUNkJaaUNNVzhKMGFJaldkcG9uMVFV?= =?utf-8?B?QzhrS0VxOXNWTHJpMElYSm9xR09TRUQ1K2JTRk9DNXJHajBma09sb1JUZjZo?= =?utf-8?B?TFBxdjJTZ3A2cCthb2FPM1VMOHR1UlFvL2JSemNsWGJ0VExpTmlwQmRKKy9Z?= =?utf-8?B?VkZwU1FNY2tVOHIvVzhYMW5namV6bGxtQ3dVV2pWOHdHQ25LNzNNWGk5bkQ5?= =?utf-8?B?VER1dk9xUnQ5blRtVmQzdVd2TVRERnVYS0xPdTAyZnRrd0dWRnRieFZxanBI?= =?utf-8?B?c001V2FtTlpxQWxsUWZ2UDZ5dllqSHFONXlRVWdxSER5U2wvR2VNNi90VnhV?= =?utf-8?B?NUdLTXRRaVRVNHc4YjFvdDNSSmNVcW54QXg2QmVXdy9SWnJidUsvbTc5RXVo?= =?utf-8?B?aGd0SGJ6d29FOEI4Z0NhTXJ5ZmFJU1ptRUJvVHhOMzE0K3IxRkRzRHBKOGpa?= =?utf-8?B?Wkk2dHZLaXFhZUdrUGFTVnZ3RWlUQ3ROSG1JZTNCeEZrSzZJc252cXNGa3lu?= =?utf-8?B?Mm4zZUtXakVvc0pyYmg1Ylo5MDd1Q1RjRkZoQ0FldjJ6K0w0R1VuWVlRWUth?= =?utf-8?B?YkYySUNaUENqdlNkaG52N2NLdVdMKy9taWM4dytjNk5hVXhzRHplcW54SUhr?= =?utf-8?B?QmpqUUFNdjNhVXNSWXlrZlpnc0ZvaUFZVEdqdFRjL0wzbXBwNncrWU9QQVNL?= =?utf-8?B?U2M5ZFZBOGtPK241VE4rZkdGdzMzaWUxZ0RCenNyMjZVbDNScHlDYitLY2cv?= =?utf-8?B?OW9uMlNQdXRlYS9XY1IzNnVsMVN4cUxuaTZtdGVlM0I4dWl1c2wvSE9NV2R1?= =?utf-8?B?ZWRONG93ZkRCRFlsSmtvR2NCNDZSeVVZZWZhRDRvczdjRDNzYit5ejBMellv?= =?utf-8?B?ckpnb1hPc29EYWNpaTlLdmN3QjUxcG43Zi9wWHdkMzZCU0Vla3N1dm9INWVs?= =?utf-8?B?STF2ZGlwTmxsUnd4eVBFVDBhL1Fubm43Mm5hS3pkazNtQXBoRkw5U2tPbzVv?= =?utf-8?B?UXpnbGdMakRzbkNHMmtCeFFJbGtCYzVLam10L1hYVHg0cEJaWTR2RTJkU09o?= =?utf-8?B?azU2ODVrdzF0SW1rNTBFR29oYWVDOU5waHhBNWF1bkZBYlFncUtGMDJHekYv?= =?utf-8?B?WlBBUXZtWE5pMzViMG9BZVBYR2M5OUh1RURvMnI1VlNrRWc0WXkxVzVsblRJ?= =?utf-8?B?VVg3WkRobmJUWTNwaDd4dThHWG93UHpOb0RxTUxvUjhGOVlTZU5GWjAraFFG?= =?utf-8?Q?mA9uMj3rP9uCYGbUJEhQl394lQjhsBJ/?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: f278304d-6648-4053-4940-08da0cdfa568 X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 15:13:12.1630 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yTLm2ROKIvALZ5ecDLRrphSdjQg6wJ0tA7/gPzlNrtR5/rdE8tOFQWYVCxlF83EWEHz7ZkdEOyPBgnKgjtqUyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR17MB2583 X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2022 15:13:21 -0000 Hi, On Wed, 2022-03-23 at 08:36 -0400, Simon Marchi wrote: > > Just tried on Ubuntu 20.04 and I do not any problem.=20 >=20 > I'm trying to look a bit more into it. The state is that we have thread > 2 already selected, issue a `-thread-select 2` on the MI UI, and expect > to not have a CLI notification to say that the thread changed, since we > try to select the already selected thread. >=20 > Before your patch I get: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0-thread-select 2 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0^done,new-thread-id=3D"2",frame=3D{level=3D"0",ad= dr=3D"0x00005555555551b8",func=3D"child_sub_function",args=3D[],file=3D"/ho= me/smarchi/src/binutils- > gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c",fullname=3D"/home/= smarchi/src/binutils-gdb/gdb/testsuite/gdb.mi/user-selected-context- > sync.c",line=3D"33",arch=3D"i386:x86-64"} >=20 > =C2=A0=C2=A0=C2=A0=C2=A0(gdb)=20 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0PASS: gdb.mi/user-selected-context-sync.exp: mode= =3Dall-stop: test_mi_thread_select: thread 1.2: -thread-select again > =C2=A0=C2=A0=C2=A0=C2=A0print 666 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0$9 =3D 666 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0(gdb) PASS: gdb.mi/user-selected-context-sync.exp= : mode=3Dall-stop: test_mi_thread_select: thread 1.2: -thread-select again,= event on CLI, ensure no output > CLI >=20 > After: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0-thread-select 2 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0^done,new-thread-id=3D"2",frame=3D{level=3D"0",ad= dr=3D"0x00005555555551b8",func=3D"child_sub_function",args=3D[],file=3D"/ho= me/smarchi/src/binutils- > gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c",fullname=3D"/home/= smarchi/src/binutils-gdb/gdb/testsuite/gdb.mi/user-selected-context- > sync.c",line=3D"33",arch=3D"i386:x86-64"} >=20 > =C2=A0=C2=A0=C2=A0=C2=A0(gdb)=20 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0PASS: gdb.mi/user-selected-context-sync.exp: mode= =3Dall-stop: test_mi_thread_select: thread 1.2: -thread-select again > =C2=A0=C2=A0=C2=A0=C2=A0[Switching to thread 1.2 (Thread 0x7ffff7d99700 (= LWP 1885257))] >=20 > =C2=A0=C2=A0=C2=A0=C2=A0#0 child_sub_function () at /home/smarchi/src/bi= nutils-gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c:33 >=20 > =C2=A0=C2=A0=C2=A0=C2=A033 dummy =3D !dummy; /* thread loop line */ >=20 > =C2=A0=C2=A0=C2=A0=C2=A0print 666 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0$9 =3D 666 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0(gdb) FAIL: gdb.mi/user-selected-context-sync.exp= : mode=3Dall-stop: test_mi_thread_select: thread 1.2: -thread-select again,= event on CLI, ensure no output > CLI >=20 > So there is really a spurious "Switching to thread 1.2" notification in > my case. >=20 > Trying a simpler case, just an empty main program, I do this (/dev/pts/8 > being the tty for my MI UI): >=20 > =C2=A0=C2=A0=C2=A0=C2=A0$ ./gdb -q -nx --data-directory=3Ddata-directory = a.out -ex "new-ui mi /dev/pts/8" -ex start >=20 > If I then type `-thread-select 1` on the MI UI, I do get: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0[Switching to thread 1 (process 1891548)] >=20 > ... which is unexpected. Before your patch, I don't get it. Can you > give this small test a try? >=20 I gave it a go but I'm sorry: everything seem to work as expected=C2=A0 here. I do not get "[Switching to thread 1 (process 1891548)]" message on CLI when -thread-select already selected thread.=20 I must be doing something differently. What commit is failing for you? What's your ./configure incantation? I'm happy to sit down with you and have a closer look at this, maybe using= =C2=A0 IRC or something.=20 Jan > Simon