public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Cc: sandra@codesourcery.com
Subject: [PATCH] Fix PR 8841 for nios2-linux
Date: Mon, 16 Oct 2017 11:50:00 -0000	[thread overview]
Message-ID: <1508154626-389-1-git-send-email-yao.qi@linaro.org> (raw)

This patch is to use gdbarch method code_of_frame_writable, to skip
signal trampoline frame for breakpoint setting on nios2-linux.  The patch
was written last year, but forgot to upstream it.

I don't have the env to test this patch, so Sandra could you try this
patch?

gdb:

2017-10-16  Yao Qi  <yao.qi@linaro.org>

	PR gdb/8841
	* nios2-linux-tdep.c (nios2_linux_code_of_frame_writable): New
	function.
	(nios2_linux_init_abi): Install gdbarch code_of_frame_writable.
---
 gdb/nios2-linux-tdep.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gdb/nios2-linux-tdep.c b/gdb/nios2-linux-tdep.c
index 8cada54..788d711 100644
--- a/gdb/nios2-linux-tdep.c
+++ b/gdb/nios2-linux-tdep.c
@@ -185,6 +185,22 @@ static struct tramp_frame nios2_r2_linux_rt_sigreturn_tramp_frame =
   nios2_linux_rt_sigreturn_init
 };
 
+/* Implement the code_of_frame_writable gdbarch method.  */
+
+static int
+nios2_linux_code_of_frame_writable (struct gdbarch *gdbarch,
+				    struct frame_info *frame)
+{
+  if (get_frame_type (frame) == SIGTRAMP_FRAME)
+    {
+      /* The kernel creates a signal trampoline at address 0x1044
+	 that GDB cannot write to to set a software breakpoint.  */
+      return 0;
+    }
+  else
+    return 1;
+}
+
 /* When FRAME is at a syscall instruction, return the PC of the next
    instruction to be executed.  */
 
@@ -234,6 +250,9 @@ nios2_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 
   tdep->syscall_next_pc = nios2_linux_syscall_next_pc;
 
+  set_gdbarch_code_of_frame_writable (gdbarch,
+				      nios2_linux_code_of_frame_writable);
+
   /* Index of target address word in glibc jmp_buf.  */
   tdep->jb_pc = 10;
 }
-- 
1.9.1

             reply	other threads:[~2017-10-16 11:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 11:50 Yao Qi [this message]
2017-10-19 17:37 ` Sandra Loosemore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508154626-389-1-git-send-email-yao.qi@linaro.org \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).