public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Djordje Todorovic <djordje.todorovic@rt-rk.com>
To: macro@imgtec.com
Cc: binutils@sourceware.org,	gdb-patches@sourceware.org,
	asowda@cisco.com,	petar.jovanovic@rt-rk.com,
	nemanja.popov@rt-rk.com,	nikola.prica@rt-rk.com,
	Djordje Todorovic <djordje.todorovic@rt-rk.com>
Subject: [PATCH 3/3] Add test for fetching TLS from core file
Date: Tue, 17 Oct 2017 13:50:00 -0000	[thread overview]
Message-ID: <1508248194-26950-3-git-send-email-djordje.todorovic@rt-rk.com> (raw)
In-Reply-To: <1508248194-26950-1-git-send-email-djordje.todorovic@rt-rk.com>

GDB needs correct PID in order to fetch value of TLS variable from
core file.  On MIPS platforms it was omitted and fetching value of
TLS variable was not available.

This adds a new test in order to be sure if GDB on native platforms
can successfully fetch value of TLS variable.

gdb/testsuite:

	* gdb.threads/tls-core.c: New file.
	* gdb.threads/tls-core.exp: Likewise.
---
 gdb/testsuite/gdb.threads/tls-core.c   | 44 +++++++++++++++++++++++++
 gdb/testsuite/gdb.threads/tls-core.exp | 60 ++++++++++++++++++++++++++++++++++
 2 files changed, 104 insertions(+)
 create mode 100644 gdb/testsuite/gdb.threads/tls-core.c
 create mode 100644 gdb/testsuite/gdb.threads/tls-core.exp

diff --git a/gdb/testsuite/gdb.threads/tls-core.c b/gdb/testsuite/gdb.threads/tls-core.c
new file mode 100644
index 0000000..e41c584
--- /dev/null
+++ b/gdb/testsuite/gdb.threads/tls-core.c
@@ -0,0 +1,44 @@
+/* This test is part of GDB, the GNU debugger.
+
+   Copyright 2017 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <pthread.h>
+
+#define NUMBER_OF_THREADS 5
+
+int __thread foo = 0xdeadbeef;
+
+void *
+thread (void *in) /* BREAK */
+{
+  int *tmp = (int *) in;
+  int value = *tmp;
+  foo += *tmp;
+  while (1)
+    sleep (10);
+}
+
+int
+main (void)
+{
+  pthread_t threads[NUMBER_OF_THREADS];
+  int i;
+  for (i = 0; i < NUMBER_OF_THREADS; i++)
+    pthread_create (&threads[i], NULL, thread, &i);
+}
\ No newline at end of file
diff --git a/gdb/testsuite/gdb.threads/tls-core.exp b/gdb/testsuite/gdb.threads/tls-core.exp
new file mode 100644
index 0000000..dc291ab
--- /dev/null
+++ b/gdb/testsuite/gdb.threads/tls-core.exp
@@ -0,0 +1,60 @@
+# Copyright 2017 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+standard_testfile
+
+if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
+	 executable { debug }] != "" } {
+    return -1
+}
+
+
+clean_restart ${binfile}
+
+#
+# Set breakpoint at line 28.
+#
+gdb_breakpoint [gdb_get_line_number "BREAK"]
+gdb_test "run" "Starting program: .*"
+
+#
+# Generate corefile.
+#
+set corefile [standard_output_file gcore.test]
+set core_supported [gdb_gcore_cmd "$corefile" "save a corefile"]
+if {!$core_supported} {
+    return -1
+}
+
+gdb_exit
+
+#
+# Restart gdb and load generated corefile.
+#
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+set core_loaded [gdb_core_cmd "$corefile" "load generated corefile"]
+if { $core_loaded == -1 } {
+    # No use proceeding from here.
+    return
+}
+
+gdb_test "p/x foo" \
+                    "\\$\[0-9]+ = 0xdeadbeef" \
+                    "Printing thread-local storage variable."
+
+gdb_exit
-- 
2.7.4

  reply	other threads:[~2017-10-17 13:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 13:50 [PATCH 1/3] BFD: Write Linux core PRSTATUS note into MIPS " Djordje Todorovic
2017-10-17 13:50 ` Djordje Todorovic [this message]
2017-10-18 13:37   ` [PATCH 3/3] Add test for fetching TLS from " Maciej W. Rozycki
2017-10-24 11:17     ` Pedro Alves
2017-10-17 13:50 ` [PATCH 2/3] BFD: Extract PID from MIPS core dump file Djordje Todorovic
2017-10-18 13:36   ` Maciej W. Rozycki
2017-10-18 13:36 ` [PATCH 1/3] BFD: Write Linux core PRSTATUS note into MIPS core file Maciej W. Rozycki
2017-10-19 20:14 [PATCH 3/3] Add test for fetching TLS from " Simon Marchi
2017-10-23 23:43 ` Maciej W. Rozycki
2017-10-24  2:05   ` Simon Marchi
2017-10-25 14:15 [PATCH 1/3] BFD: Write Linux core PRSTATUS note into MIPS " Djordje Todorovic
2017-10-25 14:15 ` [PATCH 3/3] Add test for fetching TLS from " Djordje Todorovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508248194-26950-3-git-send-email-djordje.todorovic@rt-rk.com \
    --to=djordje.todorovic@rt-rk.com \
    --cc=asowda@cisco.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@imgtec.com \
    --cc=nemanja.popov@rt-rk.com \
    --cc=nikola.prica@rt-rk.com \
    --cc=petar.jovanovic@rt-rk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).