From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 5/5] Test breakpoint commands w/ "continue" + Ctrl-C
Date: Mon, 06 Nov 2017 23:27:00 -0000 [thread overview]
Message-ID: <1510010836-15287-6-git-send-email-palves@redhat.com> (raw)
In-Reply-To: <1510010836-15287-1-git-send-email-palves@redhat.com>
This adds the testcase that exposed the multiple problems with Ctrl-C
handling fixed by the previous patches, when run against both native
and gdbserver GNU/Linux.
gdb/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>
* gdb.base/bp-cmds-continue-ctrl-c.c: New file.
* gdb.base/bp-cmds-continue-ctrl-c.exp: New file.
---
gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.c | 35 ++++++
gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp | 136 +++++++++++++++++++++
2 files changed, 171 insertions(+)
create mode 100644 gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.c
create mode 100644 gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp
diff --git a/gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.c b/gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.c
new file mode 100644
index 0000000..2ec0b54
--- /dev/null
+++ b/gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.c
@@ -0,0 +1,35 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2017 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include <unistd.h>
+
+static void
+foo (void)
+{
+ usleep (100);
+}
+
+int
+main ()
+{
+ alarm (60);
+
+ while (1)
+ foo ();
+
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp b/gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp
new file mode 100644
index 0000000..e152459
--- /dev/null
+++ b/gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp
@@ -0,0 +1,136 @@
+# Copyright 2017 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Set a breakpoint with a "continue" command attached, let the
+# inferior hit the breakpoint continuously. Check that we can use ^C
+# to interrupt the command, and that if ^C is pressed while GDB has
+# the terminal (between the stop and the re-resume), the resulting
+# "Quit" doesn't mess up the debug session.
+
+if [target_info exists gdb,nosignals] {
+ verbose "Skipping because of nosignals."
+ continue
+}
+
+# This test requires sending ^C to interrupt the running target.
+if [target_info exists gdb,nointerrupts] {
+ verbose "Skipping because of nointerrupts."
+ return
+}
+
+standard_testfile
+
+if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
+ return -1
+}
+
+# See intro.
+
+proc do_test {} {
+ global srcfile binfile
+ global gdb_prompt
+
+ gdb_test "break foo" "Breakpoint .*" "set breakpoint"
+
+ gdb_test \
+ [multi_line_input \
+ {commands} \
+ { c} \
+ {end}] \
+ "" "commands"
+
+ set test "stop with control-c"
+
+ for {set iter 0} {$iter < 20} {incr iter} {
+
+ # Useful for debugging.
+ #send_user "iter: $iter\n"
+
+ # Consume one breakpoint hit (at least), to make sure that the
+ # continue actually continues between attempts, as opposed to
+ # "c" not actually resuming and then Ctrl-C managing to
+ # interrupt anyway.
+ if {[gdb_test_multiple "continue" "$test (continue)" {
+ -re "Continuing.*Breakpoint \[^\r\n\]*\r\n" {
+ }
+ }] != 0} {
+ return
+ }
+
+ set internal_pass "IPASS: $test (iter $iter)"
+
+ # Breakpoint commands run after the target is considered
+ # stopped, and thus run with GDB owning the terminal. That
+ # means that it is expected that a Ctrl-C that arrives between
+ # - GDB reporting the breakpoint hit, and,
+ # - the breakpoint command continuing the target
+ # results in a Quit.
+
+ after 200 {send_gdb "\003"}
+ if {[gdb_test_multiple "" "$test (unexpected)" {
+ -re "Program terminated with signal SIGALRM.*\r\n$gdb_prompt $" {
+ fail "$test (SIGALRM)"
+ return
+ }
+ -re "Program received signal SIGINT.*\r\n$gdb_prompt $" {
+ send_log "$internal_pass (SIGINT)\n"
+ }
+ -re "Quit\r\n$gdb_prompt $" {
+ send_log "$internal_pass (Quit)\n"
+ }
+ -re "Quit\r\n\r\nCommand aborted.\r\n$gdb_prompt $" {
+ send_log "$internal_pass (Command aborted)\n"
+ }
+ -re "Breakpoint \[^\r\n\]*$srcfile" {
+ exp_continue
+ }
+ }] != 0} {
+ break
+ }
+ }
+
+ gdb_assert {$iter == 20} "stop with control-c"
+}
+
+# With native debugging and "run" (with job control), if the inferior
+# is running, the Ctrl-C reaches the inferior directly, not GDB. With
+# native debugging and "attach", or with remote debugging, the Ctrl-C
+# reaches GDB first. So for completeness, try both "run" and
+# "attach".
+
+with_test_prefix "run" {
+ clean_restart $binfile
+
+ if {![runto_main]} {
+ return -1
+ }
+
+ do_test
+}
+
+with_test_prefix "attach" {
+ if {[can_spawn_for_attach]} {
+ clean_restart $binfile
+
+ set test_spawn_id [spawn_wait_for_attach $binfile]
+ set testpid [spawn_id_get_pid $test_spawn_id]
+
+ gdb_test "attach $testpid" "Attaching to.*process $testpid.*" "attach"
+
+ do_test
+
+ kill_wait_spawned_process $test_spawn_id
+ }
+}
--
2.5.5
next prev parent reply other threads:[~2017-11-06 23:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 23:27 [PATCH 0/5][Resend] Fix multiple Ctrl-C/Quit issues Pedro Alves
2017-11-06 23:27 ` [PATCH 3/5] Don't ever Quit out of resume Pedro Alves
2017-12-09 1:21 ` Maciej W. Rozycki
2017-12-11 11:20 ` Pedro Alves
2017-11-06 23:27 ` Pedro Alves [this message]
2017-11-06 23:27 ` [PATCH 2/5] Fix stdin ending up not registered after a Quit Pedro Alves
2017-11-06 23:27 ` [PATCH 4/5] Python unwinder sniffer: PyExc_KeyboardInterrupt -> Quit Pedro Alves
2017-11-06 23:27 ` [PATCH 1/5] Fix swallowed "Quit" when inserting breakpoints Pedro Alves
2017-11-16 18:47 ` [PATCH 0/5][Resend] Fix multiple Ctrl-C/Quit issues Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510010836-15287-6-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).