public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [pushed] Fix "make test-cp-name-parser"
@ 2017-11-08 15:36 Pedro Alves
  0 siblings, 0 replies; only message in thread
From: Pedro Alves @ 2017-11-08 15:36 UTC (permalink / raw)
  To: gdb-patches

src/gdb/cp-name-parser.y: In function ‘int main(int, char**)’:
src/gdb/cp-name-parser.y:2132:30: error: ISO C++ forbids converting a string constant to ‘char*’ [-Werror=write-strings]
   char *str2, *extra_chars = "", c;
                              ^

Simply don't initialize the variable, it's not necessary.

gdb/ChangeLog:
2017-11-08  Pedro Alves  <palves@redhat.com>

	* cp-name-parser.y (main): Don't initialize extra_chars.
---
 gdb/ChangeLog        | 4 ++++
 gdb/cp-name-parser.y | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 67f65c4..80dbb66 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-11-08  Pedro Alves  <palves@redhat.com>
+
+	* cp-name-parser.y (main): Don't initialize extra_chars.
+
 2017-11-07  Tom Tromey  <tom@tromey.com>
 
 	* event-top.h (command_handler): Constify.
diff --git a/gdb/cp-name-parser.y b/gdb/cp-name-parser.y
index d430ae7..33ecf13 100644
--- a/gdb/cp-name-parser.y
+++ b/gdb/cp-name-parser.y
@@ -2129,7 +2129,7 @@ internal_error (const char *file, int line, const char *fmt, ...)
 int
 main (int argc, char **argv)
 {
-  char *str2, *extra_chars = "", c;
+  char *str2, *extra_chars, c;
   char buf[65536];
   int arg;
   const char *errmsg;
-- 
2.5.5

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-11-08 15:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08 15:36 [pushed] Fix "make test-cp-name-parser" Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).