From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: [PATCH 11/11] Remove usage of find_inferior when calling kill_one_lwp_callback
Date: Fri, 17 Nov 2017 18:34:00 -0000 [thread overview]
Message-ID: <1510943613-18598-12-git-send-email-simon.marchi@ericsson.com> (raw)
In-Reply-To: <1510943613-18598-1-git-send-email-simon.marchi@ericsson.com>
Replace with for_each_thread.
gdb/gdbserver/ChangeLog:
* linux-low.c (kill_one_lwp_callback): Return void, take
argument directly, don't filter on pid.
(linux_kill): Use for_each_thread.
---
gdb/gdbserver/linux-low.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 33eb4f8..274263a 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -1356,17 +1356,13 @@ kill_wait_lwp (struct lwp_info *lwp)
perror_with_name ("kill_wait_lwp");
}
-/* Callback for `find_inferior'. Kills an lwp of a given process,
+/* Callback for `for_each_thread'. Kills an lwp of a given process,
except the leader. */
-static int
-kill_one_lwp_callback (thread_info *thread, void *args)
+static void
+kill_one_lwp_callback (thread_info *thread, int pid)
{
struct lwp_info *lwp = get_thread_lwp (thread);
- int pid = * (int *) args;
-
- if (thread->id.pid () != pid)
- return 0;
/* We avoid killing the first thread here, because of a Linux kernel (at
least 2.6.0-test7 through 2.6.8-rc4) bug; if we kill the parent before
@@ -1378,11 +1374,10 @@ kill_one_lwp_callback (thread_info *thread, void *args)
if (debug_threads)
debug_printf ("lkop: is last of process %s\n",
target_pid_to_str (thread->id));
- return 0;
+ return;
}
kill_wait_lwp (lwp);
- return 0;
}
static int
@@ -1399,7 +1394,10 @@ linux_kill (int pid)
first, as PTRACE_KILL will not work otherwise. */
stop_all_lwps (0, NULL);
- find_inferior (&all_threads, kill_one_lwp_callback , &pid);
+ for_each_thread (pid, [&] (thread_info *thread)
+ {
+ kill_one_lwp_callback (thread, pid);
+ });
/* See the comment in linux_kill_one_lwp. We did not kill the first
thread in the list, so do so now. */
--
2.7.4
next prev parent reply other threads:[~2017-11-17 18:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 18:33 [PATCH 00/11] Remove some usages of find_inferior Simon Marchi
2017-11-17 18:34 ` Simon Marchi [this message]
2017-11-17 18:34 ` [PATCH 10/11] Remove usages of find_thread when calling need_step_over_p Simon Marchi
2017-11-17 18:34 ` [PATCH 09/11] Remove usage of find_thread when calling resume_status_pending_p Simon Marchi
2017-11-17 18:34 ` [PATCH 01/11] Remove usage of find_inferior in win32-i386-low.c Simon Marchi
2017-11-17 18:34 ` [PATCH 02/11] Remove usage of find_inferior in win32-low.c Simon Marchi
2017-11-17 18:34 ` [PATCH 05/11] Remove usage of find_inferior in iterate_over_lwps Simon Marchi
2017-11-17 18:34 ` [PATCH 03/11] Remove usages of find_inferior in linux-arm-low.c Simon Marchi
2017-11-17 18:34 ` [PATCH 04/11] Remove usage of find_inferior in reset_lwp_ptrace_options_callback Simon Marchi
2017-11-17 18:34 ` [PATCH 08/11] Remove usage of find_inferior when calling linux_set_resume_request Simon Marchi
2017-11-17 18:34 ` [PATCH 07/11] Remove usage of find_inferior in linux_stabilize_threads Simon Marchi
2017-11-17 18:34 ` [PATCH 06/11] Remove usage of find_inferior in unsuspend_all_lwps Simon Marchi
2017-11-19 19:21 ` [PATCH 00/11] Remove some usages of find_inferior Sergio Durigan Junior
2017-11-20 3:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510943613-18598-12-git-send-email-simon.marchi@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).