From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19185 invoked by alias); 17 Nov 2017 18:34:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19156 invoked by uid 89); 17 Nov 2017 18:33:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Nov 2017 18:33:58 +0000 Received: from ESESSHC013.ericsson.se (Unknown_Domain [153.88.183.57]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id ED.41.07741.29B2F0A5; Fri, 17 Nov 2017 19:33:54 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.57) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 17 Nov 2017 19:33:54 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by DBXPR07MB317.eurprd07.prod.outlook.com (2a01:111:e400:941d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.2; Fri, 17 Nov 2017 18:33:52 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 02/11] Remove usage of find_inferior in win32-low.c Date: Fri, 17 Nov 2017 18:34:00 -0000 Message-ID: <1510943613-18598-3-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1510943613-18598-1-git-send-email-simon.marchi@ericsson.com> References: <1510943613-18598-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: BN6PR1101CA0001.namprd11.prod.outlook.com (2603:10b6:405:4a::11) To DBXPR07MB317.eurprd07.prod.outlook.com (2a01:111:e400:941d::11) X-MS-Office365-Filtering-Correlation-Id: 0c8581b4-bf03-4284-0b82-08d52de9c124 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:DBXPR07MB317; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;3:/g1iSbk0HyzADbVylJGAe37+SnWWmvPFu6EKhddAz+IU3BjtUlW82SWjJRBMCrCFGVTypxhds2FTcfQ0AlK0t1xRAjuhYZJgz6eaznr+I+hwVaP2hiHzCgaC7U63ozVEOmt1V7/V8xjTCCDNiZWaWKEW4NxsFUBlN3nQLjDp0hntXhghCqjiOcH/v3lmpP8B/AZuj802ufFYteWi7BSW8ge5Pz6EbEzJSnZZ3YE3y2LzH23h8wuMjBvjjMT6+q3X;25:yS6IYfxsV2vP9f/IxNRGoSKFkEOkvnvPBzyK5uRcyTm7ZT7K/MwucxCRkbfipuUq2YRpxupQLRVZZLCOYCI9g3DBOLzepHeW0LkvrQxmorYwZ/hqwkt0K6uy6ij9OOVTZhRXsYsPZz5AlUGq6c8q+tGDJgdTELuz8oOJ4XwSSOITjffOxBL/yP+2MRtP3BKhvMi89q5pCdAUbcnvkzNnFpyvm39lJJXfj+eBb+q8dEwmpagvSk7DmqjalWu4jIN2vUBN3aEMOL8m7LdM+3JU/fSWVNlVkTu6NTFz3DAqwYDcK+12wU3gGw8mAi1LtoVAeHx+am2EOEE5bXqPp+kHSA==;31:nwfJNsl3ZTKI0G/1EmSdxhd1WUgwwrHfVak11jILZdTK3O/lgJfLsKK0VIQlydRzkuhF/3JJHNoR3uSiYAeF6UkD2Y09TAifIy2cWDahaggetL9iKVK/izDGIUh5m3374I3SHF6ppmMB9O3bB4/wfdFDxt0lLbmWH/oAcWNjtOGre0zb72U4x490iqizMLlP+MBAaWbrd/pnDpLAFNWXIqCxphKtwAP3n3vz0L1HiaU= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBXPR07MB317: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;20:HWyePd7osHBd3To1adYF2Ic5U+f3q/hWmr/0KKpv1wQ2p5wEoIJ0wlilnPFGqfOoEWCTATgXik2m/RqKL5lCsG6UDMmuijGm9ORPspKnlvjH2sxyJZZO+EJjok0/xfit1lak3o+9De7v2mrzf2bjLCp0nePDlqEzFMXWX5OI9fgkW9G3WXCzHv76e4A07li9H/9/f1u0O6MVeJX/eY2AHfmJST1JBXAtWfzu4qdTGSF07XmEFxMepQt48LOuNnM7V1Aijv3qsijELiu+9sdxeAGjXM/WEETxtpi1Oot/qeYX+s7vZFI9pK80BjjhNUKIR2ZQwFTAP/h1vMs3GYa6ZL1W012wzt67wCelb/j02dXJEx67nBCycZFOwEcCZyEUhtB4jgKqA9Z7A2NQ+QMLTWDsw4afuUeMadRd/oV/3WaS2UgzGv60k6DCCQC6Bp6DnLYwBoIn9D6a/IxMKqL6Sg8PbPdj+sGemZfNGFpuY786YdSEG65uyxIeCwBWSWCw;4:hLJ4JsuYNytDBymz2JcrsEg6XOufRFtk9pYGAZjY7ZVsYXF0wA/T/QOS/8WtwuQ/Hhf+HraAnzCy/QggStIfs8TtH9jH+tlKVNvyXw48Yp9QKB+SQs3Ujh4TR3ip/Q0XgrlOr8kOXAMFXkqUbvd7r0XUX8wGdl10+lPAjI4a/ig5isQ/+HesFGaxjQDDtTw4SX+qFaDv58dlECsgEmzajQKvPS1hHUGyEznCzv4SH9RI+0t5Qx98JcNL89ZAgMJSNiWSDJFjDSVEeDDFEFaY/i3NPPw6MT4NOZaQGzIeG34AUcEzIUszLzjsLtiBr18H X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231022)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB317;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB317; X-Forefront-PRVS: 049486C505 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(39860400002)(376002)(54534003)(199003)(189002)(86362001)(16526018)(2950100002)(81166006)(6916009)(81156014)(2906002)(33646002)(316002)(106356001)(47776003)(8936002)(6486002)(8676002)(97736004)(6666003)(4326008)(16586007)(6506006)(107886003)(53936002)(478600001)(189998001)(6116002)(3846002)(68736007)(50986999)(76176999)(36756003)(105586002)(5890100001)(5660300001)(101416001)(48376002)(2361001)(50226002)(66066001)(6512007)(7736002)(50466002)(2351001)(5003940100001)(25786009)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB317;H:elxacz23q12.ca.am.ericsson.se;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DBXPR07MB317;23:TE4hnUsoRf6pdQyFFXu6yxz3Lvbs+Mi+YWSdUYAcEa?= =?us-ascii?Q?f3nb7xvcE6TwlwkV7kOemOUrgKOmvDuuY0P1Qj9wj5jnuBOHWBN6jWrFrbvB?= =?us-ascii?Q?lU0N9x0/zb/dF2EfFQQIv9YxPh0oAzBZ7x654k5EezWJSTD1J11nkv+E/Y6a?= =?us-ascii?Q?W9oYQilVKoQZLUDXuSNPSnmxwP/1wijvyv08FPzRiPsqK3QGzQDPH18nEMYw?= =?us-ascii?Q?rAaUHcQMWP7FpsQufOlwYPJJ9afse9Jwp00Uda4hA17sPNpF4i2nlDR5IEd+?= =?us-ascii?Q?Y/g5Lxn7BJzgyZ0KKhR2kJ0A9hegWyBwg3NglVFrHGm6hAt9w6OlXdOofTnw?= =?us-ascii?Q?u2X3d8Ovu1cUiQKEbyAA4rIvzSIeb9+KF3dpaGEGsiH0wC4zmxWoXHmsDVXz?= =?us-ascii?Q?lxcHLvPRIzUx2ZsXYl8wL5mpx31L4+B050s/CRanhwDx+SXxTanux1Fs++Jd?= =?us-ascii?Q?RZbiiG1c5BejgnicQ80gohLel0vtCTdHjzAePK4podau8A0ZkLYr6/JCm42M?= =?us-ascii?Q?s9qeU46BVLph8X1I7qmiSKJ/n3Gd/YphU25hXobkaGHuKM0cs5dEeluGvveG?= =?us-ascii?Q?gX50PTglWlT90gyhkip4lV6q0vtWZkM1Y+Rd9YESlXwTHU2lBgc8JpDPQIam?= =?us-ascii?Q?JgP3PF4y6Dc0lNzAv76u6P7rxdzK391HnQIckGbF3RSfvCP53mkc7EveQITS?= =?us-ascii?Q?I4faFSlPT1RVjQmQ7yCRHPKOlUPM1u/psjKLtH1VzAM3VRRZ2mGr3ezuoZp3?= =?us-ascii?Q?qsZKUcS9JR/wJf4kgliaGtQeC3bAmLwXh0ZIK8jmpRjQ5uAOtAmR8Xj8IeI9?= =?us-ascii?Q?i7ztpGdNkg3F37SyKJsimIt8we1Nyl+FgXJ1dY5Bsy4axTDuOW8hfxjH5pri?= =?us-ascii?Q?0LTCNthgyJWWvfPOXvI4MCEGFPWGdU0N8JjLZWhZrWKsQA91GpZ22aIVP9Rv?= =?us-ascii?Q?MFf3JyrGQWG/+BDqT1skw1AiP0UBR15rIOQbg2Wi/GILFUjDH7mVe8+gqI+Z?= =?us-ascii?Q?QvNPKJ9vqiucrty/OAdrr/oEaIqMX1BZjNCRDpj0ynBNaGAcxWO4gFCcTm8a?= =?us-ascii?Q?GgLKXfPsjULw+uFEalcB14Xd+uAmw8gnPcrXJfViszdeYr+SSyklJ/nkuSA6?= =?us-ascii?Q?h8PRcFt4HAlJsd4T1yLQyTTa2ySifCJ5s/7qxtWWLNkIcBzlPVu7dmHypuQP?= =?us-ascii?Q?XuzZ4Yx5h0P1KMAfDmRjtH6wmagnhKmDtV?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;6:eJaMYiXGyAVZeDvaVdDAbuzKW5vjTS7u+ilUc3rnK8OouZzX3FR+lgziLOfMwjTqxfRV4PWnMgpVTjp3+i7MS63R/H1jn60VhX+8xAFccMPDTSktQRW4fOab7FjqxC+2CDfC4jq3wcdd/pOIorbdOTb5FWeOtC0XjGFmfQVuSSpvkS4fZ1H2nb04V1s6nej6H0SwI6wV/7CMKSSLxBx3lhlbUrWm9mqvBIbvw+wZqY+ZJaBETkKMNlnfx8LTWPmiVNDjxIam+gaGBYZ0ZnH6nkg1IvsHe5XQvRGDKOHnOg7gJ99oSI39qrhcvqm6Y9l6YC44oTMc7sNf84U/VbcP7w7M9J7qkPhf0g9GmryMO1M=;5:YY//Qr0f/choK/NgCaPVii6gNjN4evBs9wF6WDUBJhkmrbF+dzKjVpLYfPBai4dR9k5FF8oZVpISHLx1lDRudFhkm/GBMC4FPbYeEPFt31f1rdfW+Yj+NWkzYyT7v0O+nNRS/pIrJM1e8B0n8KaHDLL2WMZ+Ak/PWWnID/2oWAk=;24:L0b+sA0K2ve72q28sX9Hem0/9I37h8SyUb5bupRt0IKYUxlFOjyhovq8Wqoq4kRry48W8GegN5iYRYr0Vmupw1vscWT3nXy/tAwdipMWT4s=;7:a0w2qPZ9eAl/m5tKGQLWRjtiB1iJtrbrfLrDMCdvlbKIinkBMhlcTAR/HUhRhKg2AjmliqnSNGOrUkRHglm+jjQAo7Vl2BmZqWdSZX5D0ikbPJBFFfZGW2p73vhTKEB7Fp0spHBWngrDSd9Nv2a4h2qE0uDLGBI8IB6SOoK/55ZitTyPgPfGpZLpEdCi1B6n4jzhY8aBvPSqEq8xtZyJW/dFFRm1t/JGr84i6nkUl6a0FnL3iBq9UG6QeJcl7zqR SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2017 18:33:52.9100 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c8581b4-bf03-4284-0b82-08d52de9c124 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB317 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00356.txt.bz2 Replace with for_each_thread. gdb/gdbserver/ChangeLog: * win32-low.c (continue_one_thread): Return void, take argument directly. (child_continue): Use for_each_thread. --- gdb/gdbserver/win32-low.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/gdbserver/win32-low.c b/gdb/gdbserver/win32-low.c index 66fc52c..c7684b7 100644 --- a/gdb/gdbserver/win32-low.c +++ b/gdb/gdbserver/win32-low.c @@ -428,10 +428,9 @@ do_initial_child_stuff (HANDLE proch, DWORD pid, int attached) /* Resume all artificially suspended threads if we are continuing execution. */ -static int -continue_one_thread (thread_info *thread, void *id_ptr) +static void +continue_one_thread (thread_info *thread, int thread_id) { - int thread_id = * (int *) id_ptr; win32_thread_info *th = (win32_thread_info *) thread_target_data (thread); if (thread_id == -1 || thread_id == th->tid) @@ -455,8 +454,6 @@ continue_one_thread (thread_info *thread, void *id_ptr) th->suspended = 0; } } - - return 0; } static BOOL @@ -464,7 +461,10 @@ child_continue (DWORD continue_status, int thread_id) { /* The inferior will only continue after the ContinueDebugEvent call. */ - find_inferior (&all_threads, continue_one_thread, &thread_id); + for_each_thread ([&] (thread_info *thread) + { + continue_one_thread (thread, thread_id); + }); faked_breakpoint = 0; if (!ContinueDebugEvent (current_event.dwProcessId, -- 2.7.4