From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19802 invoked by alias); 17 Nov 2017 18:34:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19750 invoked by uid 89); 17 Nov 2017 18:34:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Nov 2017 18:34:03 +0000 Received: from ESESSHC021.ericsson.se (Unknown_Domain [153.88.183.81]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id FE.41.07741.69B2F0A5; Fri, 17 Nov 2017 19:33:58 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.81) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 17 Nov 2017 19:33:57 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by DBXPR07MB317.eurprd07.prod.outlook.com (2a01:111:e400:941d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.2; Fri, 17 Nov 2017 18:33:56 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 06/11] Remove usage of find_inferior in unsuspend_all_lwps Date: Fri, 17 Nov 2017 18:34:00 -0000 Message-ID: <1510943613-18598-7-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1510943613-18598-1-git-send-email-simon.marchi@ericsson.com> References: <1510943613-18598-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: BN6PR1101CA0001.namprd11.prod.outlook.com (2603:10b6:405:4a::11) To DBXPR07MB317.eurprd07.prod.outlook.com (2a01:111:e400:941d::11) X-MS-Office365-Filtering-Correlation-Id: 86abb5f9-5151-498b-5632-08d52de9c316 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:DBXPR07MB317; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;3:AFnyGNer3lcAq34kO0tWcB9REjZQ0yurDVagq3wqXHJ8F3olIQs8GVsYDmc8HyeFbxJR7SP0ygj3wieBI79HVxOZbCn7b1IgtAzrf5GMglQmCoZ/PjVQ1gqwyQQ9GYbDeY57PBeR3ZSpF5ONEK9LCASGRFLCWvzr2sepqaTtBusmA2u7tVXFO7ZUTgw/V01gbV1qirKpSt8TZppVXd68oyyWAijOnKwYZlSr+oUr60cul+qfDr9GrPjogwhzrKCm;25:U7hdsxMYUToGXlPESUcEWk05xNuYSpOjzoSp/P8NC38EAgq+KrfMJxtYhOBwVUoEy2x6Ns2gD1TbMYhAaONOXc2VgND+8d3didLjTEvh8GEYtjhxYmBLaQW2dqnatfPQVAjqoRm65uabOh+dWu1GFNbB+uDsTWA9tewk53W8CZlgtRJNB1VHRtATQsFq5OyW6qLhSuRjcLWNE9O/8OpyOy1i+73xZecQG/uq3+CpV6aRlPqEmLjQGIcIA7xi3AvtriazL7yCPRJjVNwKJOsE2TOwYrBGF9qxgWq+2KB0vE1zUB50FOxmrwrp7l280TTtSgkCN/rnqnLd32zJUDrr6A==;31:mDAR2H6+OFUk6C58O4TjGT+3Ooh6kVPw4uBcA23Y3LurjBi12v2WjrWNXlPu7+itMi4g8UCa2FYg+tSWcPsSv067d9D2iRpj7Vdzz18onVEJWu2UKbxA/48miaRVn2stF6rDyM0szhycG5XykEiEvSPRrNt/Fnxc3oFQqw5vts4xvsNd+kH8G5TeLfbk1ISD6R8y/puewbLUl0wO54DLlnfyjc1HiJzwTPVZUG8F4c4= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBXPR07MB317: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;20:m9BlKTx1W0JIIO6azdpMZO9eXkbYgeCSezIaY5x8QWBKCB1IHqcc63PVUm7oh4byK4hkWFXOkB23au8GrcY2xdg40BU/CQgmJ27B60FU50SvAUdYfBUD8QOLGGOq/gROjmCEzO1g5bV11rkzKxryLmrePO/j00mSko+IA72VXDnm/2N0mDtooyOSyhTrehObk+8NPPYL5qX1928L0X1yiKrrjbLCnXNPgGar25WlrGF4VINXxKe6mJJ/wXm9alnRJtoMPbJWaLaOFrDLJ83hFmpe3nmihKI166mvamBCWD7PKvrgDbjW7pwwMPW4GeHyDhVNna/q2os4W8hIyHc95csrRPk0GotKCVp0ScFdw47CTiMeXW5EIVMg8566pq9KbyUi6UiW72tTH3FK5ZiPfipKIouCCMGZIY4eer6B0FjgguPWUpU+cSdvaNtvH/Kxjl31TheefyfmCrDj7WCj3aNpSTpw2D1hllO4OTDfKZaszefABHly52dgoAh/tMAJ;4:gCyGzySXBkB4jtH4u3RXK53Y3NO6QvaHNo2UVNAp6qNB/DAn1b4lNpcYvbiL54DxOGOZKV0PidnpIl9uKBWTtwURNqa2NBQmJ5BvHo9/ug0d6RYxPdWx5yXvuA5GHBC/m73V0tX5OIIGQNkfyDukM64y9gnZlrpJiGy7JHMa0cAyeHmGf5SC7waXzbp8xySRoUqeV5QXIdiCIizz0k9bAh3IAI+9O5VYIWoy67c3xIaFPQpTUrTrFuXKaidZMweTbu+UkANLLNxK2AjKQwHTFf0VtVZflXEXqFfoIch+dF+YJbYUwCNdAVGAzmpDvJf9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231022)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB317;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB317; X-Forefront-PRVS: 049486C505 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(39860400002)(376002)(54534003)(199003)(189002)(86362001)(16526018)(2950100002)(81166006)(6916009)(81156014)(2906002)(33646002)(316002)(106356001)(47776003)(8936002)(6486002)(8676002)(97736004)(6666003)(4326008)(16586007)(6506006)(107886003)(53936002)(478600001)(189998001)(6116002)(3846002)(68736007)(50986999)(76176999)(36756003)(105586002)(5660300001)(101416001)(48376002)(2361001)(50226002)(66066001)(6512007)(7736002)(50466002)(2351001)(5003940100001)(25786009)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB317;H:elxacz23q12.ca.am.ericsson.se;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DBXPR07MB317;23:MYyTtSkWVRCmJACFIGf1+f0XUK/B35KwP8vwK8CO8d?= =?us-ascii?Q?EoePoQ/6PCG6O4oBUdLzVivNrGdeTrGvme8fNVQanHTWBD6Jgn0LKFLpI2I2?= =?us-ascii?Q?aoe7IcJ0JoqYJFRSgmdC/p4ag2hE4//QFGVU69tQUHZ647jTGWyzM7OFo1zd?= =?us-ascii?Q?7x5hMIpLjfUOW7sQfxYFDZqzxIV7hTM87Wnt+oezphmAg0yVmTMPrJUEH86N?= =?us-ascii?Q?y4BlSwBpl4lKF1qzPJrpJUsV5CYsQILqnM6DtWijpLAInYh1VMOT7cIn31iH?= =?us-ascii?Q?5MMK/0oZEFBRltkXCxzgsd5BVXCZ4t4mDJ4AFGvMdVXSemweOPiXv/iRVDxv?= =?us-ascii?Q?ctF4s2xwCZMJKbbFFCX66Yq4ifkfmUaTgAVB3wOZBq6FWT4mazJeo9KgqU5G?= =?us-ascii?Q?Di2m/d8HUpT5Ahtc7EcvVe5slo066fx4Au1NyTfhDUicjMoRw6JZPvKl1qz5?= =?us-ascii?Q?elmYuJqmCxWjtrYGWPYUgwSlEZmvcfIUWmAjGFe8m5gwGbrojwruU90NV6wS?= =?us-ascii?Q?oz0diwgdB6Qsa+I07GkEl8TuYdHKP+xuUe/TTDh08w/2mIESCyXoeBgMxy13?= =?us-ascii?Q?IHCbUBeanEBixDauX6GW0co4QopMZ1AbmeDsjBkcDannXv60gc1dYVUPNXFc?= =?us-ascii?Q?IpJobX/Af4PHege6+O4quGZmESjMRytII31NKOjQ2hVUDAZckNXDNSwVr+et?= =?us-ascii?Q?kbLAsLMrfadpLjPWyb+zNV3NNIQ0bbCyaJRpuV9RbxvFdgfsDJzNqbTpT6hB?= =?us-ascii?Q?B0g73yIG4D3SU6WReb3Dxczm/gqgkfJFwQ9xr7XdRfwyUqivLJDxn4pxs6gV?= =?us-ascii?Q?VJuTSH1pPTbesMXV89NXYxKCGI4oyAR44VKZDlI62aIxqcsBvJVxtF6PItw0?= =?us-ascii?Q?LTTnnox12svrMYLnZuBu/V5u5pi4E4YpPU6G+vQAU0Mz/iB2hyUIo4JJ5kcB?= =?us-ascii?Q?KbZtEgK6yOC5fgcn0svXS7Qd0hoS0xr3ltr7NbAzqTUt6joCIObavcSBPSXb?= =?us-ascii?Q?/ZGdbiOe0yKF9DQrlyr1ykhI8N1PxuVu9dr2JN6eIVUQC01QqBIIsbHxl1X3?= =?us-ascii?Q?q9UYD/Kvzmv/mNhfUoaA64CTb/R3bIweYXZd034aMRa7A0gSFRrO29QUEWHN?= =?us-ascii?Q?KMp15IomEBrrYAqlfJW97t1Kuvlkh7loUEPedKjejdacMztFGClw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB317;6:KIMXX/BvUrMxVRswUYFfvZ9mAzXwMSqDNK2+0hlPA56nAZP0l4hGLgLsfk5JcIAl9o/hZmt4NugKW92g0VKO98eoqFgSYK392IGTieXQ30uZ7S7NwXh10IFw0EzpxBdb/+niBFcJ9h35O72WHE7uWyDvBZnEJl4Aax/DzicQszsvB0J4j8rYW7b6OaxeqLe0qWsuFiAy466m3I+xa8FF5SCa+/6fZOsciVw8mFBB8bE8Bo409TDgjIC0BuoejK56BwC30T3Damr1lVOBBHdC7Ccv744KxJ+Gter9uNJXifzSNNiaFtv4BDD2ciEKOD2Th8D0Xg5yHOfQzxviBMFc3tASLw3mYUsa8xr37+Uae/A=;5:+5yBG9341URj5pSkMwYluKGi7W/0c2frY29R44v56eHuToZP/pTjG3f9dYSZXxVmsAiMhDw6k8xC1GRF2WYv7Z9DF2TV0jJz7Sv+rnycbY5vU+mikrk5KsgJvs0yS7UipQva9EciCSTUM6VOzarg2a7VrUJhkElxzkhdPj3m+5I=;24:0qdeAylkZLPnCzHwXqFB1PTHRZ9NVu7FzNoWTZPVyJFzS9uy2zBg4H09YWGECH/Znb92LWNkx88jg8WVKZ8cq/Z3ua7oGbN2t7nwh9aiRFA=;7:2uZsqTzt3o3TvoaZIIdwHBPL5REBfXeQBKj5zoK6AmWaGtB0tSWYQjttgVHS1k+A675/6T5D7zLfPU2aG4xcZxZJOYwS1TjJLKooNQf7ntmUpbc/w7m1RZawxQ9R8ceS6j4Vu0czmCblLAR+QH5IYPoGAXqDhUAiCjKk0VHmDiVO3DKAG62m8zPbJ3eWKpJ47303eRorX/FoJ9N8nYUJgkzcspDDfhWRcV6G7x28o5nNl7RnaYXgKFxHyHV54nro SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2017 18:33:56.1912 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86abb5f9-5151-498b-5632-08d52de9c316 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB317 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00360.txt.bz2 Replace with for_each_thread. I inlined unsuspend_one_lwp in unsuspend_all_lwps, since it is very simple. gdb/gdbserver/ChangeLog: * linux-low.c (unsuspend_one_lwp): Remove. (unsuspend_all_lwps): Use for_each_thread, inline code from unsuspend_one_lwp. --- gdb/gdbserver/linux-low.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index fd8e45e..fce3fd0 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -2969,28 +2969,19 @@ select_event_lwp (struct lwp_info **orig_lp) } } -/* Decrement the suspend count of an LWP. */ - -static int -unsuspend_one_lwp (thread_info *thread, void *except) -{ - struct lwp_info *lwp = get_thread_lwp (thread); - - /* Ignore EXCEPT. */ - if (lwp == except) - return 0; - - lwp_suspended_decr (lwp); - return 0; -} - /* Decrement the suspend count of all LWPs, except EXCEPT, if non NULL. */ static void unsuspend_all_lwps (struct lwp_info *except) { - find_inferior (&all_threads, unsuspend_one_lwp, except); + for_each_thread ([&] (thread_info *thread) + { + lwp_info *lwp = get_thread_lwp (thread); + + if (lwp != except) + lwp_suspended_decr (lwp); + }); } static void move_out_of_jump_pad_callback (thread_info *thread); -- 2.7.4