From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101547 invoked by alias); 20 Nov 2017 16:35:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101497 invoked by uid 89); 20 Nov 2017 16:35:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1344, mourn X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Nov 2017 16:35:08 +0000 Received: from ESESSHC009.ericsson.se (Unknown_Domain [153.88.183.45]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 1B.F1.07741.A34031A5; Mon, 20 Nov 2017 17:35:06 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.45) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 20 Nov 2017 17:35:05 +0100 Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.2; Mon, 20 Nov 2017 16:35:04 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 02/19] Remove usage of find_inferior in lynx_mourn Date: Mon, 20 Nov 2017 16:35:00 -0000 Message-ID: <1511195683-2055-3-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1511195683-2055-1-git-send-email-simon.marchi@ericsson.com> References: <1511195683-2055-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: CY4PR03CA0075.namprd03.prod.outlook.com (2603:10b6:910:4d::16) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e005759-5e35-46c4-ad18-08d53034a773 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;3:lkvOsrwOnysxYuDmc1Otbpyzxoq0Mc+MpTVky2rsScZWzQHieveUyMK18fWJicjtIWyVzhA+BZp+/C9mz++tmaBCa0xROna0Xp3FtDJ6snDWxzGMMh5r80kXh9T3tN8c3bjmomZfnx54HAgHN1+HwJn4aRTs1In02jynCcikhr0NF4ZnAOYaecTxcjUICWxDLgaoq4t75yicXRFLBUrZVFVOTu37Ygm4bcEL7t437Eq9PMKorUVfbi6sCEHWnHcK;25:0RKxrxElYe0/j2j1MsUPZHknDNrbpaTxUmpW3EpGGjiIVeZ87/UTjeaaDJ0Yrro4FXESJxRkACVU34F58YG9QS7Ry16FG7jihbSxp0FyQzxsc7DF5+2McLtm72mYvYKHLvgaZD1U8uN3FzlZVgOCuhVKoxlMP+fOfz+B24MBFwSIweo2N2oo2YlNQ/5l9+p3WniPy+WyVRkPOlMBiaLf4QMa9NWuBJ55++9NfATnTNX7h2XKQehhYCNdtJStgRAV9B4p2EMKh93G/vDeyiUJ/EcjKzEJLJ7qEumi/FupGiHL7SVRkZ3SgUbhw0Lq1DlJE/5GX5CJ5rB2kkVPVgxfbsQdCjJhuykuUgJGhMvi/wQ=;31:ZYsGEbKudoXf+FJSXUut77jBlD+Y0VvnwY7wtsW6NWJ8ZHHGT4QVCSDg7YWtUkAimIAt3HQmkVfClD/vGfgWaC5v39WzuYAX2inNygPDqaCsiZJn99wJL1AUw6Io6/+1Mk+8GJvUy+akHkNJvrTb+/CTRoY8ZglucTpKuLJmLU9H9uXIYccTPf7P1PR7oTPn7/KtnjY18cC7daBihfkGWoucrr5ROxi5T41ikkfVcJw= X-MS-TrafficTypeDiagnostic: AMSPR07MB310: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;20:rOmtfeeVejq0ioOEGqnfb4iuoFHLQ5DZePKLCxNBUtHLpj7i3ZgXMMW1j3p9jlzk6fTaCIW5YjfRTc8+6BpO6eO17NBaYrB3WyoiIIQ6k9GUYrfuggluJRoGO31Xw1bepa172JLV80GOs4gMMuOswPyzT+OpNhpvOpXajSfG7J59Tch9cltRAT1rbnBDrO+/pzzNvcZxTzxwUQjqUf8M2kZt0Eq0HT8LoGGl0kM7hQrgkiWAP/Vo346COpOH6MVzGkfivPvKc37D94fZAKVbDKthcqLceu5zaY6YDhUIfiCfpMzz6nKhkt5HYxmGyaEQk3Hj/WujG9qY/vIB0Rxiy/T0d21QeLPAkJ6IXOS/nlUS9FtzxLCjo8L12PZz2rg+T7CpyT4y2q5YAvpjAedSsfFMk9ZSATNHG35cg43EyaOfdRNsE3vqYczAAlSFHZAMgFrNq6SePMzStHjcArGO4fftqINS6dtE+u8XH6Cff6CjiW2C+EBT0Pl/uF09j/4T;4:DP9d3JdYzNZVWti2Yjq80V2dg+Vb7F6zm+qEl8eRedWYHzmBUZy5xLF6ViL+PlvaDr4PzRMA+qpW5XO9dsk/OqDUmcrVqCT8fIjLpbNpKSekD29ZZqE5HYhgIkjWmBjlTi/9rgT3R0ty7Hh3VK4ODBI/D5CeiHLd8c1KF1gkxdGA/F6j2mGeqf7aMiX+v5Ns5dlNyJDoTnYMcKHtofhRqzeEKVA3m2p66bU3MnRR3CjoSX6TW2btXafMrgxSTYg+tEEvqi4aS/EZCMcyxEgjtKdBlk9Njp9MdjpTSbB4yz7q8ZkLv8BqqZz9X6DywlU6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(3231022)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB310;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB310; X-Forefront-PRVS: 04976078F0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(39860400002)(199003)(189002)(54534003)(3846002)(97736004)(66066001)(5003940100001)(33646002)(16526018)(50986999)(76176999)(6666003)(81156014)(305945005)(7736002)(81166006)(6512007)(5660300001)(316002)(6506006)(6486002)(16586007)(6916009)(2950100002)(101416001)(8676002)(2351001)(2906002)(105586002)(36756003)(47776003)(86362001)(50466002)(48376002)(50226002)(8936002)(106356001)(68736007)(2361001)(53936002)(478600001)(25786009)(6116002)(4326008)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB310;H:elxacz23q12.ca.am.ericsson.se;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AMSPR07MB310;23:AfQgwOrTC+hQZ7edU2+iRMcZLDD+TOzUaMC9Nr3B2h?= =?us-ascii?Q?G4YOmmpicRR8GJ09+NgsRlOPtZyLTSPsFkj881QRMf+UrjUs+uJMMKlRVGvF?= =?us-ascii?Q?zicYE8NO+cYPIf8iAYFIj7F5refQ1Bp/3+lU+r/cOoyXDcKKE7b1UrrtAhbv?= =?us-ascii?Q?2udt2qwDGrubCnT0tJbROFChv48rQDgm3FS+DEnOI594rRFdaFe0nZyHLbnk?= =?us-ascii?Q?aUjJ9CD/gFegAeMwJvI1RJvpQGOAKv4hsX9nx3575m/4TekygePxzXjlEAHY?= =?us-ascii?Q?lMwKB02O3eGm2bdvofiDyy2KyF3zzWvuiDi/jiY77kzbf2DlbbEiBnKPoll5?= =?us-ascii?Q?5S90Urm/bsEcf9c+7JlntRJ4jFmf7GCXAQ7MgznNo7vp3wMmlbb54zdV/Fyo?= =?us-ascii?Q?OlpiHtRtFuEOGJENLJznCz0jT9I7nks1sCzQisww54L3P/RAsxhdXx3spvxL?= =?us-ascii?Q?flhjUqEtNt4wuC4a1k7TcJev8/czve37XvqeM0n1oRXXOQm4pTICc/2phRRG?= =?us-ascii?Q?leMX4ya+l+wyFJ5NPTlOb7C3vlfqc8IA+lB18TVtC0CSudb6xqjfHgiqnPRL?= =?us-ascii?Q?50TD/xoTUZU5+op66VHNL1Eo25Xtb7DlX2n8JcZEllHPC6yJ6NfPCe+uvX8m?= =?us-ascii?Q?nf1F//8BMOM20pAqMQvbcYC/AJjBZ5ZXwSJVymFU7t6XqG8+DJbbrP/x2Zah?= =?us-ascii?Q?MWJAhTVg7Xt2MZhNAhaMR9RBE0uEH/GGeNoG0vYeXHg5Xllpn5oqjbSE/DTi?= =?us-ascii?Q?FTX9W2GvSyflruZE+sP58/oeBAV+QpcN8ltswWixdAD/sKv7BzTIB2tFCuJe?= =?us-ascii?Q?0xBaSIFECSMlUMOEFcwYYpskD1UnEW9JY0CT3IQf1RPOq6nmxjxfO3lPoDK6?= =?us-ascii?Q?bcmg8kLUsmmb9au5GTdNCaDtPZFRVmaPRFm6Gtq85A6GxAJnjcYSlcGchqrb?= =?us-ascii?Q?gxdo+reE7esTIK5JOsWBiEZpFDsI817JLeEkE2t4AwRElzawm3USGSBaKko0?= =?us-ascii?Q?HI0f4Y/A4YbQXcmUOW7uZfd4okZl1ww3bledsSVtM6LBKDXlelNvw4PXDgh2?= =?us-ascii?Q?kvAD83+v+xmVBlXRc1uPka1ocp3y0q9ea+q6fcSAYAhocB5zSl3uQolIgUoE?= =?us-ascii?Q?ESZCCagk9nBOahWK/mEfB80apRPwTp?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;6:L/AbznVlXZGWYLh6PKgb5kGcBJizbe4U7yohBHQOsa2eEPbbQJiMEaxe1H2SsbkiPAdQbIwNXRf7ogWQ+/ZhIx52j5KG1DItgoP/Zbzwy3BhsGGTuOgYfewGdKckp/HJU66b/caY6CCCAGviVBTkxutcaL26AsyerLxSybPLxrJJeYL9ZpX2iVY4htUHJro8ZSu2n5eiqG/F7Ljo1I44qm8tNr3nmI7zfD2DTswAZpKOtukHfA6wOhcPsnvN0q5gAcA1gVpi7pLZ0DFQZziTHYbrMvx85/AX+ocpQIjJhe1KbStA4fSHZdNS02XUmvNe9Rlxi/HtVeJzLjvkVlonxJ7UFXqxrkfv8d0via0Bs68=;5:9ma2rj0KJRoD8Bas5mdun7R89ht6hrUYhFDssnjrD3l0ERjAbJSqra4354He9uPwf/rNq2vHn9cH7pkK2rD7HIwPYMLdQsqpeQa0w+AT4MnkI/TmzpWV3TIE4LYT0T2xoQuP3IUNPSoDn0lPehliA1Lzz3Hz3caskkqtss56QP4=;24:tg/solqIeaYRHt3nhsoUfytxW2lq6lwMOzyHJur1sWFB9wPZvtpuKoD6B8OhbztLGwlyYDufHEcycwrYUmTlk6R+j1C17mNkTHUsuvW96iw=;7:6AyDbZ0SmZe+BQ4VpsIxyDfx8rY5yrlrum/hA9cocZrB/2NGVJG1jXClImSf3rK/peMcl5kk8C96w5IFy2etc/Ij7rIYGLDNwPom/OXWvWPCMv/cbEskAapLgCognuQEN3FFFtOELBYd6oJb8s0MU2n7f9kj5y/FNKFiQiyed/K5AYb/BVxVdQOvgaLJZdVHRX4Tx/10D+IpbXz11CGDAAwvGaIp3l9+TZdqnTAnHsbj6/LytZwRQWdwE2rS435q SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2017 16:35:04.0633 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e005759-5e35-46c4-ad18-08d53034a773 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00399.txt.bz2 From: Simon Marchi Replace it with for_each_thread with pid filtering. We can remove lynx_delete_thread_callback and pass remove_thread directly. I can't build/test this change, but it should be obvious enough. gdb/gdbserver/ChangeLog: * lynx.low (lynx_delete_thread_callback): Remove. (lynx_mourn): Use for_each_thread. --- gdb/gdbserver/lynx-low.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/gdb/gdbserver/lynx-low.c b/gdb/gdbserver/lynx-low.c index ca9adc4..6039364 100644 --- a/gdb/gdbserver/lynx-low.c +++ b/gdb/gdbserver/lynx-low.c @@ -555,26 +555,12 @@ lynx_detach (int pid) return 0; } -/* A callback for find_inferior which removes from the thread list - all threads belonging to process PROC. */ - -static int -lynx_delete_thread_callback (thread_info *thread, void *proc) -{ - struct process_info *process = (struct process_info *) proc; - - if (thread->id.pid () == pid_of (process)) - remove_thread (thread); - - return 0; -} - /* Implement the mourn target_ops method. */ static void lynx_mourn (struct process_info *proc) { - find_inferior (&all_threads, lynx_delete_thread_callback, proc); + for_each_thread (proc->pid, remove_thread); /* Free our private data. */ free (proc->priv); -- 2.7.4