From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69102 invoked by alias); 24 Nov 2017 14:59:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69091 invoked by uid 89); 24 Nov 2017 14:59:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:209.85.128.195, H*RU:209.85.128.195, obv, H*r:sk:static. X-HELO: mail-wr0-f195.google.com Received: from mail-wr0-f195.google.com (HELO mail-wr0-f195.google.com) (209.85.128.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Nov 2017 14:59:50 +0000 Received: by mail-wr0-f195.google.com with SMTP id w95so20655869wrc.2 for ; Fri, 24 Nov 2017 06:59:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=HeLgKdlw3lKjFUb/px9VKIsICKqnDkkqc1J/mABSyGs=; b=q0ghN2DKC0r9Q3DshleufmUQLn3NsX0H0vx5kHygHxDc1U2vAgYxTn26OJU6D2Lbk4 zENlsrfIk4kOOzjrshqyk2q7RHHDIaG2vAD56aiP6HlqKX8LRS2cRY/HujaIkWP4lzdU FF9WsWn1FzKYHiBV6x3kh+geTcQE0kk5maGE/l0TNfteyr9BEgOJaCRDJBDBZAeSCw0p j+1XIuU+k9i22qbnJnfB3fC95mppgIcnXIJZybw0Wtozjhq7XDZNZ1v7P8ACs5io5Pt/ 8uck44HhK8dTo1kvnBNZurGFy7swQPP2yES+bULOyTeKJvKsYqL4QmEGlfWarzWhLUes S7qg== X-Gm-Message-State: AJaThX7mdQYqW4X3y1MlzbL06iEswkA6EFXqfcKa6+5PaJN4QcpBgghH A5d1gEPX+AGL/mNzBRuq4oKOKg== X-Google-Smtp-Source: AGs4zMbRT3lfUvG3ejhl2Hz/+0rPW3MgRGJNZLDOBFsW7+TdrvXvsDQagf/XcPfCqD2Z3ivO7THqEQ== X-Received: by 10.223.196.6 with SMTP id v6mr6185412wrf.236.1511535587679; Fri, 24 Nov 2017 06:59:47 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id j10sm9744139wrh.32.2017.11.24.06.59.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Nov 2017 06:59:47 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH OBV] Remove dead code in regcache::dump Date: Fri, 24 Nov 2017 14:59:00 -0000 Message-Id: <1511535582-18721-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00610.txt.bz2 footnote_register_size in regcache::dump is a constant zero, so the condition check against footnote_register_size is dead code. The code writing to footnote_register_size was removed by 01e1877. This patche removes footnote_register_size and the dead code. gdb: 2017-11-24 Yao Qi * regcache.c (regcache::dump): Remove footnote_register_size. --- gdb/ChangeLog | 4 ++++ gdb/regcache.c | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index aecd85b..bec8433 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2017-11-24 Yao Qi + * regcache.c (regcache::dump): Remove footnote_register_size. + +2017-11-24 Yao Qi + * regcache.c (cooked_read_test): Add more test for readonly regcache. diff --git a/gdb/regcache.c b/gdb/regcache.c index e82176b..ac905c6 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -1327,7 +1327,6 @@ regcache::dump (ui_file *file, enum regcache_dump_what what_to_dump) struct gdbarch *gdbarch = m_descr->gdbarch; int regnum; int footnote_nr = 0; - int footnote_register_size = 0; int footnote_register_offset = 0; int footnote_register_type_name_null = 0; long register_offset = 0; @@ -1539,9 +1538,6 @@ regcache::dump (ui_file *file, enum regcache_dump_what what_to_dump) fprintf_unfiltered (file, "\n"); } - if (footnote_register_size) - fprintf_unfiltered (file, "*%d: Inconsistent register sizes.\n", - footnote_register_size); if (footnote_register_offset) fprintf_unfiltered (file, "*%d: Inconsistent register offsets.\n", footnote_register_offset); -- 1.9.1