public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/3] Fix regression: expression completer and scope operator (PR gdb/22584)
Date: Wed, 13 Dec 2017 13:26:00 -0000	[thread overview]
Message-ID: <1513171596-10665-1-git-send-email-palves@redhat.com> (raw)

This patch series fixes PR gdb/22584, a regression in the expression
completer:

 "(gdb) p std::[TAB]" => "(gdb) p std::std::"

GDB got confused above, there's no such thing as "std::std::".

Patch #1 factors out some code duplicated throughout the codebase.

The new function patched by patch #1 is used by patch #2 (the actual fix) uses.

Patch #3 fixes something in the new completion testing support
routines that I noticed while writing the tests for patch #2.

Pedro Alves (3):
  Factor out final completion match string building
  Fix regression: expression completer and scope operator (PR gdb/22584)
  Tighten regexp of
    lib/completion-support.exp:test_gdb_complete_tab_multiple

 gdb/cli/cli-decode.c                     |  41 +----------
 gdb/completer.c                          | 115 +++++++++++++++++++++----------
 gdb/completer.h                          |  24 ++++++-
 gdb/interps.c                            |  20 +-----
 gdb/symtab.c                             |  52 ++------------
 gdb/testsuite/gdb.cp/cpcompletion.exp    |  42 +++++++++++
 gdb/testsuite/gdb.cp/pr9594.cc           |  13 ++++
 gdb/testsuite/lib/completion-support.exp |   7 +-
 8 files changed, 169 insertions(+), 145 deletions(-)

-- 
2.5.5

             reply	other threads:[~2017-12-13 13:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 13:26 Pedro Alves [this message]
2017-12-13 13:26 ` [PATCH 3/3] Tighten regexp of lib/completion-support.exp:test_gdb_complete_tab_multiple Pedro Alves
2017-12-13 13:26 ` [PATCH 2/3] Fix regression: expression completer and scope operator (PR gdb/22584) Pedro Alves
2017-12-13 13:26 ` [PATCH 1/3] Factor out final completion match string building Pedro Alves
2017-12-13 15:58 ` [PATCH 0/3] Fix regression: expression completer and scope operator (PR gdb/22584) Simon Marchi
2017-12-13 16:41   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513171596-10665-1-git-send-email-palves@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).