From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/3] gdbserver/Windows: crash during connection establishment phase
Date: Fri, 04 May 2018 18:30:00 -0000 [thread overview]
Message-ID: <1525458603-33351-4-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <1525458603-33351-1-git-send-email-brobecker@adacore.com>
On Windows, starting a new process with GDBserver seeems to work,
in the sense that the program does get started, and GDBserver
confirms that it is listening for GDB to connect. However, as soon as
GDB establishes the connection with GDBserver, and starts discussing
with it, GDBserver crashes, with a SEGV.
This SEGV occurs in remote-utils.c::prepare_resume_reply...
| regp = current_target_desc ()->expedite_regs;
| [...]
| while (*regp)
... because, in our case, REGP is NULL.
This patch fixes the problem for Windows targets based on Intel
(x86 and x86_64).
gdb/gdbserver/ChangeLog:
* win32-i386-low.c (i386_arch_setup): set tdesc->expedite_regs.
---
gdb/gdbserver/win32-i386-low.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/gdb/gdbserver/win32-i386-low.c b/gdb/gdbserver/win32-i386-low.c
index a242f72..fdb95ce 100644
--- a/gdb/gdbserver/win32-i386-low.c
+++ b/gdb/gdbserver/win32-i386-low.c
@@ -442,6 +442,16 @@ i386_arch_setup (void)
init_target_desc (tdesc);
+#ifndef IN_PROCESS_AGENT
+#ifdef __x86_64__
+ static const char *expedite_regs_amd64[] = { "rbp", "rsp", "rip", NULL };
+ tdesc->expedite_regs = expedite_regs_amd64;
+#else /* __x86_64__ */
+ static const char *expedite_regs_i386[] = { "ebp", "esp", "eip", NULL };
+ tdesc->expedite_regs = expedite_regs_i386;
+#endif /* __x86_64__ */
+#endif
+
win32_tdesc = tdesc;
}
--
2.1.4
next prev parent reply other threads:[~2018-05-04 18:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 18:30 [Windows GDBserver] Make GDBserver functional again on Windows Joel Brobecker
2018-05-04 18:30 ` [PATCH 2/3] gdbserver/Windows: Fix "no program to debug" error Joel Brobecker
2018-05-10 0:09 ` Pedro Alves
2018-05-10 16:50 ` Joel Brobecker
2018-05-04 18:30 ` Joel Brobecker [this message]
2018-05-04 18:46 ` [PATCH 3/3] gdbserver/Windows: crash during connection establishment phase Pedro Alves
2018-05-04 18:58 ` Joel Brobecker
2018-05-04 19:12 ` Pedro Alves
2018-05-07 21:47 ` Joel Brobecker
2018-05-09 15:54 ` Pedro Alves
2018-05-09 23:09 ` Joel Brobecker
2018-05-09 23:17 ` Pedro Alves
2018-05-10 17:04 ` Joel Brobecker
2018-05-04 20:20 ` Eli Zaretskii
2018-05-04 18:30 ` [PATCH 1/3] [gdbserver/win32] fatal "glob could not process pattern '(null)'" error Joel Brobecker
2018-05-09 23:50 ` Pedro Alves
2018-05-10 16:48 ` Joel Brobecker
2018-05-04 18:41 ` [Windows GDBserver] Make GDBserver functional again on Windows Sergio Durigan Junior
2018-05-04 18:54 ` Joel Brobecker
2018-05-10 18:19 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525458603-33351-4-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).