From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24621 invoked by alias); 18 May 2018 21:42:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24612 invoked by uid 89); 18 May 2018 21:42:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mailsec115.isp.belgacom.be Received: from mailsec115.isp.belgacom.be (HELO mailsec115.isp.belgacom.be) (195.238.20.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 21:42:24 +0000 IronPort-PHdr: =?us-ascii?q?9a23=3ASI7A2x0qvc3OU9CzsmDT+DRfVm0co7zxezQtwd8Z?= =?us-ascii?q?seITK/ad9pjvdHbS+e9qxAeQG9mDsLQc06L/iOPJYSQ4+5GPsXQPItRndiQuro?= =?us-ascii?q?EopTEmG9OPEkbhLfTnPGQQFcVGU0J5rTngaRAGUMnxaEfPrXKs8DUcBgvwNRZv?= =?us-ascii?q?JuTyB4Xek9m72/q99pHPbQhEniaxba9vJxiqsAvdsdUbj5F/Iagr0BvJpXVIe+?= =?us-ascii?q?VSxWx2IF+Yggjx6MSt8pN96ipco/0u+dJOXqX8ZKQ4UKdXDC86PGAv5c3krgfM?= =?us-ascii?q?QA2S7XYBSGoWkx5IAw/Y7BHmW5r6ryX3uvZh1CScIMb7S60/Vza/4KdxUBLmiz?= =?us-ascii?q?oJOT4n/m/ZiMNwgr5UrhWuqBJw2IPUfIOYOeBicq7HYd8XR2xMVdtRWSxbBYO8?= =?us-ascii?q?apMCAfABPeZZq4n9pkMOrQOgCgKxBOzg0CVIhnjv3a0n0uQuDxvG3Bc9FN8JqH?= =?us-ascii?q?TUrNT1NKMTUeCt1KnH0y/Pbv1M1jfn74jIaw0hofCSUrJqasrc0lIvFwDFj1WW?= =?us-ascii?q?t4PlIymZ2f8TvGWC6edrSOGhi3Y/pg1svjSiwt0ghpTHi44J0FzI6Dt1zYcvKd?= =?us-ascii?q?GmRkN3f9ipG4ZKuS6ALYt5WMYiTnltuCY917IJp4a2fDMPyJQ73x7fbOGHc5SQ?= =?us-ascii?q?7hLjSumRJTB4iWpgeL2inxqy8E6gxfPgVsSszVpGsi5InsPRun0DyxDf8NWLRu?= =?us-ascii?q?V880u7xzqC2R7f5vlBIU8ulKrbL5AhwqQ3lpoWqUnDBi/2mETyjK+XbkUk4van?= =?us-ascii?q?5/7pY7r8vJ+cMJZ0ihz/MqswgMy/Gv81MhMNX2mb/+SzyqHj8VfiT7pUlvE2iL?= =?us-ascii?q?XWsIjGJcQHoa60GxRV0ocm6xmlFTem088VnWIGLFJAYh2HlYvpN0vSL//iFf2/?= =?us-ascii?q?mUijkC93x/DaOb3sGprNIWXYn7v4ZbZy8VJcxxYzzd9B/JJZEaoBIPXuWk/rqN?= =?us-ascii?q?PXEBE4PBauw+n5Etl90ZkeWW3cSpOeZZjTtFiOrscmOeKMZcdBozf4IuImz+Xv?= =?us-ascii?q?iHYjmhkWdP/tlZQbYjWgF+htI0iCSWHrn80KHHgDpAd4S/bl23OYVjsGX3azW6?= =?us-ascii?q?Mk/jxzN4u8Cp7eR423m/TVxCe6GpxOfm0AFVmWFm71doieQN8XazOUL9MnmDFS?= =?us-ascii?q?BuvpcJMoyRz77Fyy8LFgNOeBoiA=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2D/AwAvSP9a/+h+gm1dHgEGDINDQoEch?= =?us-ascii?q?ByIY44UMQFdjxaEIIF4CysBgyyBDgQCAoIQIjQYAQIBAQEBAQECAWsogjUiglI?= =?us-ascii?q?BBSMzMwgDDgoCAiYCAjkeBgGFOqk4ghyEWYNugieBCYkAP4Qbh3OCVAKYTAcCg?= =?us-ascii?q?WeMcIx9K5BMgSUcOIFSbYMXkE89gT0IDAGOWwEB?= X-IPAS-Result: =?us-ascii?q?A2D/AwAvSP9a/+h+gm1dHgEGDINDQoEchByIY44UMQFdjxa?= =?us-ascii?q?EIIF4CysBgyyBDgQCAoIQIjQYAQIBAQEBAQECAWsogjUiglIBBSMzMwgDDgoCA?= =?us-ascii?q?iYCAjkeBgGFOqk4ghyEWYNugieBCYkAP4Qbh3OCVAKYTAcCgWeMcIx9K5BMgSU?= =?us-ascii?q?cOIFSbYMXkE89gT0IDAGOWwEB?= Received: from 232.126-130-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.130.126.232]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 18 May 2018 23:42:21 +0200 Message-ID: <1526679741.1604.9.camel@skynet.be> Subject: Re: [RFC 1/5] Add helper functions check_for_flags and check_for_flags_vqcs From: Philippe Waroquiers To: Simon Marchi , gdb-patches@sourceware.org Date: Fri, 18 May 2018 23:39:00 -0000 In-Reply-To: <0a630fc9-18bd-6d3b-5558-9a0389c64d4f@simark.ca> References: <20180505192804.12731-1-philippe.waroquiers@skynet.be> <20180505192804.12731-2-philippe.waroquiers@skynet.be> <0a630fc9-18bd-6d3b-5558-9a0389c64d4f@simark.ca> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00430.txt.bz2 On Thu, 2018-05-17 at 21:22 -0400, Simon Marchi wrote: > > + /* First set the flags_counts to 0. */ > > + { > > + const char *f = flags; > > + while (*f) > > + { > > + flags_counts[f - flags] = 0; > > + f++; > > + } > > + } > > What about something like > > memset (flags_count, 0, sizeof (flags_count[0]) * strlen (flags)); The code initialising the flags_counts is somewhat similar in structure to the code that increments the flags_counts. So, it looks more clear to me to have the zero-ing code and the incrementing code looking like each other. But if for gdb, using memset is the typical pattern to zero an array of int, fine for me. What do you think ? Philippe