From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41749 invoked by alias); 30 May 2018 19:05:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41627 invoked by uid 89); 30 May 2018 19:05:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 May 2018 19:05:15 +0000 Received: from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id EE.86.24558.9E5FE0B5; Wed, 30 May 2018 21:05:13 +0200 (CEST) Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESSHC002.ericsson.se (153.88.183.24) with Microsoft SMTP Server (TLS) id 14.3.382.0; Wed, 30 May 2018 21:04:27 +0200 Received: from ESESBMB503.ericsson.se (153.88.183.170) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 30 May 2018 21:04:26 +0200 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB503.ericsson.se (153.88.183.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 30 May 2018 21:04:26 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by BYAPR15MB2392.namprd15.prod.outlook.com (2603:10b6:a02:8d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.797.11; Wed, 30 May 2018 19:04:24 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed 07/15] Remove regcache_raw_read_part Date: Wed, 30 May 2018 19:05:00 -0000 Message-ID: <1527707033-27183-8-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1527707033-27183-1-git-send-email-simon.marchi@ericsson.com> References: <1527707033-27183-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: SN6PR0102CA0010.prod.exchangelabs.com (2603:10b6:805:1::23) To BYAPR15MB2392.namprd15.prod.outlook.com (2603:10b6:a02:8d::11) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB2392; X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2392;3:DU+HEJWOk7rSOz2z7Mu6moalv+fJ13ryYmo3ruhoxBwqFjB7BifmH/jziDyUqd9CrcVK3sZF2lxmvkhd8P/L96LoDyM8umAkWYdXBH/SAPnvdnRqX6XLD7Y/Zbw/oTXEin22ND5hdqSxfSddup6wD5foCSE9lLyPQK9HQl99oFiWtFUWkh1Vp1gsgxyN519/NUMCXfQQQi6wfBJOqiCcutZ4U6VbT0UdVL935ZtO0OWjsGZ/wlJRYxgicfhuS3+K;25:/w6PT/ztWN+T8d16zA1uQ2q90NfXyXzO+2Egnmc8AxK2jUOoErMyU6a3cXQpvT6wyZ3RlL9ruBIWQd59mExKdzOayXE5WP4rbnz7WikIbUHMyT97loE0d2zwsf9r4ahhRhUTmuqgVivGuyxdNFvisU0obrEWiIyKXKZfmF1z92NSw5sPXpveJ61zs3gB0ZsV8uKr6oeECDJuKbzKSpckN98nw+wPjiQgNA3DaVo7l2wr/f7AO5GTxGZa0jcWAAQ6S4Ffj/gvp6IPPpuhNmkHAuCtmj0QUD0oJf5gvMYFjc9ctrog2bIhVrgPkZ7Vp9R2E/5QcSMC/TlGieaiwDRrqg==;31:5QKPifWGyfn3PG4iiiwkFWwFiZy6FElxDpPJ6z09Nd2FxekJih6QEAm3q7nEKwgO/UoJYPsVJYGbUitPK5w78cDQf9jkElBKvQk8gFFK2sUMxyJZJdvcrqMpgpaX1fj4vwDRXOXNty+AuhJK5AZJEHqKE8gPMCzHlhdz6EyLkAEY8TrHxDouJWeH9yrEDeHcixrFBkHTMomt+wfnkoMbO0s9BPOLcuMEbTN7bimpV8o= X-MS-TrafficTypeDiagnostic: BYAPR15MB2392: X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2392;20:C44b80Nu2w0RGUs9oasTZN2/cv0MIPUs6Id6dEHodO3og1Oo9RBrJEe0K6/Thw4nxHwDYtfnLxfE8V61rmqE7G5twQU+e1aU7VcI3dJ5tXckHCAkpxdL42C290v92yg/2Qo1i1qRb5Nm7DmGyXG91gQ3852DdeLAuLksPX94sfy5Pk0kCGOV1RhE2RBoE2XRfX+/o4tqpPDcrbb+5i2Q3Yux6S93rnovumLKSZkK8w0d6D3lAWCQ6Aw6w8KNZl4wI6KI/5240ptveNjA+ohY+kJ1tgRNlROv9WzKUsTLK2Zo6tNV+X69bNz70w/cnPBj9A7OkiOHv4pswx/94iJiFn4cZUSEeuh/8oUGcSvqvKQtGrlaIwO1CD56kFrvVVqDHRxelPfYr9gr6Y+pFpAi/ZpMHQPvZF+BgmTnBRJo1zjikUIV6nJ31CyURoglqHEFI8LeTcaWxBUlAv7iWJ1Xn2ese8kaK/O+b98uYI+qM01jmzXq1UXmN96wXEayC6lT;4:ahLnuhM0lldlI96EoOZLwPIk+btcVzo6a4nbKZmnPTE4GmhqrAuSgSu1IIC8DWtO9I5gExwtgYF7gCE+PQIaq/NURwYLUDq3VwNRtLfsrPmFPqHjy7QhCW5FJ7ggdOp7J/iJrqEMmN+L6gy0ZRt4XLss7mLTigPiJt1D7SFhE8RkegIVncvsQ6vcpCBREFaBD/L+y/g+mI/aN9hXkYcLLz4IU0MbmnYDMU5xf/SAA6z7tkK0mNJ0PfPexGtY/ZuTFvDLudcfCb3FqgEAJgn7JKSSXmgYNKjaQPenIk5Y1fbHViVRzyDCaHMrBJ3isb9c X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:BYAPR15MB2392;BCL:0;PCL:0;RULEID:;SRVR:BYAPR15MB2392; X-Forefront-PRVS: 0688BF9B46 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(396003)(346002)(366004)(39860400002)(39380400002)(376002)(54534003)(199004)(189003)(50226002)(6512007)(486006)(8936002)(81156014)(6486002)(25786009)(26005)(68736007)(8676002)(81166006)(51416003)(86362001)(575784001)(52116002)(956004)(2616005)(44832011)(76176011)(476003)(446003)(11346002)(6666003)(6916009)(305945005)(386003)(6506007)(47776003)(53936002)(2906002)(36756003)(7736002)(97736004)(4326008)(16526019)(5660300001)(186003)(6116002)(3846002)(316002)(16586007)(2361001)(2351001)(48376002)(478600001)(105586002)(59450400001)(107886003)(50466002)(66066001)(106356001);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR15MB2392;H:elxacz23q12.ca.am.ericsson.se;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BYAPR15MB2392;23:WkRN9YJRYCjLieZTRXDh+rh68ghyGb8kyHesYGyYL?= =?us-ascii?Q?E8LQzeDB2DcMZW9Gaa0YFI9qNj2eK8fMNvhy6Ch3hNxppsW4qWuAE/DQgxoK?= =?us-ascii?Q?6Zzxpdo26lctHn6+OJwPcqqXXSlKP+vyopjFewUtX/9Ofp+D0AZmUoBKg90F?= =?us-ascii?Q?t48h34wIj16l2SD5jmbj3vqZgle5lrn4EVYO1YFdtAst6edBFaTWdgpHJgOE?= =?us-ascii?Q?sf0rEg3WUxgi5mfYjGrnMn4Gr0D44upln1L60N+LbVV4qLhsfHt+N59uJRPG?= =?us-ascii?Q?hLbsjPCH4VQ/AdIIRjgcHB2+LrVMaZp7V6CmWtlKicpFi4MtgeuY9kYrN8Sn?= =?us-ascii?Q?weQDBB1EaWnwgnbafEZdxDAl+n38XuYJFx3s7xgdKkKtHOuBP3MB1EqC0aFl?= =?us-ascii?Q?YRgcT6/gAJNSBBku8pnQS1CNXsH2TZPP0+D+U/RdUCKsnE/3NSODT7PTRy4j?= =?us-ascii?Q?tyGauugE9GLcuWm3JRb9tV2Wi5amYJA8TDQrkIYoHk5zT9wfznit6+v8z1lC?= =?us-ascii?Q?AKFkKEaXApEibDgnlgdnVLRaypIMFzf8zBnFBIaB/AI05ki4Ciabas5Yu148?= =?us-ascii?Q?aXJ2POB8ypZgR/2r7IRU+tW+OW2XWykd97aMbjR0LFFvf27S00H6+YBqrFIr?= =?us-ascii?Q?Hy5a2Rm8ySftN+zW+K8oCXnM4MXavgRElPOuDgWo78DCfGpQPTqr+tjnAHE1?= =?us-ascii?Q?oGJ7N20Zcpc5Ciih4xMQNAw+4zkwSR2Ext/lLVBB9+4rmZChARyeszddEH96?= =?us-ascii?Q?C33r6OcUY9YTQ/g+LzYHVxQukGFsSQ41+3/uAsMSPrQ8ihryiw0cBcp+voJ+?= =?us-ascii?Q?40Uv9GgtDcVIoU8ExcNWvVvTxLBlPR2o1WOs+Ol4S57pd0gPSvwSvVLAmtE6?= =?us-ascii?Q?1T4mhKyOAXbw0vmGY+DeJoh0x4EIiu7T2w/KmHkn90xBteoAM3rEacP2oDni?= =?us-ascii?Q?SN0M4d3OEM4pVcaXH9iHaHeBoaYMf4XPR76EmwxXWO/i75JBR4HNrMcXMImO?= =?us-ascii?Q?qlMgo/82t9rDayKA5CroMjfudQKVqgfPnu0YzzPqv+WHCWkRchmIPlwpimKl?= =?us-ascii?Q?S0u2u3YQy7GbexZzkhV7Dy1SjWrKjajTfsyTEm7GDkdG0mGz//xJPbhBYVlR?= =?us-ascii?Q?e23mmotMCfmX4lP8ClsSsUxrEAuVxAG8vAKaybTGpy59iWqZsBIUSp47apZ1?= =?us-ascii?Q?djL62+CfkT5YD8VP6leYUdeMiCc3kAy6cg4a8vcomvYcn76v5fRYdbNCxCd6?= =?us-ascii?Q?QvRLRfD1QNIpG9o5svU0PqURAn3yewUnLd+/47OVRHlFeSLS7fyAGH9WmrtF?= =?us-ascii?Q?uOaZTkDmh0BjWkpIqQfwaU4SYFT+8Wp/rEtGoJFahSS?= X-Microsoft-Antispam-Message-Info: 45GGY++8yMozePKNAOQf0Kyrki1UGe2aigOo6fNbJDXQYEUGcmVSXq8ku6++i1lEzpiC2dg78RGtKBdP/U5WUdHfDgG8AbXiCPm4aOlvEXrUZOJunTkVFmJkCoYsux/JkpdujAn+HXXm3T1fsWFyY5XzLPP2olz4lyuqCASBOp5cFblnPzEBhKLIlM5lQ9SR X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2392;6:OVBRjuz8QPCUhqtBCvuy65KatB5SVT0hgkv35UC+tbDd8tzU+mZJmygOITyagWpLGfLnuUpdSrm5pTra7fIZlb9t338njkgJC8/LqOZLaemAg2+YwMJtUWV0KgZziWeUctweuthVselXZX5C+3I8Xzt/k/A+T8G+2pzhpJjizW0nBehQcvQCmXOkCVdE692PJOIVy3xYRqYh8OWR+GLtlRbQjKgiusw/6Q8ZwFxVdgaIWf1hDAB8rNTGX/6cEMZGExLBXIlSYVHu3SsLN1bTclaNzRa+ss7Y3RXyTMSqnp7ziGS3DqwAT3jXc+kHd66UBWa4364kjAe7kmCkBYaUfAg0LchFbTCpY7jdnZISi9HOJ/HRmOh3TZK5yr2eLOUwW8xTBBUkdlTSH1r8YcTK6GuKJ6lYETUwQcaYg9SytwUe9amUPc6s9Xj7FSzjLjQ9cweEyL2KRdTD4xABP8D4Zg==;5:wgf76P3wR3JaIr1qJX/uAZq1jSLnojTYgGjZaP/SWzO1Qd5yfYCH5CzrO4+7XqNHKK9QPR0CDjWSzpYezcXhMqmFglV15D9qrNDl2UWQhK3lC/n8wswgTgKakmu1C7zbmSiz7Ms/YN+E/qY3LcmWDwODDNWtiaJpiasy2GR2RGo=;24:YZtNSZ6jOHyMj14joPRPhe28k5bx2G2y8b71OINGpSGxO7TuTDC2TPIELEPMqL/RIDgR7wp5hMe4+5R7E4OTLok+rhSHXU7zLMYABibKArk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2392;7:oG9GDVuSEBVIv8XgpSJk15HUwajQ8O2u9AeB36UJzIWaiTrBE4H2boKg38TqCPcXWSa5QKjwPxwGViyanNL1tYrQK7nNvf0iGILc1LKaMDbPtUXy2ZTJT6c8cteVashmYNamf2u+v9biFhmteWRhiIjMoMiAQti8f316SW25cP6UJa6ODH4e95qPCwybaqxZvTI1MPpbGNWkJcDnUmFsm26DhV37aJ8wNdiOQysRB2b6WAu6GqmM8XJNXFFvDm4R X-MS-Office365-Filtering-Correlation-Id: 10bdb357-00ff-4d73-e394-08d5c66028bd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2018 19:04:24.1736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10bdb357-00ff-4d73-e394-08d5c66028bd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2392 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00803.txt.bz2 Remove regcache_raw_read_part, update callers to use readable_regcache::raw_read_part instead. gdb/ChangeLog: * regcache.h (regcache_raw_read_part): Remove, update callers to use readable_regcache::raw_read_part instead. * regcache.c (regcache_raw_read_part): Remove. --- gdb/ChangeLog | 6 ++++++ gdb/amd64-tdep.c | 4 ++-- gdb/amd64-windows-tdep.c | 2 +- gdb/regcache.c | 7 ------- gdb/regcache.h | 4 +--- gdb/spu-tdep.c | 2 +- gdb/xtensa-tdep.c | 2 +- 7 files changed, 12 insertions(+), 15 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 98b80d3..e7a57c0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2018-05-30 Simon Marchi + * regcache.h (regcache_raw_read_part): Remove, update callers to + use readable_regcache::raw_read_part instead. + * regcache.c (regcache_raw_read_part): Remove. + +2018-05-30 Simon Marchi + * regcache.h (regcache_cooked_read): Remove, update callers to use readable_regcache::cooked_read instead. * regcache.c (regcache_cooked_read): Remove. diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c index 597bb0f..dfd1118 100644 --- a/gdb/amd64-tdep.c +++ b/gdb/amd64-tdep.c @@ -844,8 +844,8 @@ amd64_return_value (struct gdbarch *gdbarch, struct value *function, gdb_assert (regnum != -1); if (readbuf) - regcache_raw_read_part (regcache, regnum, offset, std::min (len, 8), - readbuf + i * 8); + regcache->raw_read_part (regnum, offset, std::min (len, 8), + readbuf + i * 8); if (writebuf) regcache_raw_write_part (regcache, regnum, offset, std::min (len, 8), writebuf + i * 8); diff --git a/gdb/amd64-windows-tdep.c b/gdb/amd64-windows-tdep.c index 32ebead..bf351ee 100644 --- a/gdb/amd64-windows-tdep.c +++ b/gdb/amd64-windows-tdep.c @@ -329,7 +329,7 @@ amd64_windows_return_value (struct gdbarch *gdbarch, struct value *function, { /* Extract the return value from the register where it was stored. */ if (readbuf) - regcache_raw_read_part (regcache, regnum, 0, len, readbuf); + regcache->raw_read_part (regnum, 0, len, readbuf); if (writebuf) regcache_raw_write_part (regcache, regnum, 0, len, writebuf); return RETURN_VALUE_REGISTER_CONVENTION; diff --git a/gdb/regcache.c b/gdb/regcache.c index ec1bfb0..051bd48 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -867,13 +867,6 @@ regcache::write_part (int regnum, int offset, int len, } enum register_status -regcache_raw_read_part (struct regcache *regcache, int regnum, - int offset, int len, gdb_byte *buf) -{ - return regcache->raw_read_part (regnum, offset, len, buf); -} - -enum register_status readable_regcache::raw_read_part (int regnum, int offset, int len, gdb_byte *buf) { assert_regnum (regnum); diff --git a/gdb/regcache.h b/gdb/regcache.h index f7228e4..4865d89 100644 --- a/gdb/regcache.h +++ b/gdb/regcache.h @@ -54,9 +54,6 @@ extern LONGEST regcache_raw_get_signed (struct regcache *regcache, write style operations. The read variant returns the status of the register. */ -extern enum register_status - regcache_raw_read_part (struct regcache *regcache, int regnum, - int offset, int len, gdb_byte *buf); void regcache_raw_write_part (struct regcache *regcache, int regnum, int offset, int len, const gdb_byte *buf); @@ -243,6 +240,7 @@ public: template> enum register_status raw_read (int regnum, T *val); + /* Partial transfer of raw registers. Return the status of the register. */ enum register_status raw_read_part (int regnum, int offset, int len, gdb_byte *buf); diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c index 4628776..1d0766e 100644 --- a/gdb/spu-tdep.c +++ b/gdb/spu-tdep.c @@ -1655,7 +1655,7 @@ spu_software_single_step (struct regcache *regcache) target += SPUADDR_ADDR (pc); else if (reg != -1) { - regcache_raw_read_part (regcache, reg, 0, 4, buf); + regcache->raw_read_part (reg, 0, 4, buf); target += extract_unsigned_integer (buf, 4, byte_order) & -4; } diff --git a/gdb/xtensa-tdep.c b/gdb/xtensa-tdep.c index c23d777..bee4969 100644 --- a/gdb/xtensa-tdep.c +++ b/gdb/xtensa-tdep.c @@ -1596,7 +1596,7 @@ xtensa_extract_return_value (struct type *type, for (; len > 0; len -= 4, areg++, valbuf += 4) { if (len < 4) - regcache_raw_read_part (regcache, areg, offset, len, valbuf); + regcache->raw_read_part (areg, offset, len, valbuf); else regcache->raw_read (areg, valbuf); } -- 2.7.4