Re: [RFA_v3 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'

[Philippe Waroquiers <philippe.waroquiers@skynet.be>]

On Fri, 2018-06-29 at 13:21 +0100, Andrew Burgess wrote:
> This patch makes it much clearer (I think) that there are multiple was
> to IDentify a frame, level, address, function-name.
> 
> I wonder if using the keyword 'id' might be confusing were my patch to
> end up being merged?  Would a consistent 'level' be better?
> 
> Interested to hear your thoughts...

Counting in gdb.texinfo, I see 5 references to regexp 'frame.id'
(but I am not at all sure that these are referencing the #integer
that backtrace shows).

I see one reference to 'frame.level'.

I see 8 references to 'frame.number', and some of these
references are explicitly explaining that backtrace shows
a frame number.

In the code, I see a bunch of occurrences of 'frame.level'
and much more of 'frame.id', but as far as I can see, frame id
is rather the internal 'struct frame_id' concept.
frame.number seems not used too much in the code, except
as traceframe_number

So, for me, fine to replace
   Usage: frame apply id ID... [FLAG]... COMMAND
   ID is a space-separated list of IDs of frames to apply COMMAND on.
by
   Usage: frame apply level LEVEL... [FLAG]... COMMAND
   LEVEL is a space-separated list of frames identified by their level to apply COMMAND on.

But if we want to keep the current use of frame number, it should rather be 
   Usage: frame apply number NUMBER... [FLAG]... COMMAND
   NUMBER is a space-separated list of frames identified by their number to apply COMMAND on.

Whatever we take, we have to ensure that gdb.texinfo systematically use 
it to identify a frame as shown by backtrace (#integer).


All the above change is quite mechanical, but that is better done once feedback
is given e.g. by Pedro over this patch RFA_v3 and about your patch.

And then, we need to see in which order which patch is applied.
(I slightly prefer my patch first, but I guess you slightly prefer
your patch first :).

So let e.g. Pedro decide about which one is ready to go in first.

In summary: review needed, and then a decision about the above and
   about which patch goes first ...

Thanks

Philippe