Re: [RFA_v3 2/8] Implement frame apply [all | COUNT | -COUNT | id ID... ] [FLAG]... COMMAND.

[Philippe Waroquiers <philippe.waroquiers@skynet.be>]

On Mon, 2018-07-09 at 20:15 +0100, Pedro Alves wrote:
> I noticed that as is, frame_apply_command_count is going to parse CMD
> for parse_flags_qcs for every iteration.  I wonder whether it wouldn't
> be clearer to split frame_apply_command_count after that CMD parsing
> to a separate function that is called by both frame_apply_id_command
> and frame_apply_command_count.
Thanks for the comments.
I have just posted RFA_v4, which I think handles all the comments
as suggested, except the above :
currently, all 3 'frame apply' commands are directly
calling frame_apply_command_count after having established the
starting frame and count.
I think this is preferable, as we have the flag parsing and
error checking about missing cmd at only one place.
The only consequence I see is that flags will be parsed for each
range of frames, but that will for sure not be performance critical
(we parse already twice the LEVEL arg).

So, I have added a sentence in the frame_apply_command_count 
function to describe that CMD optionally starts with qcs flags.

Thanks

Philippe