From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32718 invoked by alias); 14 Aug 2018 18:42:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32703 invoked by uid 89); 14 Aug 2018 18:42:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=our X-HELO: mailsec109.isp.belgacom.be Received: from mailsec109.isp.belgacom.be (HELO mailsec109.isp.belgacom.be) (195.238.20.105) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Aug 2018 18:42:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1534272171; x=1565808171; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=z1bli61NmtQ70DpBqgJfMXNW8dj1l3z+oCMEqNFC3FI=; b=hVByVIgbG4je+gt2dclRctq/LENExEcRxf75FTazgzEZYtO6I3XyOkRK FzHIRdHN0laYL46qzLUMRhcfpbrApA==; Received: from 217.24-133-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.133.24.217]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 14 Aug 2018 20:42:49 +0200 Message-ID: <1534272169.15655.6.camel@skynet.be> Subject: Re: [RFC/PATCH] Don't disable selftests in a non-development build From: Philippe Waroquiers To: Pedro Alves , Sergio Durigan Junior , GDB Patches Cc: Joel Brobecker Date: Tue, 14 Aug 2018 18:42:00 -0000 In-Reply-To: <367277ad-d735-0854-7aca-1df9a1927115@redhat.com> References: <20180814054221.13061-1-sergiodj@redhat.com> <367277ad-d735-0854-7aca-1df9a1927115@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00358.txt.bz2 On Tue, 2018-08-14 at 19:08 +0100, Pedro Alves wrote: > Another approach to addressing this issue here: > > > Due to the many racy testcases and random failures we see when running > > the GDB testsuite, it is unfortunately not possible to perform a full > > test when one is building a downstream package. As the Fedora GDB > > maintainer and one of the Debian GDB uploaders, I feel like this > > situation could be improved by, at least, executing our selftests > > after the package has been built. However, we currently (for some > > reason that is not clear by reading the archives, but see more below) > > disable selftests on non-development builds. Therefore, this patch > > aims to leave them enabled all the time, for everyone (including the > > end users). > > ... is to come up with some small set of stable testcases that > are considered the "smoke tests" and add a mechanism to run them. > Could be just a list of testcases in a file that is passed to > make check TESTS="list of basic tests here" > or some make target like "make check-smoke", or something > else even. Instead of (or in addition to) some list of tests that are known to be non-racy/alwayd ok, maybe it would be nice to have a list of tests that are known to be racy/sometimes wrong ? We e.g. could mark these racy tests as part of the test itself, with some pseudo dejagnu code like : if [do_not_run_racy_or_sometimes_wrong_tests] { return } # or, if the test is only racy on some platform if [do_not_run_racy_or_sometimes_wrong_tests && istarget x86_64-*-*] { return } The above would also help the gdb developers to interpret the results of a test run. I am always wondering if a failure I see can (or cannot) be explained by the change I just did. Philippe