Re: [PATCH] ARM: Do not use FP reg when on AAPCS

[Marius Muench <marius.muench@eurecom.fr>]

On 10/24/2018 07:23 PM, Pedro Alves wrote:
> Tiny nit:
>
> On 10/24/2018 12:40 PM, Marius Muench wrote:
>>
>> +      /* AAPCS does not use a frame register, so we can abort here. */
>
> There should be a double space after the period.
>
>> +      if (gdbarch_tdep (gdbarch)->arm_abi == ARM_ABI_AAPCS)
>> +        return;
>
> Thanks,
> Pedro Alves
>

Fair enough, updated version below.

gdb/ChangeLog:
2018-10-24  Marius Muench  <marius.muench@eurecom.fr>

       * arm-tdep.c (arm_scan_prologue): Don't dereference FP reg
       when on AAPCS.
---
 gdb/arm-tdep.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 53eee76926..0165e92527 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -1801,6 +1801,10 @@ arm_scan_prologue (struct frame_info *this_frame,
       CORE_ADDR frame_loc;
       ULONGEST return_value;

+      /* AAPCS does not use a frame register, so we can abort here.  */
+      if (gdbarch_tdep (gdbarch)->arm_abi == ARM_ABI_AAPCS)
+        return;
+
       frame_loc = get_frame_register_unsigned (this_frame, ARM_FP_REGNUM);
       if (!safe_read_memory_unsigned_integer (frame_loc, 4, byte_order,
                                              &return_value))