public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/5] gdb_proc_service.h comment and whitespace synchronization
Date: Fri, 28 Sep 2018 14:50:00 -0000	[thread overview]
Message-ID: <1538146201-16374-2-git-send-email-gbenson@redhat.com> (raw)
In-Reply-To: <1538146201-16374-1-git-send-email-gbenson@redhat.com>

This commit updates comments and whitespace in GDB's and gdbserver's
gdb_proc_service.h.

gdb/ChangeLog:

	* gdb_proc_service.h: Whitespace change.

gdb/gdbserver/ChangeLog:

	* gdb_proc_service.h: Synchronize comments and whitespace with
	GDB's version of this file.
---
 gdb/ChangeLog                    |  4 ++++
 gdb/gdb_proc_service.h           |  2 +-
 gdb/gdbserver/ChangeLog          |  5 +++++
 gdb/gdbserver/gdb_proc_service.h | 40 ++++++++++++++++++++++++++++++++--------
 4 files changed, 42 insertions(+), 9 deletions(-)

diff --git a/gdb/gdb_proc_service.h b/gdb/gdb_proc_service.h
index 41175a6..39f0e03 100644
--- a/gdb/gdb_proc_service.h
+++ b/gdb/gdb_proc_service.h
@@ -70,7 +70,7 @@ EXTERN_C_PUSH
 typedef enum
 {
   PS_OK,		/* Generic "call succeeded".  */
-  PS_ERR,		/* Generic error. */
+  PS_ERR,		/* Generic error.  */
   PS_BADPID,		/* Bad process handle.  */
   PS_BADLID,		/* Bad LWP identifier.  */
   PS_BADADDR,		/* Bad address.  */
diff --git a/gdb/gdbserver/gdb_proc_service.h b/gdb/gdbserver/gdb_proc_service.h
index b3e7004..54ff59d 100644
--- a/gdb/gdbserver/gdb_proc_service.h
+++ b/gdb/gdbserver/gdb_proc_service.h
@@ -31,7 +31,30 @@ EXTERN_C_PUSH
 
 EXTERN_C_POP
 
-#else
+#else /* HAVE_PROC_SERVICE_H */
+
+/* The following fallback definitions have been imported and adjusted
+   from glibc's proc_service.h  */
+
+/* Callback interface for libthread_db, functions users must define.
+   Copyright (C) 1999,2002,2003 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+/* The definitions in this file must correspond to those in the debugger.  */
 
 #ifdef HAVE_SYS_PROCFS_H
 #include <sys/procfs.h>
@@ -48,15 +71,16 @@ EXTERN_C_POP
 
 EXTERN_C_PUSH
 
+/* Functions in this interface return one of these status codes.  */
 typedef enum
 {
-  PS_OK,			/* Success.  */
-  PS_ERR,			/* Generic error.  */
-  PS_BADPID,			/* Bad process handle.  */
-  PS_BADLID,			/* Bad LWP id.  */
-  PS_BADADDR,			/* Bad address.  */
-  PS_NOSYM,			/* Symbol not found.  */
-  PS_NOFREGS			/* FPU register set not available.  */
+  PS_OK,		/* Generic "call succeeded".  */
+  PS_ERR,		/* Generic error.  */
+  PS_BADPID,		/* Bad process handle.  */
+  PS_BADLID,		/* Bad LWP identifier.  */
+  PS_BADADDR,		/* Bad address.  */
+  PS_NOSYM,		/* Could not find given symbol.  */
+  PS_NOFREGS		/* FPU register set not available for given LWP.  */
 } ps_err_e;
 
 #ifndef HAVE_LWPID_T
-- 
1.8.3.1

  parent reply	other threads:[~2018-09-28 14:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 14:50 [PATCH 0/5] Merge common proc_service headers Gary Benson
2018-09-28 14:50 ` [PATCH 3/5] Update GDB gdb_proc_service.h workaround to match gdbserver Gary Benson
2018-09-28 19:36   ` Tom Tromey
2018-09-28 14:50 ` [PATCH 2/5] Add workaround from gdbserver's gdb_proc_service.h to GDB Gary Benson
2018-09-28 19:34   ` Tom Tromey
2018-09-28 14:50 ` Gary Benson [this message]
2018-09-28 19:28   ` [PATCH 1/5] gdb_proc_service.h comment and whitespace synchronization Tom Tromey
2018-09-28 14:58 ` [PATCH 4/5] Move duplicated code to common/gdb_proc_service.h Gary Benson
2018-09-28 19:40   ` Tom Tromey
2018-09-28 14:59 ` [PATCH 5/5][OPTIONAL] Remove ancient workaround Gary Benson
2018-09-28 19:44   ` Tom Tromey
2018-09-28 19:33 ` [PATCH 0/5] Merge common proc_service headers Tom Tromey
2018-09-28 19:46   ` Tom Tromey
2018-10-01  8:27     ` Gary Benson
2018-10-05 14:23       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1538146201-16374-2-git-send-email-gbenson@redhat.com \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).