From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50535 invoked by alias); 27 Oct 2018 12:52:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50525 invoked by uid 89); 27 Oct 2018 12:52:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:833 X-HELO: mailsec112.isp.belgacom.be Received: from mailsec112.isp.belgacom.be (HELO mailsec112.isp.belgacom.be) (195.238.20.108) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 27 Oct 2018 12:52:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1540644750; x=1572180750; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=GQ+uIyeqaMXZE9spyMx9fgsGzr+87uamqLwBzsUtmAM=; b=UqqNJLPoaOLtI8pDNYNKpb1d5aN1K5oRmyAZ3OpYrpvjXEMbs3KBrhI/ GnuTqTmq4AQcVolHdcYYBSsSvRbyKw==; Received: from 110.212-243-81.adsl-dyn.isp.belgacom.be (HELO md) ([81.243.212.110]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 27 Oct 2018 14:52:28 +0200 Message-ID: <1540644747.12106.23.camel@skynet.be> Subject: Re: [RFVv4 5/5] Add a test case for info args|functions|locals|variables [-q] [-t TYPEREGEXP] [NAMEREGEXP] From: Philippe Waroquiers To: Pedro Alves , gdb-patches@sourceware.org Date: Sat, 27 Oct 2018 12:52:00 -0000 In-Reply-To: <0635db5a-c2ff-cc3f-3dfb-7c2c98c7323b@redhat.com> References: <20181025201107.24828-1-philippe.waroquiers@skynet.be> <20181025201107.24828-6-philippe.waroquiers@skynet.be> <0635db5a-c2ff-cc3f-3dfb-7c2c98c7323b@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00652.txt.bz2 On Fri, 2018-10-26 at 19:06 +0100, Pedro Alves wrote: > On 10/25/2018 09:11 PM, Philippe Waroquiers wrote: > > Add a test case for info args|functions|locals|variables [-q] [-t TYPEREGEXP] [NAMEREGEXP] > > > > gdb/testsuite/ChangeLog > > 2018-10-25 Philippe Waroquiers > > > > * gdb.base/info_qt.c: New file. > > * gdb.base/info_qt.exp: New file. > > Thanks! > > I still think that the gdb.sum output with the patch below on > top looks much clearer. Do you disagree? No, that is effectively much clearer. I have applied the patch, handled (I think/hope) all the remaining comments, and have pushed the series. Again, many thanks for the several reviews done (Eli, Tom and you) ... Philippe