From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Matthew Malcomson <Matthew.Malcomson@arm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"palves@redhat.com" <palves@redhat.com>
Cc: nd <nd@arm.com>
Subject: Re: [Patch][gdb] Initialise quiet flag for "info functions"
Date: Fri, 02 Nov 2018 13:31:00 -0000 [thread overview]
Message-ID: <1541165414.1844.1.camel@skynet.be> (raw)
In-Reply-To: <VI1PR0801MB2014605E2BB011A75B4E9829E0CF0@VI1PR0801MB2014.eurprd08.prod.outlook.com>
Thanks for the analysis and fix,
I have pushed the below fix as obvious (and an equivalent fix in stack.c)
as d54cfd762b06.
Philippe
On Fri, 2018-11-02 at 11:30 +0000, Matthew Malcomson wrote:
> With this flag unset, using 'info functions' without a set quiet flag
> was not deterministic and was causing some flaky test failures.
>
> Failures seen in (at least).
> gdb.base/info_qt.exp
> gdb.dwarf2/dw2-case-insensitive.exp
> gdb.base/info-fun.exp
>
> Ok for trunk?
> I don't have commit rights.
>
> gdb/ChangeLog:
>
> 2018-11-02 Matthew Malcomson <matthew.malcomson@arm.com>
>
> * symtab.c (info_functions_command): Initialise quiet flag.
>
>
>
> ############### Attachment also inlined for ease of reply ###############
>
>
> diff --git a/gdb/symtab.c b/gdb/symtab.c
> index cd27a75e8ca2370a9d11ae6057d051ca6ce13f90..7649908d9c9341ad695626e0a22a085f2af302ef 100644
> --- a/gdb/symtab.c
> +++ b/gdb/symtab.c
> @@ -4760,7 +4760,7 @@ info_functions_command (const char *args, int from_tty)
> {
> std::string regexp;
> std::string t_regexp;
> - bool quiet;
> + bool quiet = false;
>
> while (args != NULL
> && extract_info_print_args (&args, &quiet, ®exp, &t_regexp))
>
prev parent reply other threads:[~2018-11-02 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 11:32 Matthew Malcomson
2018-11-02 13:31 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541165414.1844.1.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=Matthew.Malcomson@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).