From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92041 invoked by alias); 2 Nov 2018 13:31:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91481 invoked by uid 89); 2 Nov 2018 13:30:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=UD:be, rights X-HELO: mailsec117.isp.belgacom.be Received: from mailsec117.isp.belgacom.be (HELO mailsec117.isp.belgacom.be) (195.238.20.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Nov 2018 13:30:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1541165417; x=1572701417; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=kaEFDYiiWwLNleTSx8rFPDlr7hsvV4nBbeM+8LNhLU4=; b=mHykoa59QXJWft5CtqVICYpTFcuQcp88stJJy4iwep7NNE1NPupi5IUn UtFtCyeep3HjRcGCh/Mnb4VCUDae5w==; Received: from 110.212-243-81.adsl-dyn.isp.belgacom.be (HELO md) ([81.243.212.110]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 02 Nov 2018 14:30:14 +0100 Message-ID: <1541165414.1844.1.camel@skynet.be> Subject: Re: [Patch][gdb] Initialise quiet flag for "info functions" From: Philippe Waroquiers To: Matthew Malcomson , "gdb-patches@sourceware.org" , "palves@redhat.com" Cc: nd Date: Fri, 02 Nov 2018 13:31:00 -0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00022.txt.bz2 Thanks for the analysis and fix, I have pushed the below fix as obvious (and an equivalent fix in stack.c) as d54cfd762b06. Philippe On Fri, 2018-11-02 at 11:30 +0000, Matthew Malcomson wrote: > With this flag unset, using 'info functions' without a set quiet flag > was not deterministic and was causing some flaky test failures. > > Failures seen in (at least). > gdb.base/info_qt.exp > gdb.dwarf2/dw2-case-insensitive.exp > gdb.base/info-fun.exp > > Ok for trunk? > I don't have commit rights. > > gdb/ChangeLog: > > 2018-11-02 Matthew Malcomson > > * symtab.c (info_functions_command): Initialise quiet flag. > > > > ############### Attachment also inlined for ease of reply ############### > > > diff --git a/gdb/symtab.c b/gdb/symtab.c > index cd27a75e8ca2370a9d11ae6057d051ca6ce13f90..7649908d9c9341ad695626e0a22a085f2af302ef 100644 > --- a/gdb/symtab.c > +++ b/gdb/symtab.c > @@ -4760,7 +4760,7 @@ info_functions_command (const char *args, int from_tty) > { > std::string regexp; > std::string t_regexp; > - bool quiet; > + bool quiet = false; > > while (args != NULL > && extract_info_print_args (&args, &quiet, ®exp, &t_regexp)) >