From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic312-26.consmr.mail.ir2.yahoo.com (sonic312-26.consmr.mail.ir2.yahoo.com [77.238.178.97]) by sourceware.org (Postfix) with ESMTPS id DD0F43858C62 for ; Sat, 4 May 2024 16:28:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD0F43858C62 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DD0F43858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.178.97 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714840131; cv=none; b=oLKjuTXrmeATYhCMJNu7EVSLNHvkVgBS6rQZ+0574y1WIidNOjBDVHZwXsYblf+cNU8YOgiy7CnsKE8n7JB1O+juVQe+jEVqMC4IaQEXDhaT4ZR+QuXu915Br5l5IeOnrbCZBCb3GhyczRlao3z8QqbTIYKL2hYKoVpSJWKDkaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714840131; c=relaxed/simple; bh=aI8zsjdBwbwQ/4BbjQO5qXo7EYOeGeHBLNPnJ0hOce4=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=NjcFRl/TFh5AvuL4B0mViyp/L2UwYzl2r2bddx1n2+YgZ0oFSAHWB9a0joKZSl+MAsmSDkADJ2qxOjrT2Rt2cmR0shLMfOs3r+6YU4cnm6sqJkna2BWY0BRVPQJliul5ejebbQPq67rXeWycnjmyqM+l1v1ZuMkWTVTVJ4a3WmE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1714840127; bh=aI8zsjdBwbwQ/4BbjQO5qXo7EYOeGeHBLNPnJ0hOce4=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=jqrCVhahoLvs9inGzPmx6oerrvY4MRmH0OI9etLjIM2QU4xVVjX1mL2Lcx68fob+5zCxsJNKTIgY96EGcOVDTb3ixk1fPWILbqTo4LI+AqU1sjEqz4xT+ZfKluO8/SKo13+s38prjZACWFGAt1nZ/kVg5UQ3A9Osjeepv/Me2d/rs+z965Hu+4lOR+eoi+CIkj8Mu8go8R/MnRPZftRb04ig7n2DY2BxtYeXJmn1lPmYnGUj9W0EYwHGCOIPRLVK9vMbZr5F+znh30dgIP+fmyDBRLdCchgm/OboLxsd7ppdPUtY/p8mJwCmIQhIos358jec4qaEugX6dsHObVtjTQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1714840127; bh=zV2+L41Y9lLkdVNopJ2WCx+0U7iZ+XeNKJylTKxy4Xf=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=N70K4m5mO3GEXZZic8a7V9l5fFvQRJEjwcmuetZ9y2+Ee/2aU9NHVYww+i1e9T+CNmDee/5Vn3FaVFgqsrqqCXt6Vza6c3VqzkisNxP/rY9tfhp6Cy1FmyR2hpvwgWgMBZFjcpvuIkU3Z16AX2H/LFwJTRPfFiX04fG7Ta350G3LNzK5TVNN6M+HjSFDlIqKan+gVUXbLN0RUIJ4l7n7bIvPdLb+Dsjrza/VmU4KYZYYR2rLqdwScJNaLxVuJ1KPxUr215XquMsafNhhpcRROxx+FDeg9I13YdLVY0ex+fxyu+AvN0a8raEfGYOk85EOAa3P+5+d3LKPJP2r4UIrlg== X-YMail-OSG: rAR6eAkVM1k.jZyl8i_nQDB_nhSfI2KZ1JiWCFtKpK0kIE3iQiiOcBpyMSj9Heo Yk5ArPYx_0_s9zLpH4iGYf1a5UJ1_sAoa.tW05rad6PS562KPTzzbV15IvBDqZ1xYmIMjzNEYlUx 384Yy.msx4BIatedxYW5uuoa7BT7dtUggCrZ6u0kTV_KEA2AP9q246MEjki6hPMGBc5LBD_nLapZ 5zhsEQPMEEL6g.Gx_VqbOKBAbpEOi1_T3w4m.rnjKPWMxAprPYvHkwPY8bIJXbst2VsD7jb9jGIW dxDL1TbcBnFjD5terMHb292RXT0m0TUMLaGu6YZCvvwdNJuqqK0sJ.aHoDzAEAmbXMVN_0sv5E7x RnIOs13E2tB0WUIkTZP_SfN8DxCTBIf.WzH.37wg9BmzS62kJGV6scfiWUlE5Jq8FXsJHs5ZO8w0 gZpaGnX24rSq5.FIi5pYqiD_TD1t_Ey3c4MBT0KSfLmZLenJZTP1Ej3magC3Uv5YAKDDP43OQDM7 aqkHeLBUrmI6Sb1FLXL2I5Qre_yR_JPowvqCkfHr9imxj1YNxjWmC6Bi5j9_7n2ScRSRDb0gZce_ YdmGIRt3MOjxTu6zfyRgPP9AK4e8f0Dx3095iI0Ik2G3CQddz2BtR3kTZBqg7mQLUUYeIGftz9Jc GjnMyKW6bqfWQf9OHGKjgJJEb_jywmCA4aOHjypuiI6LKSrG9o5.19AXgM58GpVLErxMMp._cQ1Z Lvt_M5oNkHIEhEKx7EvnXUfubkAmsVYX8CSzr8FAcTN5MyvfKWLUUbTs.Ca83I9V0t3fe14NHcya WCObOsM8D.TaUNBaZ77arSYJ.w6hJGJ0urCa12LkfsFqYsruCFXGGvkdS_qzesp0XEzCuxZEB93y XvdhnOrM6MJ63LOqBm5sEBuRUvWdX26vH0EboZn0bwkZCtj7ABg9KOcQ4Tm7fIOyxt9M0sCrC3q0 TuManJ8dP8nOBVEtwoMfo.BNAHKY_yVtSW9qmrdoRDSZzQqDQWV7ljGuMYXegiWi9l_NoBe0o0UA CG_Sx5uMNRFxMax2M78ITDGQfuZzVVEwGJwY6bq1RvKJ3glYzKSk3AuxtjKOgy2ZphzCs.B2MxSI N69kmYvzfckjYUFfpQfgpc_WK.g84mFPJOi7ocLU4WQE0hkmLblizRAik354tjZrtwjC1rLh7Kpa cJ8lAms1XlUP5wPyWz4bp2OfO15zUMFxjGbgHNKQjyFfKt4P34W2JDeK6ykhW0BS0lkpxDYe1mkV QjRJssk9jg9uKg0TchPElobFgijTwkRsTxbwxBH5SnOlq2Hr7Zptr4A_wRsUn.xcyMTpV_Z8AL6g b0x_8pObmmGZt4etDRGd3fcM4EjajtcdHDiWjn8lyeouam.Y.6YLXmFqc8KWgbNjqq.g_aJMe6rp IdY94ei1.dX_X7H3ybRGvzrUWeyb48_Re0npTv2M2nry2WexppkJgJpJgcortqJUXUURh_liK6h3 svMbtrmG9ZLWBEFqCwUmgp16PklrQhsp3u.Q.Q3QzYl.YHvi_3V6Oay9Q1JNGhAKYJq5Ni1WLFKg 5KZCBaUVRzY2VSUi9mc8hMBfFGV5z.cx0Tfu.ZivpR4NYXuEfbEw7IjlBVeRXoC5duxGlaDNWsVx kBXby_fCiOMcVipPhB3ikOceyoQefuxzP1FVEj5JhhZl4hdTHl6F0RRMNrFOb8LtpjclWvfhQhqv dGt3knH8pOCyB2MJvWMKCfmxc2GLoD.BhLCJYVENYuTXH2pkLrKllp1YorDN1EhaJjxUGyhpAWfq zI1gfP6Z_6Jrdfbcj974QRCg84MKUX9oskswHUXmGQE7NhRWBFMY7TtKbFhTl9MRyRy9cL5m_aWm qMKfGYA8s__Dv7wBVIFALP7DR2iiwWht_LzTTQ3XRNbFqyFgBbECOk.Up5o8.YZEfH8vkC_r0_mE PI.erEuwrcTAHbjwkH6qhR9QEpEURw.yUALvUtYf7cr3z90suS3pUEsRa90kM0ldGj_yMfmz5SGD 7fc4jhizPoXfK0oy7WJarAsX4xW.ySj81MVgC5FVnQ8x1DYwKfttZfB_gVb9BBhBP3k0qjvaiDlE swNgad33vxYJbxfYtPh1KjzNyAj5TCPkif8OiGMAWqXMuysfQ0GS2PFLZrt68x5g5iYDRrPxXyvT oC_t4GqLgU18MgYDxXAAZeZjMMkIPqD0gbaHxviSucANQwSjLSlQeGfDskbcNrmjyVscGI0gGU59 UD3fS1vIIaECcOA-- X-Sonic-MF: X-Sonic-ID: ade0df9b-0f73-4924-80fc-4ad1a9e93156 Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Sat, 4 May 2024 16:28:47 +0000 Date: Sat, 4 May 2024 16:28:45 +0000 (UTC) From: Hannes Domani To: Tom Tromey Cc: "gdb-patches@sourceware.org" Message-ID: <1542693138.10823446.1714840125123@mail.yahoo.com> In-Reply-To: <878r0p1szk.fsf@tromey.com> References: <20240504110942.922-1-ssbssa.ref@yahoo.de> <20240504110942.922-1-ssbssa@yahoo.de> <878r0p1szk.fsf@tromey.com> Subject: Re: [PATCH] Fix heap-use-after-free in index-cached with --disable-threading MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.22256 YMailNorrin X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Samstag, 4. Mai 2024 um 17:45:06 MESZ hat Tom Tromey F= olgendes geschrieben: > >>>>> "Hannes" =3D=3D Hannes Domani writes: > > Hannes>=C2=A0 #else > Hannes>=C2=A0=C2=A0=C2=A0 /* Without threads, all the work is done immedi= ately on the main > Hannes>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 thread, and there is never anything= to wait for.=C2=A0 */ > Hannes> -=C2=A0 done =3D true; > Hannes> +=C2=A0 done =3D desired_state =3D=3D cooked_state::CACHE_DONE; > Hannes>=C2=A0 #endif /* CXX_STD_THREAD */ > > I wouldn't mind if this code were lowered out of the #if, like: > > >=C2=A0=C2=A0=C2=A0=C2=A0 #endif /* CXX_STD_THREAD */ > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool done =3D ... > > However I think it's also fine as-is and can be tidied up later if > anyone cares to. Note that there is a small difference between them: #if CXX_STD_THREAD =C2=A0 done =3D m_state =3D=3D cooked_state::CACHE_DONE; #else =C2=A0 done =3D desired_state =3D=3D cooked_state::CACHE_DONE; #endif Though I wonder if not both could check for desired_state. Hannes