From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search)
Date: Sun, 02 Dec 2018 16:57:00 -0000 [thread overview]
Message-ID: <1543769832.10519.2.camel@skynet.be> (raw)
In-Reply-To: <6e8a2a00-bcbd-cdc6-f332-f59988bb8c40@redhat.com>
On Fri, 2018-11-30 at 19:43 +0000, Pedro Alves wrote:
> I looked a little and found that we do indeed have tests, however
> they test using the "search" alias, instead of "forward-search",
> which made them invisible to greps for the latter.
>
> I also noticed a couple other things... See the patch below. WDYT?
Looks much better than the previous code, and as expected, no
leaks there ...
So, FWIW, patch looks good to me ...
Philippe
prev parent reply other threads:[~2018-12-02 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 23:34 [RFA] Fix leak in forward-search Philippe Waroquiers
2018-11-29 15:42 ` Pedro Alves
2018-11-29 23:05 ` Philippe Waroquiers
2018-11-30 19:43 ` [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search) Pedro Alves
2018-11-30 20:42 ` Tom Tromey
2018-12-08 15:12 ` Pedro Alves
2018-12-02 16:57 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543769832.10519.2.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).