From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Pedro Alves <palves@redhat.com>,
Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA] Factorize killing the children in linux-ptrace.c, and fix a 'process leak'.
Date: Sun, 16 Dec 2018 20:27:00 -0000 [thread overview]
Message-ID: <1544992064.24304.11.camel@skynet.be> (raw)
In-Reply-To: <1d75a834a31293c79f8ffb6188a059d6@polymtl.ca>
On Fri, 2018-12-14 at 18:39 -0500, Simon Marchi wrote:
>
> Not sure if you got that far in your archeology, but here is the
> discussion about it:
>
> https://sourceware.org/ml/archer/2011-q1/msg00102.html
>
> which is a reply to:
>
> https://sourceware.org/ml/archer/2010-q3/msg00209.html
>
> Realistically, we could probably just get rid of using PTRACE_KILL.
>
> Please push the patch. I think it's totally fine to do one small step
> at the time. As you said, it's already a significant improvement.
>
> Simon
Thanks for the review, I have pushed the patch, and added on my
list of things to do (one day) to work on a bigger cleanup.
Philippe
prev parent reply other threads:[~2018-12-16 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 20:19 Philippe Waroquiers
2018-11-09 22:22 ` Simon Marchi
2018-11-10 18:29 ` Pedro Alves
2018-11-11 17:24 ` Philippe Waroquiers
2018-11-25 23:13 ` Philippe Waroquiers
2018-12-10 20:46 ` PING^2 " Philippe Waroquiers
2018-12-14 23:39 ` Simon Marchi
2018-12-16 20:27 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544992064.24304.11.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).