From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63863 invoked by alias); 3 Jan 2019 13:18:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63850 invoked by uid 89); 3 Jan 2019 13:18:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:AES256-, HContent-Transfer-Encoding:8bit X-HELO: mailsec113.isp.belgacom.be Received: from mailsec113.isp.belgacom.be (HELO mailsec113.isp.belgacom.be) (195.238.20.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Jan 2019 13:18:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1546521504; x=1578057504; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=lIZZAkHcC+CShRT7uDrrhRr9tqRikWNMEXaPJ+XYbqY=; b=wl1Sz9b7a7N6tBro7ryu2RlT4vu65VUzRrAp2iPkyR7KwP5+fvakLovR oTyePDFlemIFF4uZTK9FfkyMTPoAzg==; Received: from 184.205-67-87.adsl-dyn.isp.belgacom.be (HELO md) ([87.67.205.184]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 03 Jan 2019 14:18:20 +0100 Message-ID: <1546521500.1926.9.camel@skynet.be> Subject: Re: [PATCH] C++-ify struct thread_fsm From: Philippe Waroquiers To: Tom Tromey , gdb-patches@sourceware.org Date: Thu, 03 Jan 2019 13:18:00 -0000 In-Reply-To: <20190102232806.14123-1-tom@tromey.com> References: <20190102232806.14123-1-tom@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00060.txt.bz2 I have scanned the patch. FWIW, that all looks nice to me. A minor comment below, on something that was there before the patch. Thanks Philippe On Wed, 2019-01-02 at 16:28 -0700, Tom Tromey wrote: > This C++-ifies struct thread_fsm, replacing the "ops" structure with > virtual methods, and changing all the implementations to derive from > thread_fsm. SNIP > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index d54d496972..ffbec7001a 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -10967,106 +10967,66 @@ awatch_command (const char *arg, int from_tty) > in infcmd.c. Here because it uses the mechanisms of > breakpoints. */ > > -struct until_break_fsm > +struct until_break_fsm : public thread_fsm > { > - /* The base class. */ > - struct thread_fsm thread_fsm; > - > /* The thread that as current when the command was executed. */ >    int thread; This comment looks strange; maybe 'that was' ?