From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Tom Tromey <tom@tromey.com>
Cc: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp
Date: Tue, 05 Feb 2019 19:55:00 -0000 [thread overview]
Message-ID: <1549396534.2630.23.camel@skynet.be> (raw)
In-Reply-To: <875ztypcs3.fsf@tromey.com>
On Tue, 2019-02-05 at 06:47 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
>
> Philippe> The below change was discussed with Tom on irc.
> Philippe> Tom pushed a first fix in the splay tree, so it would be easier
> Philippe> for me if he (or someone else) could also push this one.
>
> Did you send them to gcc-patches?
> If so and they were approved, let me know and I will commit them
> (though maybe not until Monday, depending).
> If not, let me know, and I can forward the note, etc.
No, I did not send it.
It would be really nice if you could take that in charge.
Also, there is a leak related to macro definition
(but not in splay tree), for which there is a patch series:
[RFAv3 0/2] Fix leaks in macro definition
https://sourceware.org/ml/gdb-patches/2019-01/msg00567.html
This series is still to be reviewed.
Thanks
Philippe
next prev parent reply other threads:[~2019-02-05 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 22:34 Philippe Waroquiers
2019-02-03 17:45 ` Kevin Buettner
2019-02-03 17:58 ` Philippe Waroquiers
2019-02-05 13:48 ` Tom Tromey
2019-02-05 19:55 ` Philippe Waroquiers [this message]
2019-02-06 14:23 ` Tom Tromey
2019-02-12 13:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549396534.2630.23.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).