From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38738 invoked by alias); 12 Feb 2019 18:41:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38729 invoked by uid 89); 12 Feb 2019 18:41:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=his X-HELO: mailsec116.isp.belgacom.be Received: from mailsec116.isp.belgacom.be (HELO mailsec116.isp.belgacom.be) (195.238.20.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Feb 2019 18:41:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1549996912; x=1581532912; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=waZyFrEnWKuzZIA+ULpv4S7j96UWGnKNWBOY+ZRVt9A=; b=04IbcsjhtFHYvGHiJRLCr9vtqp0JuEc8eWq+NMz9tu4+fn3SyES1jcrI w7B4KFbYmOvZAKdDteqzW0lFB5rxHA==; Received: from unknown (HELO md) ([109.130.122.147]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 12 Feb 2019 19:41:50 +0100 Message-ID: <1549996909.1438.7.camel@skynet.be> Subject: Re: [RFAv2 3/3] Make symtab.c better styled. From: Philippe Waroquiers To: Pedro Alves , Ulrich Weigand , Joel Brobecker Cc: gdb-patches@sourceware.org Date: Tue, 12 Feb 2019 18:41:00 -0000 In-Reply-To: References: <20190212145443.E2799D8028D@oc3748833570.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00160.txt.bz2 On Tue, 2019-02-12 at 15:53 +0000, Pedro Alves wrote: > On 02/12/2019 02:54 PM, Ulrich Weigand wrote: > > Pedro Alves wrote: > > > > > So the question becomes a simple cosmetic one. In this case: > > > > > > > (gdb) info variables > > > > [...] > > > > Non-debugging symbols: > > > > 0x0000000010020088 main > > > > > > Should "main" be printed with function style, or variable style. > > > This basically affects the color used to print the symbol. > > > > > > In Philippe's patch, we'd print it in variable style. If we used > > > msymbol_is_function instead of his "is text symbol" check, we'd > > > print it in function style. > > > > Ah, I see. I guess that doesn't really matter that much at this > > point. Since we're already showing it under "variables" we might > > as well use the variable style. But in the end either way would > > be fine with me ... > > OK, in that case, let's just use with Philippe already has. Thanks for the review and discussion. With all this + the feedback of Joel (in https://sourceware.org/ml/gdb-patches/2019-01/msg00560.html that confirmed that the ada-lang.c code will effectively use function style only to style function names), I am assuming I can push the series (I will retest before that). Thanks Philippe