From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90935 invoked by alias); 22 Jun 2019 10:30:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90919 invoked by uid 89); 22 Jun 2019 10:30:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=Usage, UD:be, Elis, elis X-HELO: mailsec107.isp.belgacom.be Received: from mailsec107.isp.belgacom.be (HELO mailsec107.isp.belgacom.be) (195.238.20.103) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Jun 2019 10:30:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1561199440; x=1592735440; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=6AbYsFuocLoJw2T5nSi36n6ReYI4KGXpupmKzgvBzNQ=; b=ewthvLg751Z+FZKT7XZoDy5RgY6B64eANgMs0SITqwp8Rh+ohWnwySs3 t5KjpWDHIJS3JvwZiqJRn8YYegX3YQ==; Received: from 96.218-128-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.128.218.96]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 22 Jun 2019 12:30:38 +0200 Message-ID: <1561199437.1556.1.camel@skynet.be> Subject: Re: [PATCH v2.1] Introduce the "with" command From: Philippe Waroquiers To: Pedro Alves , Eli Zaretskii Cc: gdb-patches@sourceware.org Date: Sat, 22 Jun 2019 10:30:00 -0000 In-Reply-To: <918fb7a7-4c62-68cd-006a-8d213b26d571@redhat.com> References: <20190618003902.19805-1-palves@redhat.com> <20190618003902.19805-5-palves@redhat.com> <83sgs6sv44.fsf@gnu.org> <3e69e8c9-9025-90ec-e6f6-73e04bd22360@redhat.com> <83lfxxqzy5.fsf@gnu.org> <918fb7a7-4c62-68cd-006a-8d213b26d571@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00451.txt.bz2 On Wed, 2019-06-19 at 18:20 +0100, Pedro Alves wrote: > Here's the updated full patch that incorporates the changes addressing > both Eli's and Philippe's comments. I quickly re-read the patch and did some trials. Two small remarks: * The tests related to "maint with" are failing. It looks like this patch misses the change "maint test-settings" to "maint set|show test-settings". * Maybe it would be worth expanding slightly the on-line help? What about: (gdb) help with Temporarily set SETTING to VALUE, run COMMAND, and restore SETTING. Usage: with SETTING [VALUE] [-- COMMAND] Usage: w SETTING [VALUE] [-- COMMAND] With no COMMAND, repeats the last executed command. SETTING is any setting you can change with the "set" subcommands. Examples:   with language pascal -- print obj   with print elements unlimited -- print obj    Multiple settings can be changed using nested with, and abbreviations can be used for commands and/or values. Example:   w la p -- w p el u -- p obj (gdb)  Thanks Philippe