From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10155 invoked by alias); 17 Oct 2018 18:47:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10031 invoked by uid 89); 17 Oct 2018 18:47:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=ssize_t, jhbFreeBSDorg, paul's, D*FreeBSD.org X-HELO: resqmta-po-08v.sys.comcast.net Received: from resqmta-po-08v.sys.comcast.net (HELO resqmta-po-08v.sys.comcast.net) (96.114.154.167) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Oct 2018 18:47:46 +0000 Received: from resomta-po-02v.sys.comcast.net ([96.114.154.226]) by resqmta-po-08v.sys.comcast.net with ESMTP id CmmtgwPeRAzjVCqrAgT1Bk; Wed, 17 Oct 2018 18:47:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1539802064; bh=CfpBrOvdaOBFgUNbp47ZLAPM5w0QynYJ/sIOBy7J9rM=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To; b=IK9Nph0FWJRGCuCAMRd3FcDYtW7BUH7hkd7e81f+gpg57mFTmgZTXJGPv/7r0SZd2 aDRrUvfPQhEgPMZbagP1Jg5VhIeB8COddh01HjWZAOefDenZwPQ/YoLxTBrd5OqEZk pwIy7Xj04LWn10rxBKjM70/qN119yz0BTUMGGZNBPJgafP2tgzT47KxtA08kA1c42/ GrhPBFaJZEkBqi2b3ALZXvUt4ojvOFIgmaDs9pw/Uy7CZ2wZ9wXzP+ekNx3h4MAMJN WEhqAeB90aQwqR2fawde8QCdXNXBoFDA6qiTMdxHfdHm0xyCj2pMwZGBFUN+j9u45i nTVtRSS2/6YbQ== Received: from [192.168.10.125] ([73.60.223.101]) by resomta-po-02v.sys.comcast.net with ESMTPSA id Cqr9gNjJZ1cYZCqrAgbaTp; Wed, 17 Oct 2018 18:47:44 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH][gdb] fix unsigned overflow in charset.c From: Paul Koning In-Reply-To: <31fcba01-1f2c-d932-94f2-69b7cb14601a@FreeBSD.org> Date: Wed, 17 Oct 2018 18:47:00 -0000 Cc: Pedro Alves , gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <15814BE7-1C4F-4067-99A5-A004D094FB96@comcast.net> References: <7B48D309-445E-4141-A87A-1F3D5FA70EFD@comcast.net> <1acace4a-a5c6-abaf-f070-9c2e6768b6f2@redhat.com> <9ea7a1f6-5c3f-c569-6bba-ca9e21711de1@FreeBSD.org> <2DCE0AB8-5647-4AD1-B0AA-3A8350C3BE6D@comcast.net> <17fcbb42-d694-af87-9a8d-d01addee992b@FreeBSD.org> <42e6b4b2-fb05-25f6-ef0a-73ce854116de@redhat.com> <31fcba01-1f2c-d932-94f2-69b7cb14601a@FreeBSD.org> To: John Baldwin X-SW-Source: 2018-10/txt/msg00383.txt.bz2 > On Oct 17, 2018, at 2:38 PM, John Baldwin wrote: >=20 >> ... >> From an aesthetic perspective, "ssize_t" seems better, as the "obvious >> signed version of size_t". From a pedantic perspective, ptrdiff_t >> sounds better. >=20 > Ok, I think ssize_t is probably fine, so I Think Paul's original patch is > ok? >=20 > --=20 > John Baldwin Please let me know; I can commit that patch if it is approved. Or commit w= ith changes if that's desired. paul