public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [OB PATCH] Fix file-not-found error with clang in gdb.arch/i386-{avx, sse}.c
@ 2020-05-29 16:16 Gary Benson
  0 siblings, 0 replies; only message in thread
From: Gary Benson @ 2020-05-29 16:16 UTC (permalink / raw)
  To: gdb-patches

Clang fails to compile two testcases with the following error:
  fatal error: 'nat/x86-cpuid.h' file not found

This prevents the following testcases from executing:
  gdb.arch/i386-avx.exp
  gdb.arch/i386-sse.exp

Both testcases set additional_flags when building with GCC.
This commit causes the additional_flags to also be used when
building with clang.  Note that, while fixing the build, this
commit reveals several new failures when using clang to build
the testsuite.

gdb/testsuite/ChangeLog:

	* gdb.arch/i386-avx.exp (additional_flags): Also set when
	building with clang.
	* gdb.arch/i386-sse.exp (additional_flags): Likewise.
---
 gdb/testsuite/ChangeLog             | 6 ++++++
 gdb/testsuite/gdb.arch/i386-avx.exp | 2 +-
 gdb/testsuite/gdb.arch/i386-sse.exp | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.arch/i386-avx.exp b/gdb/testsuite/gdb.arch/i386-avx.exp
index c52586d..ad7bf02 100644
--- a/gdb/testsuite/gdb.arch/i386-avx.exp
+++ b/gdb/testsuite/gdb.arch/i386-avx.exp
@@ -31,7 +31,7 @@ if [get_compiler_info] {
 }
 
 set additional_flags ""
-if [test_compiler_info gcc*] {
+if { [test_compiler_info gcc*] || [test_compiler_info clang*] } {
     set additional_flags "additional_flags=-mavx -I${srcdir}/.."
 }
 
diff --git a/gdb/testsuite/gdb.arch/i386-sse.exp b/gdb/testsuite/gdb.arch/i386-sse.exp
index 1fd7cab..75cbfa5 100644
--- a/gdb/testsuite/gdb.arch/i386-sse.exp
+++ b/gdb/testsuite/gdb.arch/i386-sse.exp
@@ -31,7 +31,7 @@ if [get_compiler_info] {
 }
 
 set additional_flags ""
-if [test_compiler_info gcc*] {
+if { [test_compiler_info gcc*] || [test_compiler_info clang*] } {
     set additional_flags "additional_flags=-msse -I${srcdir}/.."
 }
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-29 16:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-29 16:16 [OB PATCH] Fix file-not-found error with clang in gdb.arch/i386-{avx, sse}.c Gary Benson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).