From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Subject: [OB PATCH] Fix build errors in with clang in gdb.compile/compile-cplus.c
Date: Fri, 29 May 2020 17:43:54 +0100 [thread overview]
Message-ID: <1590770634-26360-1-git-send-email-gbenson@redhat.com> (raw)
Clang fails to compile the file, with the following error:
fatal error: 'iostream' file not found
This prevents the following testcase from executing:
gdb.compile/compile-cplus.exp
The testcase sets additional_flags when building with GCC, which
this commit causes to also be set when building with clang. This
makes the testcase fail to build with a different error:
warning: treating 'c' input as 'c++' when in C++ mode, this behavior
is deprecated [-Wdeprecated]
so this commit adds -Wno-deprecated in two places to sidestep this.
Note that, while allowing the testcase to build, this commit reveals
failures when the testsuite is built using clang.
gdb/testsuite/ChangeLog:
* gdb.compile/compile-cplus.exp (additional_flags): Also
set when building with clang.
(additional_flags, srcfilesoptions): Pass -Wno-deprecated
when building with clang.
---
gdb/testsuite/ChangeLog | 7 +++++++
gdb/testsuite/gdb.compile/compile-cplus.exp | 15 +++++++++++++--
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.compile/compile-cplus.exp b/gdb/testsuite/gdb.compile/compile-cplus.exp
index cca5b20..85b2f20 100644
--- a/gdb/testsuite/gdb.compile/compile-cplus.exp
+++ b/gdb/testsuite/gdb.compile/compile-cplus.exp
@@ -19,11 +19,16 @@ standard_testfile .c compile-shlib.c compile-constvar.S compile-nodebug.c
get_compiler_info
set options {}
-if [test_compiler_info gcc*] {
+if { [test_compiler_info gcc*] || [test_compiler_info clang*] } {
lappend options additional_flags=-g3
lappend options additional_flags=-std=gnu++11
lappend options c++
}
+if [test_compiler_info clang*] {
+ # Treating C input as C++ is deprecated in Clang, so
+ # the build will fail without disabling -Wdeprecated.
+ lappend options additional_flags=-Wno-deprecated
+}
if { ![istarget x86_64-*-* ] || ![is_lp64_target] } {
verbose "Skipping x86_64 LOC_CONST test."
@@ -34,7 +39,13 @@ set srcfilesoptions [list ${srcfile} ${options}]
if { $srcfile3 != "" } {
lappend srcfilesoptions $srcfile3 ${options}
}
-lappend srcfilesoptions $srcfile4 "nodebug c++"
+set srcfile4options "nodebug c++"
+if [test_compiler_info clang*] {
+ # Treating C input as C++ is deprecated in Clang, so
+ # the build will fail without disabling -Wdeprecated.
+ set srcfile4options "$srcfile4options additional_flags=-Wno-deprecated"
+}
+lappend srcfilesoptions $srcfile4 $srcfile4options
if { [eval build_executable_from_specs ${testfile}.exp $testfile {$options} ${srcfilesoptions}] } {
return -1
}
--
1.8.3.1
next reply other threads:[~2020-05-29 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 16:43 Gary Benson [this message]
2020-05-29 21:12 ` Pedro Alves
2020-06-19 13:49 ` Gary Benson
2020-06-19 15:42 ` [PATCH] W/ Clang, compile/link C++ test programs with "-x c++" Pedro Alves
2020-06-24 22:30 ` Pedro Alves
2020-07-02 9:58 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590770634-26360-1-git-send-email-gbenson@redhat.com \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).