From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-132261-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20852 invoked by alias); 24 Jun 2016 19:28:30 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20797 invoked by uid 89); 24 Jun 2016 19:28:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:662
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 24 Jun 2016 19:28:27 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 8E3D5C057EC9;	Fri, 24 Jun 2016 19:28:26 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5OJSPeV025978;	Fri, 24 Jun 2016 15:28:25 -0400
Subject: Re: [PATCH v4 3/3] Fix failure to detach if process exits while detaching on Linux
To: Yao Qi <qiyaoltc@gmail.com>
References: <1466119968-15171-1-git-send-email-palves@redhat.com> <1466119968-15171-4-git-send-email-palves@redhat.com> <86k2hnsvk0.fsf@gmail.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <15ac6760-0c08-09a6-38a3-6a124ee2731f@redhat.com>
Date: Fri, 24 Jun 2016 19:28:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <86k2hnsvk0.fsf@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-06/txt/msg00405.txt.bz2

On 06/17/2016 04:07 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> +# If testing single-process, simply detach from the process.
>> +#
>> +# If testing multi-process, first detach from the child, then detach
>> +# from the parent and confirm that the parent exits, thus unsuring
> 
> s/unsuring/ensuring/ ?

Indeed.

>> +	} else {
>> +	    perror "unhandled command: $mode: $cmd"
> 
> no variable "mode".

Whoops, there used to be one.  Fixed now (the two instances):

-           perror "unhandled command: $mode: $cmd"
+           perror "unhandled command: $cmd"

Thanks,
Pedro Alves