From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 00/10] Remove some cleanups from linespec.c
Date: Mon, 02 Apr 2018 02:44:00 -0000 [thread overview]
Message-ID: <15b84c9d-195b-3f35-9007-d7e990b9bd72@simark.ca> (raw)
In-Reply-To: <20180401163539.15314-1-tom@tromey.com>
On 2018-04-01 12:35 PM, Tom Tromey wrote:
> This series removes many (but not all) cleanups from linespec.c.
> Generally the removals are done in the normal way: replacing manual
> memory management with a self-managing data structure.
>
> I've tried to make each patch relatively small to make them simpler to
> review.
>
> In a few cases the patch required changes outside of linespec.c.
>
> A couple of the patches (at least #2 and #10) are obvious, though of
> course it doesn't hurt to read them anyhow.
>
> Regression tested by the buildbot. I've also built each patch in the
> series locally and run it through the gdb.linespec tests, while I was
> tracking down the failures described in patch #7 (though of course the
> series has changed slightly since then).
>
> Tom
>
Hi Tom,
The patches I haven't commented on LGTM.
Thanks!
Simon
next prev parent reply other threads:[~2018-04-02 2:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 16:35 Tom Tromey
2018-04-01 16:35 ` [RFA 09/10] Remove typep and VEC(typep) " Tom Tromey
2018-04-01 16:35 ` [RFA 02/10] Fix some indentation in linespec.c Tom Tromey
2018-04-02 1:49 ` Simon Marchi
2018-04-01 16:35 ` [RFA 06/10] Remove a string copy from event_location_to_sals Tom Tromey
2018-04-01 16:35 ` [RFA 05/10] Have filter_results take a std::vector Tom Tromey
2018-04-01 16:35 ` [RFA 01/10] Remove some cleanups from search_minsyms_for_name Tom Tromey
2018-04-02 1:39 ` Simon Marchi
2018-04-01 16:35 ` [RFA 10/10] Remove unnecessary include from linespec.h Tom Tromey
2018-04-01 16:35 ` [RFA 08/10] More use of std::vector in linespec.c Tom Tromey
2018-04-02 2:35 ` Simon Marchi
2018-04-01 16:35 ` [RFA 04/10] Return std::string from canonical_to_fullform Tom Tromey
2018-04-02 2:15 ` Simon Marchi
2018-04-01 16:35 ` [RFA 07/10] Change streq to return bool Tom Tromey
2018-04-02 2:28 ` Simon Marchi
2018-04-01 16:35 ` [RFA 03/10] Make copy_token_string return unique_xmalloc_ptr Tom Tromey
2018-04-02 2:44 ` Simon Marchi [this message]
2018-04-03 22:31 ` [RFA 00/10] Remove some cleanups from linespec.c Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15b84c9d-195b-3f35-9007-d7e990b9bd72@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).