From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb/testsuite: add simavr.exp board
Date: Mon, 25 May 2020 11:57:43 -0400 [thread overview]
Message-ID: <15f6fd7e-9210-5b3c-09b5-e68699897c47@polymtl.ca> (raw)
In-Reply-To: <cc0be8c5-41b2-6c4f-6cf9-ae00cb00d105@redhat.com>
On 2020-05-25 10:44 a.m., Pedro Alves wrote:
>> Here's the patch with that fixed:
>
> Don't you want to handle timeout (and maybe unexpected output) in
> the new gdb_expect call?
It's a good idea to add a timeout. I added this line:
timeout { error "unable to connect to simavr stub" }
If for some reason we can't connect (I tested it by purposely expecting the wrong string),
it will throw and abort the test promptly with an error. Without the timeout, the test
continues pointlessly and it takes ages because we wait for many tests to time out.
> Regardless, this LGTM. It doesn't impact anything else and can always be
> improved afterwards.
Thanks, I pushed the series with that fixed. If you find anything else to improve, don't
hesitate to suggest it, I can fix it up later.
Simon
prev parent reply other threads:[~2020-05-25 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 14:20 Simon Marchi
2020-05-24 14:20 ` [PATCH 2/2] gdb: make avr_integer_to_address generate code or data address based on type Simon Marchi
2020-05-24 16:36 ` Pedro Alves
2020-05-24 16:33 ` [PATCH 1/2] gdb/testsuite: add simavr.exp board Pedro Alves
2020-05-25 13:29 ` Simon Marchi
2020-05-25 14:44 ` Pedro Alves
2020-05-25 15:57 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15f6fd7e-9210-5b3c-09b5-e68699897c47@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).