From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 70B85388A824 for ; Mon, 25 May 2020 15:57:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70B85388A824 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 04PFvidq015443 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 May 2020 11:57:49 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 04PFvidq015443 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 052B51E5F9; Mon, 25 May 2020 11:57:43 -0400 (EDT) Subject: Re: [PATCH 1/2] gdb/testsuite: add simavr.exp board To: Pedro Alves , gdb-patches@sourceware.org References: <20200524142040.209234-1-simon.marchi@polymtl.ca> <372695e3-7298-5c84-c009-6e41ca953d9f@redhat.com> <25976d2f-2071-49cc-c503-7408e254d06b@polymtl.ca> From: Simon Marchi Message-ID: <15f6fd7e-9210-5b3c-09b5-e68699897c47@polymtl.ca> Date: Mon, 25 May 2020 11:57:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 25 May 2020 15:57:44 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 15:57:52 -0000 On 2020-05-25 10:44 a.m., Pedro Alves wrote: >> Here's the patch with that fixed: > > Don't you want to handle timeout (and maybe unexpected output) in > the new gdb_expect call? It's a good idea to add a timeout. I added this line: timeout { error "unable to connect to simavr stub" } If for some reason we can't connect (I tested it by purposely expecting the wrong string), it will throw and abort the test promptly with an error. Without the timeout, the test continues pointlessly and it takes ages because we wait for many tests to time out. > Regardless, this LGTM. It doesn't impact anything else and can always be > improved afterwards. Thanks, I pushed the series with that fixed. If you find anything else to improve, don't hesitate to suggest it, I can fix it up later. Simon