Re: [PATCH] Fix reinterpret_cast for classes with multiple inheritance

[Hannes Domani <ssbssa@yahoo.de>]

 Am Mittwoch, 20. März 2024 um 17:57:50 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:

> >>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
>
> Hannes> Currently a reinterpret_cast may change the pointer value if
> Hannes> multiple inheritance is involved:
>
> Thanks for the patch.
>
> Hannes> +  else if (dest_code == TYPE_CODE_PTR && arg_code == TYPE_CODE_PTR)
> Hannes> +    {
> Hannes> +      /* Don't do any up- or downcasting.  */
> Hannes> +      result = arg->copy ();
> Hannes> +      result->deprecated_set_type (dest_type);
> Hannes> +      result->set_enclosing_type (dest_type);
> Hannes> +      result->set_pointed_to_offset (0);    /* pai: chk_val */
>
> I don't think anybody knows what this comment means in the other spots
> it appears.  I guess "pai" is some gdb maintainer from the distant past,
> though I don't know their real name.
>
> Anyway, please remove this comment.
>
> Ok with this change.
> Approved-By: Tom Tromey <tom@tromey.com>

Pushed with this change, thanks.


Hannes