From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2079.outbound.protection.outlook.com [40.107.6.79]) by sourceware.org (Postfix) with ESMTPS id 7C7D0385F369 for ; Tue, 31 Jan 2023 14:31:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C7D0385F369 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UQ1YVPBxBcbTo6qbznpy03jOw0qULW58LKqR6lOwS6E=; b=ypbOhy4txWaEF7uSNShjtv3rWDFbfTbxkb2tldm6d0a7LMxzTLS2g8vUXnfB/u3w054et+glJHUk3kfcLEi9bPfvq/GkfDNmq581NjWzoor0ARnoUQhZDmCk/fwO6r9/O6j2vU4SL3JHab9RTB4YN92shCttQ6TAxUAiwisQ+Ck= Received: from AM0PR01CA0079.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::20) by AS8PR08MB6422.eurprd08.prod.outlook.com (2603:10a6:20b:33b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Tue, 31 Jan 2023 13:57:46 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:10e:cafe::ed) by AM0PR01CA0079.outlook.office365.com (2603:10a6:208:10e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend Transport; Tue, 31 Jan 2023 13:57:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Tue, 31 Jan 2023 13:57:46 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Tue, 31 Jan 2023 13:57:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 73882033aea43d4f X-CR-MTA-TID: 64aa7808 Received: from 13ae3720f8dd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5A0970CD-0DD8-4C9A-8B9F-253FF44F394E.1; Tue, 31 Jan 2023 13:57:38 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 13ae3720f8dd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 Jan 2023 13:57:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JypVsGiHDIj7cRyrO65pE/DmnJb0nkcmd2HdILLAJ1THNUXkKAkQQn0lcZqzsSDgf8eFUG2Wi2VGZ6nkeixvEtT09dFnZKb/5loMtiw8XYMKPZbr2ptCOkC5hSjvcH9uZteGCRdi+6EZ1QZr3yB3KiChxvG9d4X2RMWlOLKjrhPYIrWMD8gchLhExb8EbduTlEp4OHw6uQwdoF0iBK/OFDzR7w1pkV00jfjvFEdykYKTx3WWIotP5vFcauOAXGl2/ToinD/lsn8ZuqQRcSxwxjgVDiupW8nWinW8SvGOzJ6453mx6+51b75zO+hjPUzF9S5v9gCDTh++KVmuUjof7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UQ1YVPBxBcbTo6qbznpy03jOw0qULW58LKqR6lOwS6E=; b=Qz3s0UDhl04xFH5UFm903rHD2UTXXkh78QqccwSs75KDmYPLSvvnjU19w05jSVINDDzB2BF9GQuqlMj6jCoIqXsOAzJ9nt1yfogO2lrnKYiqOcyXkEdWqNT3o5niK+58k7d2nhDF9oE82eJvL9lR6DqaDOTI1lru+eWQRpizrnI+g4X74QknUITdYEIwV0wQRndKaCERrIaILxnwuk2HeXKxN/JTsBHHdj0EFk7IuQnCHdbLq4f1SMSkY7Iyi2rZ4m1ZGDWrzE+4eun02iL+H9jTr3A1df6omKqr/u3sCtSBgjQ5eZXPvwPYxMfAKbSCvBoV6O3CA00aHK4JPODHWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UQ1YVPBxBcbTo6qbznpy03jOw0qULW58LKqR6lOwS6E=; b=ypbOhy4txWaEF7uSNShjtv3rWDFbfTbxkb2tldm6d0a7LMxzTLS2g8vUXnfB/u3w054et+glJHUk3kfcLEi9bPfvq/GkfDNmq581NjWzoor0ARnoUQhZDmCk/fwO6r9/O6j2vU4SL3JHab9RTB4YN92shCttQ6TAxUAiwisQ+Ck= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB8923.eurprd08.prod.outlook.com (2603:10a6:20b:5b3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 13:57:35 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6%3]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 13:57:35 +0000 Message-ID: <16313f2c-90a1-4fa7-2af3-ef420cad18f6@arm.com> Date: Tue, 31 Jan 2023 13:57:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: GDB 13 release -- 2023-01-21 Update To: Joel Brobecker Cc: Simon Marchi , Torbjorn SVENSSON , tom@tromey.com, gdb-patches@sourceware.org References: <95dc547e-59f8-95b3-903c-138d8842cea0@foss.st.com> <47dff98e-b714-2d72-bc3b-c14c4e0313d0@arm.com> <1689df81-6ab3-c167-24a4-415a86216b5a@arm.com> Content-Language: en-US From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0090.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::23) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB8923:EE_|AM7EUR03FT040:EE_|AS8PR08MB6422:EE_ X-MS-Office365-Filtering-Correlation-Id: 93d8560c-0911-4ba5-1605-08db039321e6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hZwF2MmxTLQrJoUFYPOXL2yEDrECHOT5cbf++LOleORP+Ebj0ey+jFX8BzBLTrDddUIoIvPiZhUQm5wJGgrnwPSfBht+BAPW0C9QpCtQ6d26+4PS9Xow1Ha3JIctWH4anW4trXmeqc2UVfCvm4CLXW0vgvBN5mY/hk+LkvoTpsGfxyzTiYG6VgS7MFvEGI+fKHN7BWQdQg3Zbt2zY5hucFRBFJVVtcjO87pJXuwWtzTnAQQ4ZEn84t1fF6z+MIT9CStgwFQzJcNt+kG5hBWsMc4nU9seI0SclJGJNXXrFtwq0Guhq+WtCEyd7uM6gWqAMz/UvCy4LZObFD9euBsSdNIjOAldxFB69wb9Xlf9do8IwdEc65BbXx4NQUWrMVFe0tlWhOnRACutsFyX29hyBDBM7Xh+9kIns++nULJuJeFnxPbzEOkHTuG8TH+UxCI/YzaTAcHSQIylBonRMhAQoYLUnucy7aF61xyBKJ0Q1alh6vWc4SeRl6jY+lBf2fZfT+DAtJgIj6v1OhxBkOkuxsoEx2fm1+OiqyQVUaGsL3IaqsUBp96TVYGPu/Ye/QTpo59BpqogD6wkTdJNc4GXRIQ1t8yRxbc96VIB+l3kB28WopXIYWhMWt3Md5l8wwKyjEMQ/szLsi9lknvR24YEQwS6FF1sREkx15zZBjfltVTlCoRCEXc6rXg9P/UjHn0GOhbcdLrE3H1adK5lhx97UBOd6oZEgbHCYAXKMjYOYi0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199018)(4326008)(2906002)(44832011)(31686004)(5660300002)(6506007)(53546011)(54906003)(8936002)(36756003)(186003)(2616005)(6512007)(26005)(41300700001)(66946007)(83380400001)(66556008)(66476007)(478600001)(86362001)(6916009)(31696002)(8676002)(316002)(6486002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8923 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9fedc4b2-7542-42f1-ceb4-08db03931af0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W9jdStb54xsbbIwOJYcDhOGbZYnrWaJ7xML0Lb4WZqKlST44A1wSHc6oA6dx8yaS3+ggdieVROUKVKWd5xU/XiqCzURUl02NRFzp+wZVcMSiyYHgqGRkeA5XI6CnA261SHBTjMDlSCbgV7Of/JyGKG0zQgM5GmNH/R9oCVlqfCaahvBJ5Y13kl480NSwiRHSIxd9lU6BBqYaORcnNrMoUhB4JT4ljoKrINjx2apq4tv3iD7jqSXwE2BsaztLJHyMxIq2JCcgbdJFg/LWi7P2Q+xdxfvz+jstHUvllrdFAYm6hnNnmCjfImSyodCRyh6zmHvTfXqBijiAmkpmQpS55HXxjivv/QWfWxRbbhR/vajOnhtkmm2hqnyUpGsq5NrsQYJxyQgkLrMmzql6TGSrlla8KpM9MboEB8lNyxhAoPBRlPiqvk++4G9uXgGiq9OxIZ5WYXEzMQQgftmeti//x8VZvclg/CphPIJq+4SMJ/fUl2XbpJNKLHV9DE3IztT5myxU9xpzy3KU5ERW5o5OJxiE6OQBC90DqJSymhS6DxprnlNn9g6OBg0qktL2kM7wjhL10SAjKyhJVckm2ghOX4xPPF7F/9/YLFfYIyWlolr9dtPD2VNhcwHunhTuD6qYsiuRXqLSUywCCxrwKs/vm1p/Z7RAFdVewN16LbUNTRZdEw5u2/nMSPky2qVpfV9cfrRcK63yDrSO51BuKtHOet66G3UHUc3jfvkj/ACh5Jkfj9q/fW0Jb2ea2QBMBrw0URkftRrE6mzZPicX1dEsO0ODlIHM+oQHQ9Lh2Q5HwlA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199018)(46966006)(36840700001)(40470700004)(316002)(54906003)(36860700001)(44832011)(86362001)(82740400003)(36756003)(81166007)(2906002)(6862004)(82310400005)(8936002)(31696002)(356005)(40480700001)(70206006)(70586007)(47076005)(8676002)(5660300002)(4326008)(41300700001)(40460700003)(6486002)(2616005)(83380400001)(186003)(478600001)(6512007)(31686004)(336012)(6506007)(53546011)(26005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 13:57:46.6391 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93d8560c-0911-4ba5-1605-08db039321e6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6422 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Joel, On 1/31/23 07:03, Joel Brobecker wrote: > Hi Luis, > > On Mon, Jan 30, 2023 at 11:23:06AM +0000, Luis Machado wrote: >> On 1/29/23 11:52, Joel Brobecker wrote: >>>>>>> - With that said, the patch appears to simply add a cache, >>>>>>> so the logic of it all doesn't appear to be extremely >>>>>>> complicated. So I would rate the risk to be low. >>>>>> >>>>>> That's what it seems to me. >>>>>> >>>>>> I think another round of testing would be a good step to make sure there are no hidden bugs. >>>>> My understanding is that the problem was making debugging borderline >>>>> impossible. Or at least, really, really unpleasant. So I think it >>>>> qualifies as a bug fix, and that the benefit is worth the risk. >>>> >>>> Right. Past a short number of frames, unwinding got really really slow. >>> >>> The part that I haven't been clear on is whether this affected everyone >>> on Arm-32bit, or everyone on both Arm and AArch64, or just a subset >>> of the users? >> >> Just a subset. >> >> It affects 32-bit m-profile Arm targets that report the additional stack pointers. This is either >> the org.gnu.gdb.arm.m-system feature or the org.gnu.gdb.arm.secext feature. >> >> I'm fairly sure these features are only reported by emulators and bare-metal targets. >> >> Now, a 64-bit gdb can debug 32-bit Arm as well, so you could have a 64-bit gdb running into this too >> if the target is a 32-bit m-profile Arm. But the target is still 32-bit Arm. >> >> This doesn't affect AArch64 at all. > > Thanks for the extra effort explaining the impact. This is much clear > for me, now. With your permission, I'd like to copy the text above > as a comment in the PR. Would that be OK?> Yes, that's fine. Let me know if you want me to do it. >>> Regardless of the above, I agree we can backport. To avoid confusion, >>> can I leave this to you, Luis, to confirm that the two patches I identified >>> previously are the only two patches that need to be backported, and >>> can you backport those for us, with a round of testing if you haven't >>> done so already, just to double-check? >> >> Sure. I gave it a try with master and the test results look the same with or without the patches. >> >> Unfortunately the 32-bit Arm test results are not too clean as there is quite a bit of noise from >> failing watchpoints tests. >> >> I'll try with GDB 13 just to be sure. > > Thank you. Once you've finished testing, whatever that might be, > you can go ahead and push the patches. As disussed earlier, we all > agree the risk of bad impact is very low. > > Let me know when this is done. It's starting to look like we might > have a pre-release created this weekend! Maybe earlier, if I can > carve some time out of my work schedule. > I ran checks with the gdb 13 branch and the results look the same for a patched gdb compared to an unpatched one. I'll cherry-pick both commits to gdb 13 once sourceware is back up. Thanks for the patience in getting this addressed. >>> For the record, those patches were: >>> >>> commit d72ba177c85f2ad18d0dcabdd8844532c9acb819 >>> Author: Torbj�rn SVENSSON >>> Date: Thu Nov 17 12:17:53 2022 +0100 >>> Subject: gdb: dwarf2 generic implementation for caching function data >>> >>> ... and ... >>> >>> commit 5cf11483141a58314834653003e49709b47822d5 >>> Author: Torbj�rn SVENSSON >>> Date: Thu Nov 17 12:18:20 2022 +0100 >>> Subject: gdb/arm: Use new dwarf2 function cache >>> >>> Thank you! >> >