From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A4839384F00D for ; Fri, 13 Jan 2023 17:04:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4839384F00D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673629471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WDNQAx2e/at9YakcmKP+ydpqn64JrmT1Nt9tvw4Z4KY=; b=NBEP59LeQfluxUMkG+fjfDwwxlJFfjZcWcjsVErlORFmQQ3tlHDPoewE2Q6kVpXQx8OoJm YhR+qGTDd/y8Pmj0+m6Im34VNa5R/p63tfW4A0QMaSJEg1K2BMR+KaSnFkVzvvJuvEs2No T//fuVAXX7l6J0zb4zHxj/O8iOXAQAw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-511-NpxwAj5wM5KjQkxJAEfhnA-1; Fri, 13 Jan 2023 12:04:29 -0500 X-MC-Unique: NpxwAj5wM5KjQkxJAEfhnA-1 Received: by mail-wm1-f71.google.com with SMTP id j15-20020a05600c1c0f00b003d9ec0eaa74so868665wms.1 for ; Fri, 13 Jan 2023 09:04:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WDNQAx2e/at9YakcmKP+ydpqn64JrmT1Nt9tvw4Z4KY=; b=4+90tWLM/vyDW/7K6r2lN1OwuyeoDANFdH2FeCmimVABXLqju5jnbrR6/CSQKiZI3O TIZTICh96y3lH75uv45lxwViDky7JVVlTSmwhNYrfrCvzmUu65adWnTJfzFfBs1zhlpM SDiN6Onz9anNz8CvR/jk2mAys5k643+DIequw4T2NEms8yli9xD+hnCl98JPzGKa7F09 w7Su7GZb2tGsvtcgirCEuvvfaTpQ2r1AcwuHpcLE9CnTQbgzDs9TJwRCxdc69l3a45Rg hZZPD4sfy1IErcj1ZyBhe67Wrpyq0CGbKSqSarwidF64EJABf4Bne+++p6SWdVA5JArB gy6w== X-Gm-Message-State: AFqh2krHQwnemHtrXE9eJTLbXb6puQWu4YGYI7aeatT5llBxiJudWL9k boxyqtmoEiFHQNcHHP+lYq10Lnr7sZwOq+UT6i8lQLyA/NYB4qu+S2VAWSSKTxAjdLBhvSkp0kb 4iia/pxo4UIbkg3BW5Q6HMw== X-Received: by 2002:adf:ffc3:0:b0:2bd:e8b2:4da8 with SMTP id x3-20020adfffc3000000b002bde8b24da8mr294878wrs.35.1673629468680; Fri, 13 Jan 2023 09:04:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXtR+7fkGlwmObW7Djo68tlnmlCZMprBxgZET18K47FYfwMAcqYFBa7gT1ouMkoTXDq6E50BVg== X-Received: by 2002:adf:ffc3:0:b0:2bd:e8b2:4da8 with SMTP id x3-20020adfffc3000000b002bde8b24da8mr294866wrs.35.1673629468497; Fri, 13 Jan 2023 09:04:28 -0800 (PST) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id v14-20020adff68e000000b002365730eae8sm19353270wrp.55.2023.01.13.09.04.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jan 2023 09:04:28 -0800 (PST) Message-ID: <163c8487-f5c1-2b10-697e-6f695112b352@redhat.com> Date: Fri, 13 Jan 2023 18:04:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/2] fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp To: Carl Love , Ulrich Weigand , "will_schmidt@vnet.ibm.com" , gdb-patches@sourceware.org References: <51c4bfc82ac72e475e10577dc60e4d75fa48767e.camel@de.ibm.com> <3ea97a8aa9cccb39299adde682f92055d1986ab3.camel@us.ibm.com> <53878e37c6e57de1d04d9c9960c5d0a74324ee6e.camel@us.ibm.com> <50474aa92ba82eff05cdc8f49001eae56be29670.camel@us.ibm.com> <89331c26795e3f7743e1e068dce43b3c2dd53008.camel@us.ibm.com> <071f24ecf9b3a2bbbe8fee7db77492eb55c5f3ff.camel@us.ibm.com> <1d9b21914354bef6a290ac30673741e722e11757.camel@de.ibm.com> <3e3c9c40f07ab01c79fe10915e76ffa187c42ad9.camel@us.ibm.com> <41aed5ea42d8888d9bc40c5102088e89e389937c.camel@us.ibm.com> From: Bruno Larsen In-Reply-To: <41aed5ea42d8888d9bc40c5102088e89e389937c.camel@us.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13/01/2023 17:43, Carl Love wrote: > Bruno: > > On Fri, 2023-01-13 at 14:33 +0100, Bruno Larsen wrote: >>> +# This file is part of the GDB testsuite. It tests reverse >>> stepping. >>> +# Lots of code borrowed from "step-test.exp". >>> + >>> +# The reverse finish command should return from a function and >>> stop on >>> +# the first instruction of the source line where the function call >>> is made. >>> +# Specifically, the behavior should match doing a reverse next >>> from the >>> +# first instruction in the function. GDB should only take one >>> reverse step >>> +# or next statement to reach the previous source code line. >>> + >>> +# This testcase verifies the reverse-finish command stops at the >>> first >>> +# instruction in the source code line where the function was >>> called. There >>> +# are two scenarios that must be checked: >>> +# 1) gdb is at the entry point instruction for the function >>> +# 2) gdb is in the body of the function. >> While testing locally, I ran into a bug with reverse finish at the >> epilogue of the function, that your patch also fixed. It would be >> nice >> if the test extended that. And since the bug was that GDB stopped >> responding and even ctrl+c did nothing, I would suggest adding it as >> the >> last test. > I haven't run into the issue that mentioned about GDB not responding in > the epilogue. I will have to go play with that to see if I can > reproduce it. If you have any specific instructions on how you ran > into it that would be interesting and helpful. I manually ran gdb.reverse/finish-precsave (setting recording, of course), set a temporary breakpoint on void_func, nexted once to be in the epilogue and tried to reverse finish. I'm not sure if it was some stale file before I recompiled the test, though. Anyway, sorry if I was unclear, but that is not a regression of your patch. Rather, you patch fixed that issue, I just want that test to confirm that we don't accidentally regress it. -- Cheers, Bruno > > I have read thru the other comments and will work on them and update > you on those fixes later. Thanks for the feedback. > > Carl >