From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: [PATCH][gdb/testsuite] Fix minimal encodings KPASSes
Date: Mon, 16 Nov 2020 15:01:14 +0100 [thread overview]
Message-ID: <1640fdd0-2d21-1e77-11b5-ccc6fa21afb1@suse.de> (raw)
In-Reply-To: <841f46d8-6f6a-0b89-a99f-6077300e849f@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]
[ was: Re: [PATCH 0/9] Fix most -fgnat-encodings=minimal failures ]
On 11/4/20 5:33 PM, Tom de Vries wrote:
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: ptype small (PRMS
> minimal encodings)
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print small (PRMS
> minimal encodings)
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print small'first
> (PRMS minimal encodings)
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: ptype multi (PRMS
> minimal encodings)
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi (PRMS
> minimal encodings)
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi'first
> (PRMS minimal encodings)
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi_multi
> (PRMS minimal encodings)
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print
> multi_multi(1,3) (PRMS minimal encodings)
> KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print
> multi_multi(2) (PRMS minimal encodings)
> KPASS: gdb.ada/mod_from_name.exp: scenario=minimal: print xp (PRMS
> minimal encodings)
> KPASS: gdb.ada/pckd_arr_ren.exp: scenario=minimal: print var (PRMS
> minimal encodings)
> ...
Hi,
This fixes the KPASSes for me.
Any comments?
Thanks,
- Tom
[-- Attachment #2: 0001-gdb-testsuite-Fix-minimal-encodings-KPASSes.patch --]
[-- Type: text/x-patch, Size: 3125 bytes --]
[gdb/testsuite] Fix minimal encodings KPASSes
With current master I see a couple of KPASSes:
...
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: ptype small \
(PRMS minimal encodings)
...
KPASS: gdb.ada/mod_from_name.exp: scenario=minimal: print xp \
(PRMS minimal encodings)
KPASS: gdb.ada/pckd_arr_ren.exp: scenario=minimal: print var \
(PRMS minimal encodings)
...
The corresponding setup_kfail is called for everything before gnat 11.
However, the test-cases also PASS for me with gnat-4.8, gnat-7.5.0 and
gnat-8.4.0.
Fix the KPASSes by limiting the setup_kfail to gnat 9 and 10.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-11-16 Tom de Vries <tdevries@suse.de>
* gdb.ada/enum_idx_packed.exp: Limit setup_kfail to gnat 9 and 10.
* gdb.ada/mod_from_name.exp: Same.
* gdb.ada/pckd_arr_ren.exp: Same.
---
gdb/testsuite/gdb.ada/enum_idx_packed.exp | 5 +++--
gdb/testsuite/gdb.ada/mod_from_name.exp | 5 +++--
gdb/testsuite/gdb.ada/pckd_arr_ren.exp | 5 +++--
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.ada/enum_idx_packed.exp b/gdb/testsuite/gdb.ada/enum_idx_packed.exp
index 2e5a85e76b3..f32c488e171 100644
--- a/gdb/testsuite/gdb.ada/enum_idx_packed.exp
+++ b/gdb/testsuite/gdb.ada/enum_idx_packed.exp
@@ -28,8 +28,9 @@ foreach_with_prefix scenario {all minimal} {
clean_restart ${testfile}
- # GNAT >= 11.0 has the needed fix here.
- if {$scenario == "minimal" && ![test_compiler_info {gcc-1[1-9]-*}]} {
+ # GNAT 9 and 10 are known to fail.
+ if {$scenario == "minimal" && ([test_compiler_info {gcc-9-*}] \
+ || [test_compiler_info {gcc-10-*}])} {
set old_compiler 1
} else {
set old_compiler 0
diff --git a/gdb/testsuite/gdb.ada/mod_from_name.exp b/gdb/testsuite/gdb.ada/mod_from_name.exp
index 43d81e0026f..5f779c30845 100644
--- a/gdb/testsuite/gdb.ada/mod_from_name.exp
+++ b/gdb/testsuite/gdb.ada/mod_from_name.exp
@@ -34,8 +34,9 @@ foreach_with_prefix scenario {all minimal} {
return
}
- # GNAT >= 11.0 has the needed fix here.
- if {$scenario == "minimal" && ![test_compiler_info {gcc-1[1-9]-*}]} {
+ # GNAT 9 and 10 are known to fail.
+ if {$scenario == "minimal" && ([test_compiler_info {gcc-9-*}] \
+ || [test_compiler_info {gcc-10-*}])} {
setup_kfail "minimal encodings" *-*-*
}
gdb_test "print xp" \
diff --git a/gdb/testsuite/gdb.ada/pckd_arr_ren.exp b/gdb/testsuite/gdb.ada/pckd_arr_ren.exp
index 13e599b6a58..8c53f857bee 100644
--- a/gdb/testsuite/gdb.ada/pckd_arr_ren.exp
+++ b/gdb/testsuite/gdb.ada/pckd_arr_ren.exp
@@ -31,8 +31,9 @@ foreach_with_prefix scenario {all minimal} {
set bp_location [gdb_get_line_number "STOP" ${testdir}/foo.adb]
runto "foo.adb:$bp_location"
- # GNAT >= 11.0 has the needed fix here.
- if {$scenario == "minimal" && ![test_compiler_info {gcc-1[1-9]-*}]} {
+ # GNAT 9 and 10 are known to fail.
+ if {$scenario == "minimal" && ([test_compiler_info {gcc-9-*}] \
+ || [test_compiler_info {gcc-10-*}])} {
setup_kfail "minimal encodings" *-*-*
}
gdb_test "print A2" \
next prev parent reply other threads:[~2020-11-16 14:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 20:05 [PATCH 0/9] Fix most -fgnat-encodings=minimal failures Tom Tromey
2020-09-30 20:05 ` [PATCH 1/9] Avoid crash in ada-lang.c:to_fixed_array_type Tom Tromey
2020-09-30 20:05 ` [PATCH 2/9] Fix decoding of multi-dimensional constrained packed arrays Tom Tromey
2020-09-30 20:05 ` [PATCH 3/9] Synthesize array descriptors with -fgnat-encodings=minimal Tom Tromey
2020-11-06 12:08 ` Luis Machado
2020-11-06 17:55 ` Tom Tromey
2020-09-30 20:05 ` [PATCH 4/9] Reject slicing a packed array Tom Tromey
2020-09-30 20:05 ` [PATCH 5/9] Resolve dynamic type in ada_value_struct_elt Tom Tromey
2020-09-30 20:05 ` [PATCH 6/9] Fix bit strides for -fgnat-encodings=minimal Tom Tromey
2020-09-30 20:05 ` [PATCH 7/9] Only use stride for final element type Tom Tromey
2020-09-30 20:05 ` [PATCH 8/9] Use bit stride when taking slice of array Tom Tromey
2020-09-30 20:06 ` [PATCH 9/9] Recognize names of array types Tom Tromey
2020-11-04 15:49 ` [PATCH 0/9] Fix most -fgnat-encodings=minimal failures Tom Tromey
2020-11-04 16:33 ` Tom de Vries
2020-11-04 17:20 ` Tom de Vries
2020-11-04 18:52 ` Tom Tromey
2020-11-04 19:54 ` Tom de Vries
2020-11-16 14:32 ` Tom de Vries
2020-11-16 14:01 ` Tom de Vries [this message]
2020-11-23 19:10 ` [committed][gdb/testsuite] Fix minimal encodings KPASSes Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1640fdd0-2d21-1e77-11b5-ccc6fa21afb1@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).