From: Iain Buclaw <ibuclaw@gdcproject.org>
To: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb.dlang/demangle.exp: update expected output for _D8demangle4testFnZv
Date: Fri, 14 Jan 2022 20:45:53 +0100 [thread overview]
Message-ID: <1642189246.zkqt3t5c83.astroid@pulse.none> (raw)
In-Reply-To: <20220113161016.2248240-1-simon.marchi@efficios.com>
Excerpts from Simon Marchi's message of Januar 13, 2022 5:10 pm:
> Since commit ce2d3708bc8b ("Synchronize binutils libiberty sources with
> gcc version."), I see this failure:
>
> demangle _D8demangle4testFnZv^M
> demangle.test(typeof(null))^M
> (gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4testFnZv
>
> The commit imported the commit 0e32a5aa8bc9 ("libiberty: Add support for
> D `typeof(*null)' types") from the gcc repository. That commit includes
> an update to libiberty/testsuite/d-demangle-expected, which updates a
> test for the exact same mangled name:
>
> _D8demangle4testFnZv
> -demangle.test(none)
> +demangle.test(typeof(null))
>
> I don't know anything about D, but give that the change was made by Iain
> Buclaw, the D language maintainer, I trust him on that.
>
> Fix our test by updating the expected output in the same way.
>
> Note: it's not really useful to have all these D demangling tests in the
> GDB testsuite, since there are demangling tests in libiberty. We should
> consider removing them, but we first need to make sure that everything
> that is covered in gdb/testsuite/gdb.dlang/demangle.exp is also covered
> in libiberty/testsuite/d-demangle-expected.
>
Hi Simon,
To memory, both gdb and libiberty D demangle tests started out as being
identical, but libiberty has been adding more to it as it's been
improved/updated to support the latest language features. I see no
issues with removing it if it's becoming problematic to maintain both.
Iain.
next prev parent reply other threads:[~2022-01-14 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 16:10 Simon Marchi
2022-01-14 19:45 ` Iain Buclaw [this message]
2022-01-14 20:09 ` Simon Marchi
2022-01-14 20:12 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1642189246.zkqt3t5c83.astroid@pulse.none \
--to=ibuclaw@gdcproject.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).