From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [IPv6:2001:67c:2050::465:101]) by sourceware.org (Postfix) with ESMTPS id 365CB3858403 for ; Fri, 14 Jan 2022 19:46:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 365CB3858403 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4JbBcS4Tw9zQk9h; Fri, 14 Jan 2022 20:46:00 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Date: Fri, 14 Jan 2022 20:45:53 +0100 From: Iain Buclaw Subject: Re: [PATCH] gdb.dlang/demangle.exp: update expected output for _D8demangle4testFnZv To: gdb-patches@sourceware.org, Simon Marchi References: <20220113161016.2248240-1-simon.marchi@efficios.com> In-Reply-To: <20220113161016.2248240-1-simon.marchi@efficios.com> MIME-Version: 1.0 Message-Id: <1642189246.zkqt3t5c83.astroid@pulse.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 19:46:04 -0000 Excerpts from Simon Marchi's message of Januar 13, 2022 5:10 pm: > Since commit ce2d3708bc8b ("Synchronize binutils libiberty sources with > gcc version."), I see this failure: >=20 > demangle _D8demangle4testFnZv^M > demangle.test(typeof(null))^M > (gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4testFnZv >=20 > The commit imported the commit 0e32a5aa8bc9 ("libiberty: Add support for > D `typeof(*null)' types") from the gcc repository. That commit includes > an update to libiberty/testsuite/d-demangle-expected, which updates a > test for the exact same mangled name: >=20 > _D8demangle4testFnZv > -demangle.test(none) > +demangle.test(typeof(null)) >=20 > I don't know anything about D, but give that the change was made by Iain > Buclaw, the D language maintainer, I trust him on that. >=20 > Fix our test by updating the expected output in the same way. >=20 > Note: it's not really useful to have all these D demangling tests in the > GDB testsuite, since there are demangling tests in libiberty. We should > consider removing them, but we first need to make sure that everything > that is covered in gdb/testsuite/gdb.dlang/demangle.exp is also covered > in libiberty/testsuite/d-demangle-expected. >=20 Hi Simon, To memory, both gdb and libiberty D demangle tests started out as being identical, but libiberty has been adding more to it as it's been improved/updated to support the latest language features. I see no issues with removing it if it's becoming problematic to maintain both. Iain.