From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 6250938515FB
 for <gdb-patches@sourceware.org>; Thu, 29 Jul 2021 16:56:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6250938515FB
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 16TGtvpL029767
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Thu, 29 Jul 2021 12:56:02 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 16TGtvpL029767
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 6CB421E4A3;
 Thu, 29 Jul 2021 12:55:57 -0400 (EDT)
Subject: Re: [PATCH v3 2/3] guile: fix make-value with pointer type
To: George Barrett <bob@bob131.so>, gdb-patches@sourceware.org
References: <6-nou03zjdt7znv7en-rj/.p1fg6ovruu-op5_qcpmqs&zn3c/5n@mail.bob131.so>
 <wh-mj0-hb71xol&-i.3_czrd8a8m0ysong9_o/8cbk5&3f7denaq@mail.bob131.so>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <1642874a-883c-5e8a-3a42-ed7ea95ccf71@polymtl.ca>
Date: Thu, 29 Jul 2021 12:55:57 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <wh-mj0-hb71xol&-i.3_czrd8a8m0ysong9_o/8cbk5&3f7denaq@mail.bob131.so>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 29 Jul 2021 16:55:57 +0000
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 16:56:07 -0000

I'll push it with this fixed:

> +/* Store in *MAX the largest value representable by pointer type
> +   TYPE. */

I'll update this comment to reflect that the function now returns the
value.

Simon