From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic304-22.consmr.mail.ir2.yahoo.com (sonic304-22.consmr.mail.ir2.yahoo.com [77.238.179.147]) by sourceware.org (Postfix) with ESMTPS id 165A43858D1E for ; Wed, 1 Nov 2023 13:57:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 165A43858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 165A43858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.179.147 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698847070; cv=none; b=vRJljr66UHasEFfGMuwH9/FFEsvEIsS4A58pFULfnu2Zy/xvFfMy8T9pDt2uuvTW34geT0Da6k3SzSca/wHzNzK85QalgE+KYWawUHRKG5ozO5sqh6/70o5oSaa1eBrknOHU61uKOkKmv4fV8uZB+mhPNTNzMXz72ONElcmJpyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698847070; c=relaxed/simple; bh=fqKjfnVTvjtT64Fsj/kWX+EsnQvwaAiGI3+eWA4P4Hw=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=duaqQUcjaS9YgQgRAwdv9W7/qj4V/tkcD49KyIm6b7s1DuQ5thhyN9j0SLZiJOdF3k/sU8e2mWGG0/HAzUyoPA//tEncc1bQga5frsbObC/Su8X9ji9EJTs/iFLeTj+im8t+BSiitkFYEWQNo9qft+bjW9p+90eqsHvoFWhCDnM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1698847058; bh=fqKjfnVTvjtT64Fsj/kWX+EsnQvwaAiGI3+eWA4P4Hw=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=Sk1mgt7/Hev98t/10aWjTwq2Kb2CDpim761qYgHAgPwq2OMCxex2mYYvYLNpioJur2L+HDJ0c+Pn67VWoPsybBL7g64GeA0uIyPNiaE2Umu/aapGKzczgAHsziZa7ZdBCRN+sc1Ci7NYYBJ/sKBnKlNU0en8Gc93TYTGKaNLPHSNTmJb1g3jOgOIj6lFAPQBIvp8rUxhno6RTpJHNYHpiSZsxkiYxcqFvwn9b9k/2M1m0Ph64gjgIG7kK11etNJsLwj7Os8KCBP70808XXGXVvvTJapXFeSczyhVP4Pkm04u014IVFtGoPUokTJM/0jycqOMyqBcDnknoAj2YsjBSQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698847058; bh=mRP+y2NFVBxo3GyNGLWnvaHLSgwarv2qzCo2atFYjtp=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=c9igr/jIUAInoXl4ct5ddfm7qhpeQhhnVd9eHcgEeYWMvdOxVR9qEzHmRGj8bUxZD/qL41MJQK304F2rM/YEKS+hqtLTxv/kxlQb85hfEqtIzGvhFx6Vcr9nqAtZFdzol3TbfyjavHbE0f1ifDbxysHRCbB6GBnaXR2lRhMNUrLr5Gj8Xy5tTN23lXplCAdpu47cnT8WPSm+FgoCfnnNezfy3pKwBt41R7iwUYB0eGfsDbKygrFZMMptjotkM8sU/93Q/PpJIY7eWQ2Tr73JC4TpgLNXIsKyvfE7N/Y27sHZ+lWgvOAoHgr2xuSiWUR5em3zlDKPAZvaRYiK1VI14g== X-YMail-OSG: YgmFeUMVM1laTh9DEaiRU_ISQ1JIBY1JoHtRfG_Q3XcIYOgMtEo.n99Z47GlhXz 8byAw0qY1H1AZzIkxvcGWYPBeT__chodtQQsf2VEaldNdQCa20fZlC8KrEGgHimt4v3am1F1Cw1y a8SN3akmvW.2KqgiDK24Wb0SndX7N5Te3xFx_QukLnr1b4hoKtFBX22854SidxiDoXhjwl1FYus1 0s5oqBlL3Iz63HBp.KabfPq.0eskNqApb2l7WmGGM3oeyHG4tswD_b_KF_0CG4A_xhQw7Gkk1bw8 ugNg7z.ehZAbm1Pp5s4uHi1A.oWWZILDkYI28TAayeKlJLExcV..2EAz8GSA5yKITdDlb3uWzgZi wXK4xlE2ZhMtFIgOUnCqKZrlwwG8Ag3A9UuUtiXuRzaS.vY44zh97DxDB4qlG8a9xAudzNv9YXGX EsF9fTaXriKulA_jCguZsz2GlFQqMDb7iBla3wu4lRVbv_OsL.jSwBxunOiKbUQYsZsZPQCMiyLp Zm_qG9S5PNUPucqO2dChlP4iVKKtbZxm9CgvKs6qZ0q4Idgt76.TM9.9tQop2srIlZm._RoIAHSg ce9i2.3Mw_TX.B7eM7W8IMoLpPYdmXxPSg6ypY5cBo7WWvl6mnLFN8BCwAqZQf2a3G7zgaWTOkgj xvgwpkhYkfA3OlUynVbSpdIMSgipmukoX5GDW2MD7b65HuU.xQa_hgQXbff2MLUfsGbeS1WNsfz8 Df54gpWGPNXy_bUfrUjFqt6ID7TKHP40pwdyReQN3RStj8V1jGb7zdVZogG2Wjf_nslZkLlxf9L6 _qp9iRxJY_qHXSwVnKx_RQB85gwsAMV3DMuSQ2TS6DhEN.kCbamMA5P_kMOpi.azSxoVpY5savF3 PkMCXIBreHB1lqtyQtKzv9_YgfjNJKhIZHpQOnCs7gfWEHaYw3ANjP1JtX8o7fdiIQb6b9bAZn.j gqrWpCA64mHokQILd3GBgt939CQ0GY_gZVnpdtZf5gFV1Kk__vYvPtV7waZSLA3qOeVbgOsNuUOE hCqDE2pSxUT0tMwYpc1KA4yolvWw_RG6M_q1I0dJkgTkKa3wG_t0Gxwz3SeECbtyWrvohboo5TVq q6nFYLL.b5EpgqhN9zEp_Uw2Ozr0Bck1rVIvbx_yb.buiZHbltJra4_t2YDGS1Wx0MR5RWh9Q0Oo 0lBqzVI4RVV_HFSP5ebR2JLuOreTdX_3pKDDuGu3IZxIAzc5X3OPUXU28JWNqVzdWtkJCxbmcOEd mn0KjNlF1M_Cl0jlztek88eZf6MNWtnzAzAFiJj7DafrDKPLKRs_7yj9G0OQcGJJs0aJASWU1QVe SBWKp.4oS2t1HSKGATZm0r1JqdF1m78CV_YBOaaR3RITN0.VEVCQV.nTfgKpG_IzR2Yy1h27tOfc nUey4PsZVgKo2zqRagL_9WGUJa2ySbvou14hTLdDmbh4bMeLsABeGXYiocN6ClG3C_ji3tuza05W DA5w.N1gQM8kekbcqpccdCy71H59yi69HJbN4j4K69GSMYGVkE4Ztmarx2HvfY5JP2msUxRffMbR QT_mwK9Ik_3uUR8vmZBMZfdyihSen8c.1KWRBg6DqLbbATi7q.D2d4V0x7oCXY8fgnm_jaThBXgs rWfwA85KZXEkoDyHVDnWi5c5f6v..jDTc1WxeaieaBY7Z1W.QQdVx1qsymXTxtSoS2GpWo2YBOCx 5h1WE_G38YIkRLWlxIG59DmXBHNGWGaloYy4w.ySbfJ5e9axEMHkq18BHogfYBdP65HiXnPOrhq_ SgBg9Md_HpeEidEz7Fz_TulmRLf2CXzWzpRsoK67sYl49_eLdLTk88EwhrV5i.fWpPc9rCAIVsO4 K3jylWzIsVvmoj9m3dRK4VocNrQbRdzLHPsrdl7YUwmuRCKyECSXf3Z0EmgDnxM11oQ.rd4KOuDE kr2lEsjj3wmn0jyyiB5.G5Xku28HWoiEnibjR2icRpg3Wt_bWnjfMtiT6F9766XTtZjqRcsr2buP E1xIpoDs1_w0RCmuh8DX9zIktw8jHaLR_G4dJAN2hQ.7u3w80tyTrD.4awmRD9DZ35ay4aAgstx6 PfIZ19pXl2JzIVk14Ee47evFU2VpzhftvqTNGxgktF2R9dXR76A4Bf_pl9RzYz.Db_5e9WROMYQV t9MOdtr5ILsrAICITWQ9KSJCdriK5B5zleigAYnAXnaY9w6MWKFkM.HXRbvRqqHKmZ2YR9DZ3Inq _VVE- X-Sonic-MF: X-Sonic-ID: 5f91968f-b92a-4b61-a38d-9aa8dd509af9 Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Wed, 1 Nov 2023 13:57:38 +0000 Date: Wed, 1 Nov 2023 13:57:36 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" Message-ID: <1686556384.2549191.1698847056400@mail.yahoo.com> In-Reply-To: <1856017925.2892615.1696269030810@mail.yahoo.com> References: <20230914162732.2077-1-ssbssa.ref@yahoo.de> <20230914162732.2077-1-ssbssa@yahoo.de> <1856017925.2892615.1696269030810@mail.yahoo.com> Subject: Re: [PATCH v2] Fix hardware watchpoints in replay mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21890 YMailNorrin X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. Am Montag, 2. Oktober 2023, 19:51:03 MESZ hat Hannes Domani via Gdb-patches= Folgendes geschrieben: Ping. Am Donnerstag, 14. September 2023, 18:28:30 MESZ hat Hannes Domani via Gdb-= patches Folgendes geschrieben: > Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597 > caused a regression that meant hardware watchpoint stops would not > trigger in reverse execution or replay mode.=C2=A0 This was documented in > PR breakpoints/21969. > The problem is that record_check_stopped_by_breakpoint always overwrites > record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT > value which would be checked afterwards. > > This commit fixes that by checking if record_full_stop_reason is > TARGET_STOPPED_BY_BREAKPOINT and, if so, not overriding it. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D21969 > --- > gdb/record-full.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 4 +++- > gdb/testsuite/gdb.reverse/watch-reverse.exp | 4 ++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gdb/record-full.c b/gdb/record-full.c > index faf8b595d22..da785ef4b2a 100644 > --- a/gdb/record-full.c > +++ b/gdb/record-full.c > @@ -1382,7 +1382,9 @@ record_full_wait_1 (struct target_ops *ops, > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 /* check breakpoint */ >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 tmp_pc =3D regcache_read_pc (regcache); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (record_check_stopped_by_breakpoint > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if (record_full_stop_reason > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 !=3D TARGET_STOPPED_BY_WATCHPOINT > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 && record_check_stopped_by_breakpoint >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (aspace, tmp_pc, &record_full_stop_reason)) >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 if (record_debug) > diff --git a/gdb/testsuite/gdb.reverse/watch-reverse.exp b/gdb/testsuite/= gdb.reverse/watch-reverse.exp > index 6b81a6fdf88..a7126ac9b1d 100644 > --- a/gdb/testsuite/gdb.reverse/watch-reverse.exp > +++ b/gdb/testsuite/gdb.reverse/watch-reverse.exp > @@ -118,8 +118,12 @@ gdb_test "continue" \ >=C2=A0=C2=A0=C2=A0=C2=A0 ".*\[Ww\]atchpoint.*ival3.*Old value =3D 0.*New v= alue =3D -1.*ival3 =3D count; ival4 =3D count;.*" \ >=C2=A0=C2=A0=C2=A0=C2=A0 "watchpoint hit in reverse, fifth time" > > +gdb_test_no_output "disable \$bpnum" "disable non-hw watchpoint" > + > gdb_test_no_output "set can-use-hw-watchpoints 1" "enable hw watchpoints" > > +gdb_test_no_output "enable \$bpnum" "enable hw watchpoint" > + > ### > ### > ### > -- > 2.35.1