From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2087.outbound.protection.outlook.com [40.107.249.87]) by sourceware.org (Postfix) with ESMTPS id D786E3858D1E for ; Mon, 30 Jan 2023 11:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D786E3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f8HyHHEcvYqs0jPLc1Ir4S+TIffy7I0ch/p+XGNBN6o=; b=I5g3L9Lkna5F3Lr09fxvR3CaaYLRisYgDT+XkrB513cDsG2e0Nk2eYvjr0gdT8rsilppUsrPZxIMe4TmopFdfL0Cqt4xwxhggpYJ7T2Ms1WLq6Y1J7gjV/SV5yMtq9WS1vNHIwSfvDdjcvw2vSZz/46vMRuDI6rDKVotcpawWB4= Received: from DB6PR0301CA0088.eurprd03.prod.outlook.com (2603:10a6:6:30::35) by DB5PR08MB10094.eurprd08.prod.outlook.com (2603:10a6:10:4a2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.25; Mon, 30 Jan 2023 11:23:17 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::d8) by DB6PR0301CA0088.outlook.office365.com (2603:10a6:6:30::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend Transport; Mon, 30 Jan 2023 11:23:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Mon, 30 Jan 2023 11:23:17 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Mon, 30 Jan 2023 11:23:17 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ed9bbdbe0e2beae6 X-CR-MTA-TID: 64aa7808 Received: from 321f4f97eff0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D9AAD006-6DE6-4F18-B785-E3FC45BB6D55.1; Mon, 30 Jan 2023 11:23:10 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 321f4f97eff0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 Jan 2023 11:23:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUPvK69x4sgqUfzPS3Z40atogT2GznONdNqffR7C2fzfmMlwYXrPNNfIFcHh34ueql4Hrdn5liaVelz7z0KZS4g687d+5Ex4qCGH+gsiwq7XnjZa2XesQg7O+vgtH8tjxlM2PgYxbT85VT/wtGIIPiUlo++/RgobFhlhIxBlf2v2GY0KSHK/Ey49IlwHK/mV5Om+twy0DzNO+suZXUjUQVw0Iz+cbdKI4WTQqTmIz+ZFz0DMPEv7W1P9AaugBpKL1Oj7JCMv2IJW0f722HJjVSeaA5waYY0rXv0h6hCzKXVFT7BvB6FTbVEiZgBAtB637LTW+CipjG107T/n2j9fEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f8HyHHEcvYqs0jPLc1Ir4S+TIffy7I0ch/p+XGNBN6o=; b=Rr1h20oyWXpjZolD+OWMmmGAOjoOTa5rW2NdFDvBD2B8j3XMw1JKCaQdXushphF2nJatI0nJftLxGVS01bJTYaW1VHy411Lni2owrGSECmcelRtXmeirTZNh9n2HVQ0WLrVc3TSd223w/nKMForrVx/2ysdp0Ojn2CtlneaNzENrxkDQcPQNJLlmiOzesXNH78tD18pFtGMNgAG/C94bq1T6I5hXW6ymsJw5QiBWEP3IVt7u0FpsdLpUjy0zxdTjEkFXZslqhOYgUeFgvirzCV5O++1stwGZnuniiQ1rkWembMBsNcTgH0NI3nr4tyHRLQL7XAyjXc568c5C61p2Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f8HyHHEcvYqs0jPLc1Ir4S+TIffy7I0ch/p+XGNBN6o=; b=I5g3L9Lkna5F3Lr09fxvR3CaaYLRisYgDT+XkrB513cDsG2e0Nk2eYvjr0gdT8rsilppUsrPZxIMe4TmopFdfL0Cqt4xwxhggpYJ7T2Ms1WLq6Y1J7gjV/SV5yMtq9WS1vNHIwSfvDdjcvw2vSZz/46vMRuDI6rDKVotcpawWB4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB8015.eurprd08.prod.outlook.com (2603:10a6:20b:548::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 11:23:08 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6%3]) with mapi id 15.20.6043.036; Mon, 30 Jan 2023 11:23:08 +0000 Message-ID: <1689df81-6ab3-c167-24a4-415a86216b5a@arm.com> Date: Mon, 30 Jan 2023 11:23:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: GDB 13 release -- 2023-01-21 Update Content-Language: en-US To: Joel Brobecker Cc: Simon Marchi , Torbjorn SVENSSON , tom@tromey.com, gdb-patches@sourceware.org References: <95dc547e-59f8-95b3-903c-138d8842cea0@foss.st.com> <47dff98e-b714-2d72-bc3b-c14c4e0313d0@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0103.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::18) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB8015:EE_|DBAEUR03FT049:EE_|DB5PR08MB10094:EE_ X-MS-Office365-Filtering-Correlation-Id: a3e3f54e-f5cd-45db-e061-08db02b46281 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3LlePm+SLkUoFT4o22yRwqpi7Ia2d+0mc0/v2rhjauo0zCOZEpPZLnCmzhSXnS1O1+gYAB49BzbhmUvNDjFsIwkx2a7NDPoxNEtjIugkyDSgrfdWAPXXg5Mj+jZu7XsmijMjgXqp5ng6Y4reMZfP3Ch6TsigrTA4RVeYzdKcpBYG9EVSFdBa53HeJT9rGuqWueQ3WVVaY1Ts9qfbTWSVTPlPHrsJXw0TyAHHOHEBMCVqisptjZVQ/JFsV57xGAYg0HZnMyUbcQ303E9MvSFlM5S7oopqI6oe004pue73NUixHbhOanzcadyHNdC95xrA3PDCLCAup7P3clVS+1cPv4ftLa4CTsrDlM7VqOo+ifW5ZPqaQJeA2JX6bqaNeOdNHBJtVp5h0V0YGvzdQv58Td2NWeXeTeOZMQfUAKNlmQx21QfRSzE/jvPIDbL1PRCKQ1cRhwoHnaLbi8451esqHrubKwtJAO7Fr6wnUaP7SiQXTBiXpzyR0dYNxs1dT4hXq4WC1Z7n8tTG2iXzsL207XL9zPJTMMZJ66Ua+270vaneea5hjAIr5QHZAw/TM+5kye9EwLH2UQVTAOC6BCGu7hb9nU31JZ5nmUj9p+ZRhJubDkQFOBZlYkJQluWBZ4CIBVh8MmfiUaxUEPpgRMYwb9pCCto+J/iZxIbYwL5H+CuaxmuQQPAV8yJSj6Q3S9nnHbnrjHE+FMAN8IK8vm/HikuLnbsPkuDiLd3kl0uEIuE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199018)(86362001)(83380400001)(54906003)(316002)(41300700001)(8936002)(4326008)(66476007)(66556008)(66946007)(6916009)(8676002)(186003)(6506007)(26005)(6512007)(53546011)(478600001)(6486002)(2616005)(31696002)(36756003)(44832011)(5660300002)(38100700002)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8015 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d64169ae-2242-4ad0-efe7-08db02b45bc2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DbPkKKMJqlVZlDxBjkXCqfmLKRX9nX3PJ56MxrHPc0BI+Iva5M3rFwGKdsHCTjOhMLAi8O+PbbeCTiriWRAhwC1yHM/eGiQzqKcgGEQUDVqYYe8lm+wrzEfd9zmYnK4vnIEjPNKlKAUh9Lze1P4LpfM1t8a6r7lc1PAgtEBRLt09oHXfm8EzXuaN8wUGhgEGgOXqYdun68tAfMkmj0HUPc4lPA8NSvEQsskO8B/6nM9ZqHttjvV42icKEXKlSAyy+SeSX1IL8xL0teJSNqwV6nb7+pR4auJAlTDziN2tfnuffY6AeH/bFRIZlXPucmlByu7Xx/V2MGbtU5tFMZ+9lpoHMLSP6eirRuGuhREABATBhFCog6Focffor8n4+hpjoCqPIPNZzHYPhLuCJvSoZQ1LcJoiJlGqwO+7Uxb5DK1iX08ING/IqPCMd4upj4T9pq2taPAOM/Vs2O3we8HxwyCNAPum1eP1NgRaCKbVd4dVsBEKfCJQ7YQT2Q/IDOpC8KFWFi0/mCYd8PCNZkvydzRAVpmHobZP23lZl1mJwnxeZrndlHN6B1Q4PixMsQGoTVQ5PG9wJfWxylJ1D/rrPcUrJBxQqCOsCaf3Hrvb/aA2d9jxfdCKLdbZJpV0bD7t3SQ16pKAK+g2LFCp1Dt86d5l7jPm/ik0QHn+ak8w5vWVrz9OGdA/Qw9VbMkVnQrlEOxqNABLAApw04x9yFdooQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(39850400004)(346002)(136003)(396003)(451199018)(36840700001)(46966006)(54906003)(5660300002)(44832011)(2616005)(36756003)(6486002)(86362001)(2906002)(336012)(47076005)(53546011)(186003)(40480700001)(6506007)(478600001)(31696002)(26005)(6512007)(83380400001)(70586007)(81166007)(41300700001)(4326008)(82310400005)(82740400003)(70206006)(31686004)(8676002)(316002)(356005)(8936002)(6862004)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 11:23:17.3104 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3e3f54e-f5cd-45db-e061-08db02b46281 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10094 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/29/23 11:52, Joel Brobecker wrote: >>>>> - With that said, the patch appears to simply add a cache, >>>>> so the logic of it all doesn't appear to be extremely >>>>> complicated. So I would rate the risk to be low. >>>> >>>> That's what it seems to me. >>>> >>>> I think another round of testing would be a good step to make sure there are no hidden bugs. >>> My understanding is that the problem was making debugging borderline >>> impossible. Or at least, really, really unpleasant. So I think it >>> qualifies as a bug fix, and that the benefit is worth the risk. >> >> Right. Past a short number of frames, unwinding got really really slow. > > The part that I haven't been clear on is whether this affected everyone > on Arm-32bit, or everyone on both Arm and AArch64, or just a subset > of the users? Just a subset. It affects 32-bit m-profile Arm targets that report the additional stack pointers. This is either the org.gnu.gdb.arm.m-system feature or the org.gnu.gdb.arm.secext feature. I'm fairly sure these features are only reported by emulators and bare-metal targets. Now, a 64-bit gdb can debug 32-bit Arm as well, so you could have a 64-bit gdb running into this too if the target is a 32-bit m-profile Arm. But the target is still 32-bit Arm. This doesn't affect AArch64 at all. > > Regardless of the above, I agree we can backport. To avoid confusion, > can I leave this to you, Luis, to confirm that the two patches I identified > previously are the only two patches that need to be backported, and > can you backport those for us, with a round of testing if you haven't > done so already, just to double-check? Sure. I gave it a try with master and the test results look the same with or without the patches. Unfortunately the 32-bit Arm test results are not too clean as there is quite a bit of noise from failing watchpoints tests. I'll try with GDB 13 just to be sure. > > For the record, those patches were: > > commit d72ba177c85f2ad18d0dcabdd8844532c9acb819 > Author: Torbj�rn SVENSSON > Date: Thu Nov 17 12:17:53 2022 +0100 > Subject: gdb: dwarf2 generic implementation for caching function data > > ... and ... > > commit 5cf11483141a58314834653003e49709b47822d5 > Author: Torbj�rn SVENSSON > Date: Thu Nov 17 12:18:20 2022 +0100 > Subject: gdb/arm: Use new dwarf2 function cache > > Thank you!