From: Simon Marchi <simark@simark.ca>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Unify Solaris procfs and largefile handling
Date: Wed, 29 Jul 2020 15:55:11 -0400 [thread overview]
Message-ID: <169bf482-296b-737d-2a48-581d5b1d92bb@simark.ca> (raw)
In-Reply-To: <ydd5za64lhc.fsf@CeBiTec.Uni-Bielefeld.DE>
On 2020-07-29 7:19 a.m., Rainer Orth wrote:
> It's even simpler: every configure script has code to parse
> --enable-foo/--disable-foo and turn the result into enable_foo=[yes|no].
Ok, nice!
> No: the code has been (and should remain) like this. It allows the user
> to override the automatic largefile detection with explicit
> --enable-largefile/--disable-largefile options without having to change
> the code.
Ack.
> I've now removed AC_ARG_ENABLE from largefile.m4. Retested on
> i386-pc-solaris2.11 without and with --disable-gdb, checking that
> _FILE_OFFSET_BITS are set as expected, and amd64-pc-solaris2.11.
>
> Ok for master now?
When I run `autoreconf -vf`, I get a lot of changes. Make sure to run
it in any directory you touch that has a configure.ac and add the resulting
changes.
Simon
next prev parent reply other threads:[~2020-07-29 19:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 15:15 Rainer Orth
2020-07-01 12:46 ` Nick Clifton
2020-07-09 10:50 ` Rainer Orth
2020-07-20 11:28 ` Rainer Orth
2020-07-28 13:03 ` Rainer Orth
2020-07-28 13:47 ` Simon Marchi
2020-07-28 13:51 ` Rainer Orth
2020-07-28 14:17 ` Simon Marchi
2020-07-29 11:19 ` Rainer Orth
2020-07-29 19:55 ` Simon Marchi [this message]
2020-07-30 9:17 ` Rainer Orth
2020-07-30 12:43 ` Simon Marchi
2020-07-30 13:49 ` Rainer Orth
2020-08-07 15:12 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169bf482-296b-737d-2a48-581d5b1d92bb@simark.ca \
--to=simark@simark.ca \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).