From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id DDF54385700E;
 Wed, 29 Jul 2020 19:55:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DDF54385700E
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 156391E792;
 Wed, 29 Jul 2020 15:55:11 -0400 (EDT)
Subject: Re: [PATCH] Unify Solaris procfs and largefile handling
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
References: <yddbll0mvov.fsf@CeBiTec.Uni-Bielefeld.DE>
 <51f44a63-3062-39e5-14c5-ed08e32f2129@simark.ca>
 <yddime74ujs.fsf@CeBiTec.Uni-Bielefeld.DE>
 <5aae580e-ab2e-f008-91c6-f3b1c1f757b7@simark.ca>
 <ydd5za64lhc.fsf@CeBiTec.Uni-Bielefeld.DE>
From: Simon Marchi <simark@simark.ca>
Message-ID: <169bf482-296b-737d-2a48-581d5b1d92bb@simark.ca>
Date: Wed, 29 Jul 2020 15:55:11 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <ydd5za64lhc.fsf@CeBiTec.Uni-Bielefeld.DE>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2020 19:55:16 -0000

On 2020-07-29 7:19 a.m., Rainer Orth wrote:
> It's even simpler: every configure script has code to parse
> --enable-foo/--disable-foo and turn the result into enable_foo=[yes|no].  

Ok, nice!

> No: the code has been (and should remain) like this.  It allows the user
> to override the automatic largefile detection with explicit
> --enable-largefile/--disable-largefile options without having to change
> the code.

Ack.

> I've now removed AC_ARG_ENABLE from largefile.m4.  Retested on
> i386-pc-solaris2.11 without and with --disable-gdb, checking that
> _FILE_OFFSET_BITS are set as expected, and amd64-pc-solaris2.11.
> 
> Ok for master now?

When I run `autoreconf -vf`, I get a lot of changes.  Make sure to run
it in any directory you touch that has a configure.ac and add the resulting
changes.

Simon