From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21741 invoked by alias); 13 Feb 2015 19:21:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21720 invoked by uid 89); 13 Feb 2015 19:21:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,NO_DNS_FOR_FROM,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mailuogwhop.emc.com Received: from mailuogwhop.emc.com (HELO mailuogwhop.emc.com) (168.159.213.141) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 13 Feb 2015 19:21:35 +0000 Received: from maildlpprd03.lss.emc.com (maildlpprd03.lss.emc.com [10.253.24.35]) by mailuogwprd02.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t1DJDO8K025926 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 13 Feb 2015 14:13:27 -0500 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd02.lss.emc.com t1DJDO8K025926 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd02.lss.emc.com t1DJDO8K025926 Received: from mailsyshubprd54.lss.emc.com (mailsyshubprd54.lss.emc.com [10.106.48.29]) by maildlpprd03.lss.emc.com (RSA Interceptor); Fri, 13 Feb 2015 14:13:03 -0500 Received: from usendtaylorx2l.lss.emc.com (usendtaylorx2l.lss.emc.com [10.243.10.188]) by mailsyshubprd54.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t1DJDA0c017544; Fri, 13 Feb 2015 14:13:10 -0500 Received: by usendtaylorx2l.lss.emc.com (Postfix, from userid 26043) id 093A95DE5D8; Fri, 13 Feb 2015 14:13:06 -0500 (EST) Received: from usendtaylorx2l (localhost [127.0.0.1]) by usendtaylorx2l.lss.emc.com (Postfix) with ESMTP id 6B9545DE58D; Fri, 13 Feb 2015 14:13:06 -0500 (EST) To: Stan Shebs cc: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: two agent expression nits (one line each) In-reply-to: <54DB9139.7000206@earthlink.net> References: <14583.1410458050@usendtaylorx2l> <547E24E5.8050908@earthlink.net> <20141213134428.GF5457@adacore.com> <23074.1418658035@usendtaylorx2l> <20141220171955.GG12884@adacore.com> <18513.1423000644@usendtaylorx2l> <54DB9139.7000206@earthlink.net> Comments: In-reply-to Stan Shebs message dated "Wed, 11 Feb 2015 12:28:25 -0500." Date: Fri, 13 Feb 2015 19:21:00 -0000 Message-ID: <17089.1423854786@usendtaylorx2l> From: David Taylor X-RSA-Classifications: DLM_1, public X-Sentrion-Hostname: mailuogwprd02.lss.emc.com X-SW-Source: 2015-02/txt/msg00348.txt.bz2 Stan Shebs wrote: > On 2/3/15 1:57 PM, David Taylor wrote: > > Joel Brobecker wrote: > > > >> Hi David, > > > > [...] > > > >> Since you understand what should be done, would you mind sending > >> a patch in for Stan to review? > >> > >> -- > >> Joel > > > > Joel, > > > > Sorry for the delay. Here's the patch. Also, I haven't forgotten that > > I owe you an updated patch for bad structure offsets. And I have some > > others in the queue to finish up and post, as well. > > These changes are both fine as posted, thanks! > > And I agree that they would be good candidates for 7.9 branch as well. > > Stan Will someone please commit these for me (as I do not have commit privs)? Thanks. > > > > Stan, > > > > Here's the ChangeLog entries: > > > > gdb: > > > > 2015-02-03 David Taylor > > > > * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > > > gdb/doc: > > > > 2015-02-03 David Taylor > > > > * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > > > > > > and patch, as requested by Joel: > > > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > > index 351ccdd..0118d7d 100644 > > --- a/gdb/ChangeLog > > +++ b/gdb/ChangeLog > > @@ -1,3 +1,7 @@ > > +2015-02-03 David Taylor > > + > > + * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > + > > 2015-02-02 Joel Brobecker > > > > * dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker. > > diff --git a/gdb/common/ax.def b/gdb/common/ax.def > > index 8b27725..27c97cc 100644 > > --- a/gdb/common/ax.def > > +++ b/gdb/common/ax.def > > @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29) > > DEFOP (zero_ext, 1, 0, 1, 1, 0x2a) > > DEFOP (swap, 0, 0, 2, 2, 0x2b) > > DEFOP (getv, 2, 0, 0, 1, 0x2c) > > -DEFOP (setv, 2, 0, 0, 1, 0x2d) > > +DEFOP (setv, 2, 0, 1, 1, 0x2d) > > DEFOP (tracev, 2, 0, 0, 1, 0x2e) > > DEFOP (tracenz, 0, 0, 2, 0, 0x2f) > > DEFOP (trace16, 2, 0, 1, 1, 0x30) > > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog > > index 9c12d9a..34fee48 100644 > > --- a/gdb/doc/ChangeLog > > +++ b/gdb/doc/ChangeLog > > @@ -1,3 +1,7 @@ > > +2015-02-03 David Taylor > > + > > + * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > > + > > 2015-01-31 Gary Benson > > Doug Evans > > > > diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi > > index 788de1c..297cd5e 100644 > > --- a/gdb/doc/agentexpr.texi > > +++ b/gdb/doc/agentexpr.texi > > @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a > > 16-bit on an unaligned address raises an exception, you should fetch the > > register number one byte at a time. > > > > -@item @code{setv} (0x2d) @var{n}: @result{} @var{v} > > +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v} > > Set trace state variable number @var{n} to the value found on the top > > of the stack. The stack is unchanged, so that the value is readily > > available if the assignment is part of a larger expression. The > > >