Re: GDB 10.2 Release: Proposing Mar 13-14 for official GDB 10.2 release

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2021-03-09 9:48 p.m., Joel Brobecker wrote:
> Hi Simon,
> 
>> A new issue has popped up:
>>
>>   https://sourceware.org/bugzilla/show_bug.cgi?id=27541
>>
>> Tom Tromey and I would be good candidates to look a it,
>> because it's related to the DWARF symbol sharing, which
>> we've both worked on.  I will try to give it a look in
>> the following days.
> 
> Thanks for the heads up, Simon. I've changed its Target Mileston
> to 10.2 in Bugzilla.
> 

I've been looking at this on and off for the last few days, and I don't
think I'll be able to come up with a proper fix in a short time frame.
And even if I did, I think it would be too risky for merging in a stable
branch right before releasing.

The alternative I see to unblock the release is to disable the sharing of
partial symbols between objfiles for now.  Essentially, a patch that does

    diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
    index 704ba9f36655..5d9256bece1e 100644
    --- a/gdb/dwarf2/read.c
    +++ b/gdb/dwarf2/read.c
    @@ -1954,7 +1954,8 @@ dwarf2_has_info (struct objfile *objfile,
             doesn't require relocations and if there aren't partial symbols
             from some other reader.  */
           if (!objfile_has_partial_symbols (objfile)
    -         && !gdb_bfd_requires_relocations (objfile->obfd))
    +         && !gdb_bfd_requires_relocations (objfile->obfd)
    +         && 0)
            {
              /* See if one has been created for this BFD yet.  */
              per_bfd = dwarf2_per_bfd_bfd_data_key.get (objfile->obfd);

We can then take our time to look at a proper fix for master.

Simon