From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BB4A0385801D for ; Mon, 15 Mar 2021 03:43:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BB4A0385801D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12F3hMdL018725 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 14 Mar 2021 23:43:27 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12F3hMdL018725 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 086951E54D; Sun, 14 Mar 2021 23:43:21 -0400 (EDT) Subject: Re: GDB 10.2 Release: Proposing Mar 13-14 for official GDB 10.2 release To: Joel Brobecker , Simon Marchi , Tom Tromey Cc: gdb-patches@sourceware.org References: <20210306064611.GB807147@adacore.com> <06d96113-d09b-993f-0f55-00c297b4e591@simark.ca> <20210310024850.GA247585@adacore.com> From: Simon Marchi Message-ID: <17184b08-d7e7-a62c-b689-35ab3f179f06@polymtl.ca> Date: Sun, 14 Mar 2021 23:43:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210310024850.GA247585@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 15 Mar 2021 03:43:22 +0000 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 03:43:33 -0000 On 2021-03-09 9:48 p.m., Joel Brobecker wrote: > Hi Simon, > >> A new issue has popped up: >> >> https://sourceware.org/bugzilla/show_bug.cgi?id=27541 >> >> Tom Tromey and I would be good candidates to look a it, >> because it's related to the DWARF symbol sharing, which >> we've both worked on. I will try to give it a look in >> the following days. > > Thanks for the heads up, Simon. I've changed its Target Mileston > to 10.2 in Bugzilla. > I've been looking at this on and off for the last few days, and I don't think I'll be able to come up with a proper fix in a short time frame. And even if I did, I think it would be too risky for merging in a stable branch right before releasing. The alternative I see to unblock the release is to disable the sharing of partial symbols between objfiles for now. Essentially, a patch that does diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 704ba9f36655..5d9256bece1e 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -1954,7 +1954,8 @@ dwarf2_has_info (struct objfile *objfile, doesn't require relocations and if there aren't partial symbols from some other reader. */ if (!objfile_has_partial_symbols (objfile) - && !gdb_bfd_requires_relocations (objfile->obfd)) + && !gdb_bfd_requires_relocations (objfile->obfd) + && 0) { /* See if one has been created for this BFD yet. */ per_bfd = dwarf2_per_bfd_bfd_data_key.get (objfile->obfd); We can then take our time to look at a proper fix for master. Simon